I ruin developers’ lives with my code reviews and I'm sorry

Post by switch007 » Wed, Feb 20, 2019, 8:49 AM UTC

ljm wrote: post #158

finnthehuman wrote: post #28

This guy ties his ego to his code, and assumes everyone does the same. The proposed solution is to not devalue the person by devaluing the code. This seems exactly backwards to me. Disconnecting ego from the work was the first big lesson I had when I started working in software. I hear parallel ideas from friends across industries, in fact an electrical contractor explained to me how he expects it of his apprentices…

I've had my fair share of controversial code reviews, both on the giving and receiving end. I no longer ask 'why?' inside a code review, because it immediately puts the author in the position of justifying what they did, while feeling like they have to defend a decision. Instead, I'll take a coaching (or a more socratic) approach that doesn't risk making the author feel dumb, or like they never considered the alterna…

Post by meko » Wed, Feb 20, 2019, 7:54 PM UTC

Izkata wrote: post #128

redleggedfrog wrote: post #87

Earlier quoted context omitted.

I wish I had 100 up votes for this quote: "Disconnecting ego from the work was the first big lesson I had when I started working in software." Until you can do that, you'll always be a lesser software developer. You'll concentrate on maintaining your ego instead of developing the best software for the problem at hand. In a way that's the gist of the article. It's interesting, but at the company I've worked at, where…

> Until you can do that, you'll always be a lesser software developer. Reminds me of a joke-ish comment I saw on here some time ago: The difference between a junior and senior developer is the willingness to say "that bug was totally my fault".