Live data from Hacker News

I ruin developers’ lives with my code reviews and I'm sorry

habr.com

61–70 of 164 posts

Re: I ruin developers’ lives with my code reviews and I'm sorry

#61
post #9

This guy sounds like a massive, toxic asshole. I'm tired of dealing with people like this. It does not have to be this hard. Tech companies should fire more people just for being jerks. > I was mad that, while I spent my nights learning F#, my daughter started calling everyone around “fathers”. Huh, you mean missing out on the good parts of life while martyring yourself for a company that does not give a shit about y…

[deleted]

Re: I ruin developers’ lives with my code reviews and I'm sorry

#62
post #9

This guy sounds like a massive, toxic asshole. I'm tired of dealing with people like this. It does not have to be this hard. Tech companies should fire more people just for being jerks. > I was mad that, while I spent my nights learning F#, my daughter started calling everyone around “fathers”. Huh, you mean missing out on the good parts of life while martyring yourself for a company that does not give a shit about y…

This comment has bullying energy in its own right.

Re: I ruin developers’ lives with my code reviews and I'm sorry

#63
post #30

BTW does anyone have a good guide, book, tutorial on doing code reviews? Everywhere I've been its kinda adhoc with no rules or guidelines. Often code reviews come in after someone has put a few weeks of work into something and its too late to change how it was done. Or a review is passed in by someone in a hurry without actually critiquing it.

my one suggestion is to make your code reviews have more questions than statements. so instead of: ‘forgot to check for null here’, do something like: ’do you think we can have a null issue here?’. in my mind, this word change makes the reviewee feel like they’re not just being told what to change, but actually have a sense of code ownership and control over their work

Re: I ruin developers’ lives with my code reviews and I'm sorry

#64
post #9

This guy sounds like a massive, toxic asshole. I'm tired of dealing with people like this. It does not have to be this hard. Tech companies should fire more people just for being jerks. > I was mad that, while I spent my nights learning F#, my daughter started calling everyone around “fathers”. Huh, you mean missing out on the good parts of life while martyring yourself for a company that does not give a shit about y…

I also felt weird reading this. I really want to see some of this person's "code reviews." Two hundred comments on a pull request? How many of the comments are useful and actionable?

I love having my code thoroughly reviewed. It does not ruin my life to see someone say "I don't think this is a good idea." I think you have to be operating on a different level to be ruining lives through pull request comments.

Re: I ruin developers’ lives with my code reviews and I'm sorry

#65

I've seen a few cases where otherwise talented developers would kind of miss the point of code reviews and focus on code style much more than the code itself, nitpicky stuff like sorting of imports, etc., leaving hundreds of comments while at the same time overlooking quite serious bugs. Presumably, codestyle comes easy for them due to their neurotype, but they have a hard time reining themselves in and just end up w…

I sometimes fall into a similar trap. Usually on the larger changelists where I was struggling to keep the focus necessary to find the serious bugs, but not being comfortable only looking at half the files in the code review - feeling like I'd not be doing my part of the job I didn't at least look at them. I have to remind myself that there's a limit to how useful nitpicking can be, and that it can become counterprod…

I don't have your context, but if the changelist author is writing multithreaded code where there's no way that a reader can convince themselves of the correctness, then my heuristic is that the burden is on the author to improve the code to be easier to reason about and add enough tests to exercise all of the interesting code paths. There are always techniques to simplify code or make it easier to grasp.

Re: I ruin developers’ lives with my code reviews and I'm sorry

#66

>And if you tell me that you haven’t had this feeling ever, then you’re lying. Tell me about higher goals, training rookies and all that — I know you’re simply too full of themselves. And if you try to tell me that you learned to defeat that feeling (however it manifests in you), then I must be a pink unicorn. Are you kidding? Call me a liar if you want, but I don't feel that way when doing code reviews, and never ha…

So you haven't -ever- been overly critical or tried to show off? Because your comment made it sound like you have improved over time and feel less of a need to improve yourself now.

Re: I ruin developers’ lives with my code reviews and I'm sorry

#67
post #9

This guy sounds like a massive, toxic asshole. I'm tired of dealing with people like this. It does not have to be this hard. Tech companies should fire more people just for being jerks. > I was mad that, while I spent my nights learning F#, my daughter started calling everyone around “fathers”. Huh, you mean missing out on the good parts of life while martyring yourself for a company that does not give a shit about y…

>I'm tired of dealing with people like this. It does not have to be this hard. Tech companies should fire more people just for being jerks.

The problem is that the traits that make someone a 'jerk' are often the same traits that make a '10x developer'.

Re: I ruin developers’ lives with my code reviews and I'm sorry

#68
I’ve had to go through code reviews (as a freelancer) conducted by people who clearly were angry people and who had no (current) development experience. Their job titles were Technical Design Architects and part of their job was to make sure outsiders weren’t polluting their companies code base.

When I’d justify my decisions they’d go Google and always manage to find a counter point. But their having to Google it made it obvious they lacked deep understanding of much of anything.

There was one guy who was particularly notorious for being harsh and awkward to work with. I found this to be true but he was also the only guy who seemed to understand concepts so I was able to work him (to everyone’s surprise!)

I saw many other developers frequently get a bruising but I always managed to take a step back and focus around the real problem - the people in charge were just angry.

Re: I ruin developers’ lives with my code reviews and I'm sorry

#69
"If a guy brings me his code, and it has mistakes, it brings insane pleasure from how smart I feel ... And if you tell me that you haven’t had this feeling ever, then you’re lying."

Wrong on so many levels. Taking pleasure from someone else's mistakes is a sign that something is wrong with you. That is all. The only thing that is exceptional is that this industry has a high tolerance for this behaviour.

It also sounds like this guy is destroying value. If you are such a poor manager that you try to get rid of someone rather than bringing them up then you are a net negative. Again, I have come across this in other industries: the manager will go before the junior. No question. Writing bad code is nothing compared to the impact on culture of one bad apple.

Re: I ruin developers’ lives with my code reviews and I'm sorry

#70
> I haven’t ever thought about the issue seriously and didn’t have any decent arguments, but I couldn’t stop arguing nonetheless. I had one goal — to win and save face. I still don’t know why.

I'm 100% like this. I'm not proud of it, and while I guess I can hypothesize about "why", my takeaway is the same as the author's : it's a horrible and potentially very hurtful anti-pattern.

Kudos to this dude for raising his hand and acknowledging his own problem. All I can say is, I'm the same way and I can and should do better.

Post reply on HN