Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Go is moving to GitHub

groups.google.com

Post reply on HN
Print view View original

51–60 of 244 posts

Re: Go is moving to GitHub

#51

Post by mmphosis »

bbx wrote: post #45

Google hosting Go on GitHub. Microsoft hosting .NET on GitHub. It must feel like an accomplishment to be implicitly endorsed by these companies. Considering open source's history, you'd think its primary management tool would be open source as well. I guess it's GitHub's combination of accessible design + performant version control + lack of ads + reliability that made it the premium source for anything open source.…

Now we just need Apple's Objective C / Swift to move to github. :) Sorry, not going to happen. :(

Re: Go is moving to GitHub

#52

Post by yohanatan »

negated wrote: post #10
jeffreyrogers wrote: post #5

It is great to see so many projects moving to git and GitHub in particular. GitHub is incredibly helpful for quickly taking a look at a project and figuring out what areas of a project are still evolving and being actively developed.

You could also say that everyone moving to GitHub is leading to a dangerous centralized monoculture that evaluates software quality based on how well it fits GitHub's conventions.

See: https://news.ycombinator.com/item?id=8605321

Re: Go is moving to GitHub

#53

Post by nathany »

enneff wrote: post #19
tkrajcar wrote: post #11

Earlier quoted context omitted.

I'm curious what Gerrit gets them that Github doesn't have natively, too.

There are a lot of things lacking about GitHub's code review process (pull requests). Off the top of my head: - Merging a pull request (almost) always creates a merge commit, polluting the change history. Gerrit will automatically rebase the changes atop the master branch head, leaving a nice linear history. - Pull requests require the contributor to create a public fork of the repository they're committing to. I can…

I'm really curious to give Gerrit a try. Is it like the existing Rietveld system used for Go?

- I've been using the "apply mail" flow to avoid merge commits and to squash commits when appropriate (based on Nathaniel Talbott's post http://blog.spreedly.com/author/ntalbott/#.VGVhz5PF_Zs). It will be nice to have something automatic.

- At least contributors with the commit bit can just create a feature branch and a pull request from there. Some open source projects give out the commit bit almost immediately, but with GitHub there's still that initial fork and pull request to prove oneself.

Interested to see how Gerrit addresses this. GitHub doesn't have any way to disable pull requests. :-(

- I've completely disabled email notifications for this reason. There still can be a huge number of notifications in app or via third-party mobile apps. Rietveld is a lot more sane, I only saw notifications for things I was actively working on.

- I usually end up reviewing just the new commits individually. But that requires figuring out which ones I had already reviewed. Not so bad with only a few branches, but I can see it getting out of hand.

I really hope people from GitHub are reading this thread as they are working to improve their tools. :-)

Re: Go is moving to GitHub

#54

Post by yohanatan »

enneff wrote: post #24
yohanatan wrote: post #17

Earlier quoted context omitted.

Probably a combination of both really. I get the sense that the 'Commander' hasn't done the requisite reading.

Anyone that knows Rob will tell you that you're simply wrong about this.

Only if you are inside the cult could you possibly have that opinion. Do you also think that Jim Jones was an expert on the New Testament teachings? If you take his word for it, of course he was.

Re: Go is moving to GitHub

#55

Post by yohanatan »

dsymonds wrote: post #23
yohanatan wrote: post #17

Earlier quoted context omitted.

Probably a combination of both really. I get the sense that the 'Commander' hasn't done the requisite reading.

I just asked him in person. He has.

Only if you are inside the cult could you possibly believe that. Do you also think that Jim Jones was an expert on the New Testament teachings? If you take his word for it, of course he was.

Re: Go is moving to GitHub

#56

Post by tracker1 »

hahainternet wrote: post #33
yohanatan wrote: post #20

Earlier quoted context omitted.

Totally serious. And, it's not just the lack of generics-- that's just the tip of the iceberg.

What problems have the lack of generics caused you in development?

In JavaScript, none at all.. ;-)

In C#, before generics, wiring up a typed collection/enumerable was seriously painful.

Re: Go is moving to GitHub

#57

Post by ch4s3 »

yid wrote: post #36

The writing's on the wall for Google Code. I don't think I've seen a new feature in several years.

I'd love for them to just go read only, a TON of academic work lives on there, but its awful to use.

Re: Go is moving to GitHub

#58

Post by enneff »

yohanatan wrote: post #48
enneff wrote: post #30

Earlier quoted context omitted.

So, you're criticising someone for not doing something that's impossible? Just stop.

The portion of that material which is requisite is obviously a strict subset of the entirety of the material. But, for one to flippantly say "I've read it" without even establishing what "it" is, seems a bit dismissive and duplicitous to me. Regardless it is obvious to anyone who is knowledgeable that Rob Pike has not read what most who are in the know would consider "requisite". Also, if you take a look at the threa…

Rob didn't really say anything about map, filter, and reduce in that thread. His comments should be taken as being in addition to the earlier comments by Ian Lance Taylor, another member of the Go team.

You should address the gaps in your own knowledge before criticising others. For instance, you're obviously unaware that Rob designed and implemented a whole language based around map/reduce/filter style operations: http://static.googleusercontent.com/external_content/untrust...

Re: Go is moving to GitHub

#59

Post by jrockway »

tkrajcar wrote: post #11
virtue3 wrote: post #2

Does anyone know what code review system they are using with github?

I'm curious what Gerrit gets them that Github doesn't have natively, too.

The key features for me are:

1) The ability to have multiple reviewers, who can provide both human-readable input ("fix this") and machine-readable input ("Code Review +2"). This becomes powerful when you require a couple things to submit, code review and verification that the change works. A TryBot or something can automatically +1 the Verified bit when the tests pass, and the reviewer can +2 the Code Review bit on the assumption that the code compiles and the tests pass. Requiring both makes review easier and the repository less likely to break. Sounds like extra bureaucracy, but it's actually really wonderful.

2) Pushing the onus of merging and submitting to the author, instead of the reviewer. I can say "looks good, fix the merge conflicts" and be done with the review. With Github, the repository owner has to do the merge (or push back and re-review; I pick doing it myself).

Github's code review tool is really aimed at accepting or rejecting; not improving. At least how I use it, anyway.

Re: Go is moving to GitHub

#60

Post by enneff »

yohanatan wrote: post #54
enneff wrote: post #24

Earlier quoted context omitted.

Anyone that knows Rob will tell you that you're simply wrong about this.

Only if you are inside the cult could you possibly have that opinion. Do you also think that Jim Jones was an expert on the New Testament teachings? If you take his word for it, of course he was.

We (the Go team) regularly have conversations about all kinds of programming paradigms, because we're into that kind of stuff. Some of us really like functional programming languages. But Go is not that kind of language, so those primitives do not belong there. Go is not everything to everyone, and it would be a mistake to try to make it that way. That doesn't mean that we don't see those things as generally valuable, just not in this context.
Post reply on HN