Does anyone know what code review system they are using with github?
I'm curious what Gerrit gets them that Github doesn't have natively, too.
Go is moving to GitHub
11–20 of 244 posts
Re: Go is moving to GitHub
#12Does anyone know what code review system they are using with github?
I'm curious what Gerrit gets them that Github doesn't have natively, too.
Gerrit works well for a project that has many different repositories, as you can do code review all in one screen.
I did some CyanogenMod development and I really liked gerrit, albeit its poor performance on Firefox (client side app that had weird JS freezes in fx only..)
Re: Go is moving to GitHub
#13Which will have no bearing on the case of Go. Go has already been relegated to the bottom of the quality bin for my purposes by its designer(s)' ignorance of the last 30 years of type system research and hostility towards the functional style.
See: https://groups.google.com/forum/#!topic/golang-nuts/RKymTuSC...
Re: Go is moving to GitHub
#14Props on the move, it shows that golang is flexible to make moves for what's best for the community rather than stick it out in google code. I hope this results in benefits to the iteration cycle.
Re: Go is moving to GitHub
#15Does anyone know what code review system they are using with github?
I'm curious what Gerrit gets them that Github doesn't have natively, too.
Go team member here.
I've used five different code review tools, and Github is the worst of the five. I regularly bug them (Github) about this, and they know it. I hear rumors they've been working on it a lot.
Github's review mechanisms barely scratch the surface of what's possible.
Re: Go is moving to GitHub
#16Which will have no bearing on the case of Go. Go has already been relegated to the bottom of the quality bin for my purposes by its designer(s)' ignorance of the last 30 years of type system research and hostility towards the functional style. See: https://groups.google.com/forum/#!topic/golang-nuts/RKymTuSC...
I think you mean s/ignorance/rejection/.
Re: Go is moving to GitHub
#17Which will have no bearing on the case of Go. Go has already been relegated to the bottom of the quality bin for my purposes by its designer(s)' ignorance of the last 30 years of type system research and hostility towards the functional style. See: https://groups.google.com/forum/#!topic/golang-nuts/RKymTuSC...
I think you mean s/ignorance/rejection/.
Probably a combination of both really. I get the sense that the 'Commander' hasn't done the requisite reading.
Re: Go is moving to GitHub
#18Which will have no bearing on the case of Go. Go has already been relegated to the bottom of the quality bin for my purposes by its designer(s)' ignorance of the last 30 years of type system research and hostility towards the functional style. See: https://groups.google.com/forum/#!topic/golang-nuts/RKymTuSC...
Really? You've managed to mention the lack of generics on a thread announcing moving go to github? Is this a parody comment or are you serious?
Re: Go is moving to GitHub
#19Does anyone know what code review system they are using with github?
I'm curious what Gerrit gets them that Github doesn't have natively, too.
There are a lot of things lacking about GitHub's code review process (pull requests). Off the top of my head:
- Merging a pull request (almost) always creates a merge commit, polluting the change history. Gerrit will automatically rebase the changes atop the master branch head, leaving a nice linear history.
- Pull requests require the contributor to create a public fork of the repository they're committing to. I can see how this works for some people, but I find it gross for each contributor to the Go project to have their own public fork. What a mess.
- Comments on pull requests are sent as soon as they are created. Gerrit allows you to make many comments on a change, as drafts, and then send them all in one go, sending just a single email. This is much easier to manage for a large project.
- Gerrit has the notion of multiple 'patch sets' for a particular change, and you can see diffs between patch sets, so it's much easier to progressively review large changes.
And there are many other small issues with the GitHub pull request process that make it untenable for the Go project.
Re: Go is moving to GitHub
#20Which will have no bearing on the case of Go. Go has already been relegated to the bottom of the quality bin for my purposes by its designer(s)' ignorance of the last 30 years of type system research and hostility towards the functional style. See: https://groups.google.com/forum/#!topic/golang-nuts/RKymTuSC...
Really? You've managed to mention the lack of generics on a thread announcing moving go to github? Is this a parody comment or are you serious?
Totally serious. And, it's not just the lack of generics-- that's just the tip of the iceberg.