Live data from Hacker News

1,145 pull requests per day

saile.it

81–90 of 91 posts

Re: 1,145 pull requests per day

#81
post #63
post #60

Earlier quoted context omitted.

Based on DORA research it's correlated with the engineering team/company being a high-performer.

The "Accelerate" book claims it is not just correlation but even causation: Higher deployment frequency causes better company performance.

Given that its trivially easy to produce unbounded amounts of useless PRs this cannot be a causation.

Re: 1,145 pull requests per day

#82
post #50

The comments so far are surprising. Yea counting PRs and lines of code isn’t impressive, and yes you may also do them at your own company. Any engineer will tell you, if you push code often and continuously move it to production, regression is inevitable. In finance, at a scale that stripe operates, not making mistakes is very critical. Being able to do what the articles describes is very impressive in any engineerin…

Fuck the mission. Fuck the culture. You are doing nothing but shoveling money into founders, investors and shareholders pockets. https://news.ycombinator.com/item?id=32165794

What of you have a lot of stock options? You are part of the shareholders.

Re: 1,145 pull requests per day

#83
post #55

> few nuggets scattered on the internet regarding how Stripe does things (ex. #1, #2, #3) and in general the conclusion is that they have a very demanding but very advanced engineering culture #3 is "What I Miss About Working at Stripe" ( https://every.to/p/what-i-miss-about-working-at-stripe ) reminiscing about 15-hour days, missing vacations, and crying at work. discussed here; https://news.ycombinator.com/item?id=…

patio11 is a great read

supremely talented writer. much better than the average New Yorker or Altantic Montly writer.

Re: 1,145 pull requests per day

#84
post #63

Earlier quoted context omitted.

The "Accelerate" book claims it is not just correlation but even causation: Higher deployment frequency causes better company performance.

Given that its trivially easy to produce unbounded amounts of useless PRs this cannot be a causation.

That's kind of what I was feeling. There is nothing that really keeps someone from just making BS tiny PRs

Re: 1,145 pull requests per day

#85

Is counting the number of pull requests a useful measure of engineering performance ergo product performance and company perf? Isn't it more like a BS counter that keep incrementing and that is indicative of churn but nothing else reliably. One of the most low effort, easily to game metric that can be skewed to show anything that the user wants to show.

In the aggregate I'm sure it's useful. To evaluate a single individual contributor it is not.

Re: 1,145 pull requests per day

#86
post #53

My previous company averaged 2 PRs (and deploys) per engineer per day across a small team. At my current company I'm averaging about 2.5 CLs per day (they're a bit smaller changes). Stripe is good at this, but this is very achievable. Often the problem is that we put too much into a single change. Smaller changes means easier reviews, better reviews, less risky deploys, forces better tooling for deployments and chang…

> CL Googler identified.

What is a CL?

Re: 1,145 pull requests per day

#87
post #53

Earlier quoted context omitted.

> CL Googler identified.

What is a CL?

Change list. It's a Perforce term approximately equivalent to "PR", but also, perhaps more familiarly to the HN audience, the term used at Google with the internal fork of Perforce that powers its gigantic monorepo.

Re: 1,145 pull requests per day

#88
post #82
post #50

Earlier quoted context omitted.

Fuck the mission. Fuck the culture. You are doing nothing but shoveling money into founders, investors and shareholders pockets. https://news.ycombinator.com/item?id=32165794

What of you have a lot of stock options? You are part of the shareholders.

Well then you are also bad, of course, because there exist people who are doing worse than you.

Re: 1,145 pull requests per day

#90

Earlier quoted context omitted.

What is a CL?

Change list. It's a Perforce term approximately equivalent to "PR", but also, perhaps more familiarly to the HN audience, the term used at Google with the internal fork of Perforce that powers its gigantic monorepo.

Further to this, CLs are essentially a single commit, which means that they are often (but don't have to be) smaller than a PR that might contain a stack of commits. You don't generally do as much rework in later CLs like you might with git commits, generally you'd do all your development iteration on the same CL, rewriting it until it's ready, rather than stacking many commits like in git.
Post reply on HN