Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

1,145 pull requests per day

saile.it

Post reply on HN
Print view View original

41–50 of 91 posts

Re: 1,145 pull requests per day

#41

Post by coolcase »

hellojimbo wrote: post #14

Conventional "dev" wisdom says that LOC and PR count don't matter but I think its very easy to combine this data point with the nature of a dev's work to come up with a great heuristic on productivity.

It is good for ballparking. PR count is more interesting as if it is high it means you must have a good CI CD pipeline. I worked places where there were limits on commits a day due to monolith plus master CI/CD taking an hour. You then end up thinking of strategies like "I'll do that in the afternoon and get it to that state and it gets merged at this time" and so on. Which is inefficient.

Re: 1,145 pull requests per day

#42

Post by thewisenerd »

> few nuggets scattered on the internet regarding how Stripe does things (ex. #1, #2, #3) and in general the conclusion is that they have a very demanding but very advanced engineering culture

#3 is "What I Miss About Working at Stripe" (https://every.to/p/what-i-miss-about-working-at-stripe) reminiscing about 15-hour days, missing vacations, and crying at work.

discussed here; https://news.ycombinator.com/item?id=32159752 (131 comments)

Re: 1,145 pull requests per day

#43

Post by JimDabell »

cuttothechase wrote: post #7

Is counting the number of pull requests a useful measure of engineering performance ergo product performance and company perf? Isn't it more like a BS counter that keep incrementing and that is indicative of churn but nothing else reliably. One of the most low effort, easily to game metric that can be skewed to show anything that the user wants to show.

> With some napkin math assuming a similar distribution today, that would mean on average each engineer ships at least 1 change to production every 3 days.

This is the important metric. It means there is very little divergence between what’s being worked on and what’s in production. The smaller the difference, the quicker you deliver value to users and the less risky it is to deploy.

Re: 1,145 pull requests per day

#44

Post by compumike »

webprofusion wrote: post #5

Lol, yeah but a PR won't fix that expired cert.

... but a small PR might warn you when your renewal automation breaks, before the cert actually expires: https://heiioncall.com/blog/barebone-scripts-to-check-ssl-ce... (a small blog post I wrote with example scripts for checking SSL cert expiry from Bash, Python, Ruby, more) ;)

Re: 1,145 pull requests per day

#46

Post by tonyhart7 »

thewisenerd wrote: post #42

> few nuggets scattered on the internet regarding how Stripe does things (ex. #1, #2, #3) and in general the conclusion is that they have a very demanding but very advanced engineering culture #3 is "What I Miss About Working at Stripe" ( https://every.to/p/what-i-miss-about-working-at-stripe ) reminiscing about 15-hour days, missing vacations, and crying at work. discussed here; https://news.ycombinator.com/item?id=…

wow, so like Asian company culture???

Re: 1,145 pull requests per day

#48

Post by eviks »

> The goal is not 1,145 deployments per day. It's removing the friction that makes that pace impossible. What's really stopping you from rapidly shipping value to users?

But you haven't identified any value, just mindless cited some throughput stat. Merge your code changes in 1-letter increments and you can juke the stats even higher!

Re: 1,145 pull requests per day

#50

Post by dakiol »

darth_avocado wrote: post #22

The comments so far are surprising. Yea counting PRs and lines of code isn’t impressive, and yes you may also do them at your own company. Any engineer will tell you, if you push code often and continuously move it to production, regression is inevitable. In finance, at a scale that stripe operates, not making mistakes is very critical. Being able to do what the articles describes is very impressive in any engineerin…

Fuck the mission. Fuck the culture. You are doing nothing but shoveling money into founders, investors and shareholders pockets.

https://news.ycombinator.com/item?id=32165794

Post reply on HN