This is great. I love reading stuff like this to gain other's insight, and just to give me incentive to look at cool open source code.
Does anybody have additional recommendation of similar reviews of interesting open source code?
Doom 3 Source code review
41–50 of 64 posts
Re: Doom 3 Source code review
#42I liked especially the 2012 Q&A with John Carmack:
http://fabiensanglard.net/doom3/interviews.php
The blog author goes full nerd, like (paraphrasing) "You did this genius thing making a frontend/backend pipeline for rendering. Was this inspired by LCC? What are the advantages to a monolithic renderer?" and Cormack answers practically "Oh, didn't help that much, because of an unexplainable quirk of OpenGL it only worked well on my developer machine."
:-p
Re: Doom 3 Source code review
#43> the variables highlights and the "Command-Click" to reach a definition make the experience superior to Visual Studio. Seriously ? There may be reasons to think Visual Studio is an inferior product, these are not among them.
He mentioned just for code browsing so don't panic. Nobody in their right mind would think XCode compares to Visual Studio. I mean it's 2012 and there is still no refactoring support.
Xcode supports Rename, Extract, Create Superclass, Move Up, Move Down, Encapsulate.
http://developer.apple.com/library/mac/#documentation/ToolsL...
I took a look at Whole Tomato: http://www.wholetomato.com/products/featureRefactoring.asp
A couple of those features Xcode implements using code completion. It looks like Whole Tomato may be slightly better, but your comment is clearly wrong.
Re: Doom 3 Source code review
#44Earlier quoted context omitted.
The engine (idTech4) is released under GPL. Thus, you can use it for commercial use without paying anything. I guess you can also still buy a non-GPLed version.
Derivative work that uses the engine must be GPL'd too. That is bad for commercial products that intend to be closed source; I guess those are the commercial products that buy the engine.
But that doesn't apply to the maps, sounds, and textures which are really the heart of the game.
Re: Doom 3 Source code review
#45Earlier quoted context omitted.
From sohn, who is dead: "That's bullshit. What if my connection is slow and I want to leave the page loading whilst I do some other things."
Scroll the page to the bottom, scroll it back up, then go do your other things.
Of course you have to know to do this.
Re: Doom 3 Source code review
#46> the variables highlights and the "Command-Click" to reach a definition make the experience superior to Visual Studio. Seriously ? There may be reasons to think Visual Studio is an inferior product, these are not among them.
not to mention ctrl+click does the same in visual studio with productivity power tools plugin.
Re: Doom 3 Source code review
#47Attention readers: For some reason i cannot comprehend the pages use javascript to load some images. There are no noscript elements notifying you about this. So enable javascript to read through this.
Attention readers: For some reason I cannot comprehend people use the internet in 2012 with javascript and cookies disabled and then whine when some things don't work.
Re: Doom 3 Source code review
#48Very respectable of id to release it. I bet the could still get some sold cash from it if they kept it closed.
They dont open source the latest version. Tech 5 already came out.
>They dont open source the latest version.
I never said they did?!?
Doesn't matter though. Even the version before the current is still pretty new tech & interesting to study.
Re: Doom 3 Source code review
#49Attention readers: For some reason i cannot comprehend the pages use javascript to load some images. There are no noscript elements notifying you about this. So enable javascript to read through this.
Attention readers: For some reason I cannot comprehend people use the internet in 2012 with javascript and cookies disabled and then whine when some things don't work.
FYI, some people use NoScript to pick and choose which JavaScript they allow to run.
Re: Doom 3 Source code review
#50>In some part of the code (see dmap page) there are actually more comments than statements. >Dmap source code is very well commented, just look at the amount of green: There is more comments than code ! You know, in my experience that's not a good thing. I work on similar, heavily-commented code and find it extremely painful. At some point it becomes a burden to see the code behind the comments. (And just so no one m…
Unfortunately bad comments like this leads people into thinking that all or most comments are useless.
It's true that I don't want to see a comment like "loop through this 50 times". But what may not be obvious is the purpose of the loop, the significance of the number 50. Putting in "why" can save hours.
The only exception where I would want a comment that just says what a line of code is for a really complex line, like a complicated regex for example.