Live data from Hacker News

Doom 3 Source code review

fabiensanglard.net

21–30 of 64 posts

Re: Doom 3 Source code review

#21
post #19
post #12

Earlier quoted context omitted.

The images are not loaded until you scroll them into view, so bandwidth is saved if you don't read the whole article.

In that case the noscript fallback should be loading all immediately.

That's true. It seems like javascript disabling is just not on the minds of web developers. You have to be a special kind of masochist to use noscript these days... I used it for years, but ghostery covers most of what I liked about it.

Re: Doom 3 Source code review

#22
post #21
post #19

Earlier quoted context omitted.

In that case the noscript fallback should be loading all immediately.

That's true. It seems like javascript disabling is just not on the minds of web developers. You have to be a special kind of masochist to use noscript these days... I used it for years, but ghostery covers most of what I liked about it.

I don't use noscript (if you mean the Firefox addon). I was talking about the tag. ;)

I use Opera with Javascript and Cookies disabled because most things work fine and are much less annoying with that setup.

Re: Doom 3 Source code review

#23
post #12
post #6

Attention readers: For some reason i cannot comprehend the pages use javascript to load some images. There are no noscript elements notifying you about this. So enable javascript to read through this.

The images are not loaded until you scroll them into view, so bandwidth is saved if you don't read the whole article.

From sohn, who is dead:

"That's bullshit. What if my connection is slow and I want to leave the page loading whilst I do some other things."

Re: Doom 3 Source code review

#24
post #11

Earlier quoted context omitted.

Throwing the baby out with the bath water. I'd much rather have good comments.

The problem is that comments are often only good the first few times you read them. After heavily hacking on some code for a while, you know the comments. I find the ability to fold comments very valuable.

Unfortunately, that tends to lead to vary stale comments which hinders the next developer.

Re: Doom 3 Source code review

#25
post #22
post #21

Earlier quoted context omitted.

That's true. It seems like javascript disabling is just not on the minds of web developers. You have to be a special kind of masochist to use noscript these days... I used it for years, but ghostery covers most of what I liked about it.

I don't use noscript (if you mean the Firefox addon). I was talking about the tag. ;) I use Opera with Javascript and Cookies disabled because most things work fine and are much less annoying with that setup.

Well I guess the overall improvement must be worth images not loading on this page and whining on HN. So, what's the problem again? O you think your setup should be added as an edge case, sorry non standard setups are often not worth catering to. If you want it to work just enable scrips, it's not that hard.

Re: Doom 3 Source code review

#26
post #5

>In some part of the code (see dmap page) there are actually more comments than statements. >Dmap source code is very well commented, just look at the amount of green: There is more comments than code ! You know, in my experience that's not a good thing. I work on similar, heavily-commented code and find it extremely painful. At some point it becomes a burden to see the code behind the comments. (And just so no one m…

> Please don't write out what the programming language constructs do in English.

Exactly this. Comment the why, not the what.

Re: Doom 3 Source code review

#27
post #5

>In some part of the code (see dmap page) there are actually more comments than statements. >Dmap source code is very well commented, just look at the amount of green: There is more comments than code ! You know, in my experience that's not a good thing. I work on similar, heavily-commented code and find it extremely painful. At some point it becomes a burden to see the code behind the comments. (And just so no one m…

Depends on the code imo. If its vicious 3D code that is fully of tricky optimization then a pile of comments is perfect.

Re: Doom 3 Source code review

#29
I really like Fabians source code reviews. Would love to see engines like Unreal being open-sourced to compare how they work internally. Would be a nice perspective. I.e. Unreal was much better in out-door scenes and I think the maps where not heavily preprocessed like in Quake et.al. What was their way of tackling the problem?

In case there are any resources that describe the technical details, would be nice If someone could post a link.

Post reply on HN