Some insightful comments on the github are getting deleted.
Linus Torvalds won't do github pull requests
61–70 of 288 posts
Re: Linus Torvalds won't do github pull requests
#62It's 2012 and we're still arguing about line breaks and 80-character lines?
It's 2012 and Gmail can't consistently reflow lines in emails between its flagship web client and its flagship Android client... so yes, it would appear so.
Re: Linus Torvalds won't do github pull requests
#63It's instructive to read Linus's commits to his hobby project "subsurface": https://github.com/torvalds/subsurface/commits/master Even if I can't code like Linus, I can at least try to write commit messages like his…
It always puzzled me why his commits (and in fact standard commits) ought to start with a verb that is not in its past form. When I started using git four months ago (such a newbie), I would write something like "Fixed this" instead of "Fix this". Anybody with more insights on this? I am just curious.
Whether your commit is historical or not depends on your point of view. Git is distributed. For whose repository is it historical? What if I pull out the commit using git format-patch? Is it still historical now?
Re: Linus Torvalds won't do github pull requests
#64It's 2012 and we're still arguing about line breaks and 80-character lines?
I think 80-character lines are less an issue of the availability of horizontal screen space and more about readability. Much the same way proper sentence and paragraph spacing and structure lend to the readability of long articles or other blocks of text, a properly short line length can lend to the readability of commit logs.
Re: Linus Torvalds won't do github pull requests
#65I hope the github folks get involved in this. I'm specially interested in what they have to say about why they decided to go with what Linus calls _their own totally inferior version_. Love this no-nonsense style, but let me say that it's no only the style, but that Linus has enough on his side to back it up.
It's the enfant terrible style. Signals that you are special, and are willing to back it up, so let's just end the conversation. Nice time saver when you actually are special and can back it up. Terrifically destructive for a "B" surrounded by timid people. A good way to drive a team right over the cliff. I've seen a lot of the latter so I tend to react negatively to it. Plus it's never really "nice".
Re: Linus Torvalds won't do github pull requests
#66Man, now I feel like a total hack. I love the github pull request. I do insist that my devs use a good style (i.e. first line is a summary and wrap at 80 chars) but I love the user interface for looking at diffs and doing a code review. I had no idea it was inferior until reading this and now I find myself in the awkward position that I don't care. Have I really become the guy who values an efficient team process mor…
The pull request as a mechanism for "here are some changes to look at" for a small project isn't the same thing as "Here are the USB stack changes for the 3.4 merge window". The kernel has a mature, rigorous and well-defined development process[1]. Things that don't fit well into that model just aren't going to be successful, even if they work well in other contexts. [1] http://git.kernel.org/?p=linux/kernel/git/torv…
It's also worth pointing out that the "pull request" in question here was a 2-liner addition of a USB device ID that should have gone to a subsystem maintainer anyway.
Re: Linus Torvalds won't do github pull requests
#67Earlier quoted context omitted.
> Git is a notoriously user-hostile piece of software Then you probably didn't use any SCCS before git. Because CVS is even uglier, Bitkeeper is the reason Linus wrote git and every other I tried was more "user-hostile" than git. > pretty much the only thing it has going for it on the usability front is Github. You sound like a Visual Basic programmer who just saw C for the first time. Edit: Bitkeeper, not bucket!
Bitkeeper. Bitbucket (and Mercurial) did not exist when Linus started writing Git.
I stand corrected.
Re: Linus Torvalds won't do github pull requests
#68I don't mean to be overly critical, but is it just me or are the 'godfathers' of computer science starting to sound like cranky old men?
I mean....ok....this pull request being inferior to the way HE (the creator of Git) imagined it (or implemented it) is a bit petty imho.
What's with the complaining? I am sure this is not the first time I have heard him complaining about something on Github or some other 'new technology'. The same goes with Crockford and his semi-colon.
Edit: Although, I must confess that it is annoying when the creators of a service that you use totally blow off your suggestions (esp. when that service is built on your own creation).....so I am torn on this one. Still has the 'annoying old man complaining feel' to it though.
Re: Linus Torvalds won't do github pull requests
#69I hope the github folks get involved in this. I'm specially interested in what they have to say about why they decided to go with what Linus calls _their own totally inferior version_. Love this no-nonsense style, but let me say that it's no only the style, but that Linus has enough on his side to back it up.
He made the same comments when he first moved some projects to GitHub. I believe the kernel.org servers were having issues at the time. In response to these comments, we pushed out several changes nearly immediately, including a completely redesigned Pull Request email notification. We're always listening for feedback and are working on improving the experience for everyone. It's too bad that useful bits of feedback…
Unrelated note: why is there not a news feed for each project? I have a news feed with tons of watched repositories but they all blend together in an unusable mess. I would like to see the history of a project that is not just commits. something like ///timeline that shows all activity (commits, comments, pull requests, issues, etc....)
Re: Linus Torvalds won't do github pull requests
#70Considering Linus created git, if I were running github I'd tend to listen to whatever he had to say about it...
Devil's advocate: Considering GitHub popularized git, if I were in charge of git I'd listen to what the GitHub guys have to say about it.
Depends where. Projects like the linux kernel (obviously), Xorg and Firefox had all moved to git before github ever showed up. It was well on it's way to popularity all on its own merits