What, Linus found something he doesn't like?
Linus Torvalds won't do github pull requests
11–20 of 288 posts
Re: Linus Torvalds won't do github pull requests
#12Considering Linus created git, if I were running github I'd tend to listen to whatever he had to say about it...
Devil's advocate:
Considering GitHub popularized git, if I were in charge of git I'd listen to what the GitHub guys have to say about it.
Re: Linus Torvalds won't do github pull requests
#13Considering Linus created git, if I were running github I'd tend to listen to whatever he had to say about it...
Considering that GitHub is probably the second best thing about Git after the fact of its existence, I think that both sides of the table have something valid to say.
Re: Linus Torvalds won't do github pull requests
#14Can someone point me to the tool that comes with git for pull-request functionality?
Guessing he's talking about the format-patch/am pair, but can't be sure as I'm not him.
Either that, or just sending a mail with a link to your own git repo requesting a pull.
Re: Linus Torvalds won't do github pull requests
#15Can someone point me to the tool that comes with git for pull-request functionality?
$ man git-request-pull
Re: Linus Torvalds won't do github pull requests
#16I agree with Linus on a lot of things, but I wonder sometimes if he rubs people up the wrong way occasionally.
Re: Linus Torvalds won't do github pull requests
#17I agree with Linus on a lot of things, but I wonder sometimes if he rubs people up the wrong way occasionally.
He makes no bones about it. Git got its name because Linus thinks of himself as a git.
Re: Linus Torvalds won't do github pull requests
#18That's pretty relevant comment. GitHub pull request system is great if you want to attract a bunch of script kiddies to participate on your project. For serious work, not so much.
I would say the same about github's forks-as-top-level-entities system. Forking a project is a huge deal. Forking a git repository is no big deal. Github does the former, and it encourages too-broad forks, and at the same time, discourages coordination and contribution with the original project. Nearly all forks should be short-lived and completely subsidiary to the main project .
While many projects / companies work as you say, the linux kernel development model has always been much more like how github does forks. Git was designed to be truly distributed and de-centralized, although many people choose not to use it that way.
Re: Linus Torvalds won't do github pull requests
#19That's pretty relevant comment. GitHub pull request system is great if you want to attract a bunch of script kiddies to participate on your project. For serious work, not so much.
I would say the same about github's forks-as-top-level-entities system. Forking a project is a huge deal. Forking a git repository is no big deal. Github does the former, and it encourages too-broad forks, and at the same time, discourages coordination and contribution with the original project. Nearly all forks should be short-lived and completely subsidiary to the main project .
That's a lot of opinions and much less arguments (no offense). Would you care to explain the motivations behind the opinions?
Re: Linus Torvalds won't do github pull requests
#20I have to agree with Linus on this and it's nice that he's taking time to write out his thoughts in public.
GitHub commit messages can be really ugly. I'm guilty of this and it's not something I'm proud of. I think the small improvement they did a while ago with the display of commit messages is a step in the right direction, I wish they would apply that same style to the web interface when composing commit messages.
edit: A good fix would be a way to turn off pull requests for projects or at least redirect users on how to send pull requests.