Earlier quoted context omitted.
> If you are calling out your colleagues for doing bad work, or not the way you would do it work, you should try to rephrase into praise w/ direction. “I really liked how you tackled this, have you thought about this approach?” Instead of “Why didn’t you do it this way?” I don't want to work with people that communicate this way.
I do. Having worked with so many engineers with almost no social skills, I think there's a lot of room for improvement in their communication style. "Why didn't you do it this way?" is aggressive and critical. "have you thought about this approach?" makes them feel like you have their back and are trying to help. I agree there's not a huge need to the "I really liked how you tackled this" part but even never praising…
Wrapping of criticism in praise is a poor substitute for genuinely praising good work, and being empathetic and helpful with direct, unambiguous feedback when someone can improve. Mistakes are inevitable. They're not a problem. It's ok to discuss them directly.