Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Vuejs rejects close to 75% of outside contributions

merge-chance.info

Post reply on HN
Print view View original

41–50 of 92 posts

Re: Vuejs rejects close to 75% of outside contributions

#41

Post by bird_monster »

that_guy_iain wrote: post #28
bird_monster wrote: post #10

Earlier quoted context omitted.

> I think this is a good thing generally, Vue has consistently been one of the best engineered and most effectively designed pieces of software in the Javascript world, largely due to uncompromising enforcement of the design opinions and aesthetics it asserts. Which is much easier to attain if you're comfortable with only a single person being allowed to write code. Personally, I wouldn't use Vue in any business-orie…

The org has 49 people on it. And every project that has one people who leads it can surive without that person, it's called they fork the project.

https://github.com/vuejs/vue/graphs/contributors?from=2016-0...

Here you can find the code additions Github Insight.

The org can have 49 people in it, but 48 of them are not writing code for Vue.js.

Re: Vuejs rejects close to 75% of outside contributions

#43

Post by darkerside »

zinekeller wrote: post #21

I will talk about accepting outside contributions in a general sense (beyond JS and Julia comparisons). In my personal experience, the acceptance rates doesn't really matter and does not correlate to the quality of the code. On one hand, you have SQLite which really discourages direct code submissions due to the nature of the IP management of SQLite (they need to ensure that it is 100% in public domain), instead rely…

I'm confused. My intuition is that the lower the acceptance rate, the higher the code quality would be. It demonstrates high standards.

Re: Vuejs rejects close to 75% of outside contributions

#44

Post by santoshalper »

young_unixer wrote: post #38
zinekeller wrote: post #21

I will talk about accepting outside contributions in a general sense (beyond JS and Julia comparisons). In my personal experience, the acceptance rates doesn't really matter and does not correlate to the quality of the code. On one hand, you have SQLite which really discourages direct code submissions due to the nature of the IP management of SQLite (they need to ensure that it is 100% in public domain), instead rely…

You say acceptance rate doesn't correlate with code quality and then you give 2 data points where it does correlate in the expected way.

He's playing the long con.

Re: Vuejs rejects close to 75% of outside contributions

#45

Post by ljm »

bitwize wrote: post #23
MaKey wrote: post #18

Earlier quoted context omitted.

There is no need to bring politics into software development wherever possible. I don't care who has written the code, code itself is apolitical.

Everything is political. Everything is affected by, and affects, the political decisions we, the people, make. The last few years have been instructive in what happens if we ignore fascism and allow ourselves to relax when it comes to anti-fascist vigilance.

This is a bit extreme, and also quite unhelpful, truthfully. It just happens to sound virtuous because the crosshairs are pointed at fascism, and that's ignoring the myopic focus on the US' issues.

Pick your battles, as the saying goes. It is possible to care about issues without carpet bombing everyone with your concerns, or wedging politics into every discussion.

And similarly, be careful what you wish for. It sounds like a terrible and exhausting way to live.

Re: Vuejs rejects close to 75% of outside contributions

#46

Post by zinekeller »

gieksosz wrote: post #25
zinekeller wrote: post #21

I will talk about accepting outside contributions in a general sense (beyond JS and Julia comparisons). In my personal experience, the acceptance rates doesn't really matter and does not correlate to the quality of the code. On one hand, you have SQLite which really discourages direct code submissions due to the nature of the IP management of SQLite (they need to ensure that it is 100% in public domain), instead rely…

On top of that some repos, like Bazel for instance close all PRs and import them via a process which happens outside GitHub. Some repositories do not use GitHub organisations at all, other do it a lot - those factors make merge-chance.info analysis more difficult, but I still think it is interesting. I hope it might even help someone chose what project to contribute to.

I think that if you want to contribute, they should at least be upfront on the processes, or even the absence of it. Some do not accept at all, some do only accept on bugfixes, and some are happy to extend the project. The chance of merging of course is a decent barometer for contributors who wants to work on projects who are allegedly open to contributions, but I will not use it as a barometer of the quality of the code itself (or at least as a minor barometer - never as a major one).

Re: Vuejs rejects close to 75% of outside contributions

#47

Post by mlthoughts2018 »

ng12 wrote: post #33
mlthoughts2018 wrote: post #4

I think this is a good thing generally, Vue has consistently been one of the best engineered and most effectively designed pieces of software in the Javascript world, largely due to uncompromising enforcement of the design opinions and aesthetics it asserts. As long as the maintainers are responsive to bug fixes and key feature requirements (since they aren’t accepting of outside contributors adding them), then this…

I think the opposite: it's a sign that your API is too wide and users expect more special cases and edge features to solve their needs.

If a user felt that way, it would make no sense for them to choose Vue. Vue’s up-front, stated design goal is omit special cases or edge features intentionally and directly assert that’s not a good way to design a framework.

Vue may be right or wrong, but nobody wishing for special case features can claim to be surprised. If you picked Vue knowing you need a bunch of special case features, that’s on you.

Re: Vuejs rejects close to 75% of outside contributions

#48

Post by gieksosz »

thih9 wrote: post #32

I wish the submitter added their comment or gave some context, if there is any. For me this is an arbitrary number for a random popular repository. Especially since the linked github project https://github.com/vuejs/vue is not the latest version of vue (see: https://github.com/vuejs/vue-next ).

Author here. I am still exploring useful metrics for classifying open source projects. My initial intent was to find a way to judge if given project is a good use of time for a first time contributor, someone not affiliated with original authors.

Re: Vuejs rejects close to 75% of outside contributions

#49

Post by MaKey »

ipsocannibal wrote: post #26
MaKey wrote: post #18

Earlier quoted context omitted.

There is no need to bring politics into software development wherever possible. I don't care who has written the code, code itself is apolitical.

"I don't care who has written the code, code itself is apolitical" When backdoors are added to your service framework, when dragnet data collection services copy every artifact of your digital existence in the name of "national security" or when algorithms have been trained to distinguish faces specificly of your race you will damn sure want to know who wrote that code and why. Its just naive to think tools exist out…

I agree. I was aiming at the context of the parent comment. The employer of someone (e. g. Facebook) shouldn't have an effect on how their code is treated.
Post reply on HN