Vuejs rejects close to 75% of outside contributions
merge-chance.info
Vuejs rejects close to 75% of outside contributions
1–10 of 92 posts
Re: Vuejs rejects close to 75% of outside contributions
#2Looking at the PR history for the vuejs repo, I can't say that I'm surprised. Holy hell, what a wasteland.
Re: Vuejs rejects close to 75% of outside contributions
#3Looking at the PR history for the vuejs repo, I can't say that I'm surprised. Holy hell, what a wasteland.
It seems to happen more often for big JS projects like React and Vue. Julia projects do not seem to suffer from that.
Re: Vuejs rejects close to 75% of outside contributions
#4I think this is a good thing generally, Vue has consistently been one of the best engineered and most effectively designed pieces of software in the Javascript world, largely due to uncompromising enforcement of the design opinions and aesthetics it asserts.
As long as the maintainers are responsive to bug fixes and key feature requirements (since they aren’t accepting of outside contributors adding them), then this is fine, possibly even optimal in terms of quality.
The trouble comes in if they both don’t allow many outside contributions and at the same time they pull the same unjustified complaint of a lot of OSS and say because they aren’t paid for their time, they will prioritize what interests them rather than what resolves painpoints or missing features users need. You definitely can’t have it both ways.
Re: Vuejs rejects close to 75% of outside contributions
#5Looking at the PR history for the vuejs repo, I can't say that I'm surprised. Holy hell, what a wasteland.
Ya, here's some examples of spam:
https://github.com/vuejs/vue/pull/11847/files
https://github.com/vuejs/vue/pull/11853/files
https://github.com/vuejs/vue/pull/11820/files
https://github.com/vuejs/vue/pull/11818/files
All within the last month.
Maybe there's some tutorial for 'how to submit a PR on GitHub' that links to Vue.js and people are following that?
Re: Vuejs rejects close to 75% of outside contributions
#6Looking at the PR history for the vuejs repo, I can't say that I'm surprised. Holy hell, what a wasteland.
Yep. The OP submitted a similar thread earlier today about 50% of external React PRs being rejected, and I left a comment saying that it's a combo of the React codebase being complex and most external PRs being junk or irrelevant.
Re: Vuejs rejects close to 75% of outside contributions
#7As long as you can play Doom.
Re: Vuejs rejects close to 75% of outside contributions
#8Looking at the PR history for the vuejs repo, I can't say that I'm surprised. Holy hell, what a wasteland.
Ya, here's some examples of spam: https://github.com/vuejs/vue/pull/11847/files https://github.com/vuejs/vue/pull/11853/files https://github.com/vuejs/vue/pull/11820/files https://github.com/vuejs/vue/pull/11818/files All within the last month. Maybe there's some tutorial for 'how to submit a PR on GitHub' that links to Vue.js and people are following that?
Thank you, I had the best laugh of the day. Also has a point.
Re: Vuejs rejects close to 75% of outside contributions
#9Looking at the PR history for the vuejs repo, I can't say that I'm surprised. Holy hell, what a wasteland.
Ya, here's some examples of spam: https://github.com/vuejs/vue/pull/11847/files https://github.com/vuejs/vue/pull/11853/files https://github.com/vuejs/vue/pull/11820/files https://github.com/vuejs/vue/pull/11818/files All within the last month. Maybe there's some tutorial for 'how to submit a PR on GitHub' that links to Vue.js and people are following that?
You’re exactly right re: tutorials. See the Hacktoberfest drama on HN from last October for more examples of this sort of thing.
Re: Vuejs rejects close to 75% of outside contributions
#10I think this is a good thing generally, Vue has consistently been one of the best engineered and most effectively designed pieces of software in the Javascript world, largely due to uncompromising enforcement of the design opinions and aesthetics it asserts. As long as the maintainers are responsive to bug fixes and key feature requirements (since they aren’t accepting of outside contributors adding them), then this…
> I think this is a good thing generally, Vue has consistently been one of the best engineered and most effectively designed pieces of software in the Javascript world, largely due to uncompromising enforcement of the design opinions and aesthetics it asserts.
Which is much easier to attain if you're comfortable with only a single person being allowed to write code. Personally, I wouldn't use Vue in any business-oriented application for this exact reason. The "bus factor", or as I would call it, "If and when Evan decides to stop caring about Vue", is enough to make Vue dead in the water as a legitimate FE library choice (to me).