Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Vuejs rejects close to 75% of outside contributions

merge-chance.info

Post reply on HN
Print view View original

21–30 of 92 posts

Re: Vuejs rejects close to 75% of outside contributions

#21

Post by zinekeller »

I will talk about accepting outside contributions in a general sense (beyond JS and Julia comparisons).

In my personal experience, the acceptance rates doesn't really matter and does not correlate to the quality of the code. On one hand, you have SQLite which really discourages direct code submissions due to the nature of the IP management of SQLite (they need to ensure that it is 100% in public domain), instead relying on bug reports instead. SQLite however is a very good product, something that I personally miss when I work on JS projects.

On the other hand, I've seen projects (multiple, which I prefer not naming to prevent flame wars) with very high acceptance rates - the problem is that the coding style and availability of comments are inconsistent to the point that we have to forego using some libraries and writing our own despite those libraries will fit into the bill nicely.

Edit: some have commented "this is what I've expected!", but there are some projects (obviously will be unnamed) that are not accepting contributions but the code consistency is less-than-ideal, and some projects with well-behaved outside contributors that have kept the quality despite having high acceptance rates (usually writing in relatively niche languages). Probably the area I'm working on (educational) isn't reflective on the wider community, which seems to associate higher rejection rates to quality.

Re: Vuejs rejects close to 75% of outside contributions

#22

Post by bitwize »

judge2020 wrote: post #5
BugsJustFindMe wrote: post #2

Looking at the PR history for the vuejs repo, I can't say that I'm surprised. Holy hell, what a wasteland.

Ya, here's some examples of spam: https://github.com/vuejs/vue/pull/11847/files https://github.com/vuejs/vue/pull/11853/files https://github.com/vuejs/vue/pull/11820/files https://github.com/vuejs/vue/pull/11818/files All within the last month. Maybe there's some tutorial for 'how to submit a PR on GitHub' that links to Vue.js and people are following that?

That third one reminds me of the "covfefe" meme a while back (our Dear Leader at the time was also attempting to type the word "coverage").

Re: Vuejs rejects close to 75% of outside contributions

#23

Post by bitwize »

MaKey wrote: post #18
jdieiueejjene wrote: post #13

The best part about Vue is it isn’t sponsored by giant evil corporation like Facebook who have enabled violence and racism for the past 4 years. We as developers need to do better and support people like Evan out there. Eventually, we should also hold individual engineers who work at Facebook/similar accountable to a higher standard and reject their software even if it’s open source or wonderful (React).

There is no need to bring politics into software development wherever possible. I don't care who has written the code, code itself is apolitical.

Everything is political. Everything is affected by, and affects, the political decisions we, the people, make. The last few years have been instructive in what happens if we ignore fascism and allow ourselves to relax when it comes to anti-fascist vigilance.

Re: Vuejs rejects close to 75% of outside contributions

#24

Post by that_guy_iain »

felipellrocha wrote: post #12
mlthoughts2018 wrote: post #4

I think this is a good thing generally, Vue has consistently been one of the best engineered and most effectively designed pieces of software in the Javascript world, largely due to uncompromising enforcement of the design opinions and aesthetics it asserts. As long as the maintainers are responsive to bug fixes and key feature requirements (since they aren’t accepting of outside contributors adding them), then this…

> Vue has consistently been one of the best engineered and most effectively designed pieces of software in the Javascript world I wonder how you justify that, because I'm currently maintaining a vue project in production and couldn't disagree more (honest question)

> I wonder how you justify that, because I'm currently maintaining a vue project in production and couldn't disagree more (honest question)

I am sure majority of developers have had two or more projects using the same framework/library and found the difficulty of maintaining them different.

Re: Vuejs rejects close to 75% of outside contributions

#25

Post by gieksosz »

zinekeller wrote: post #21

I will talk about accepting outside contributions in a general sense (beyond JS and Julia comparisons). In my personal experience, the acceptance rates doesn't really matter and does not correlate to the quality of the code. On one hand, you have SQLite which really discourages direct code submissions due to the nature of the IP management of SQLite (they need to ensure that it is 100% in public domain), instead rely…

On top of that some repos, like Bazel for instance close all PRs and import them via a process which happens outside GitHub. Some repositories do not use GitHub organisations at all, other do it a lot - those factors make merge-chance.info analysis more difficult, but I still think it is interesting. I hope it might even help someone chose what project to contribute to.

Re: Vuejs rejects close to 75% of outside contributions

#26

Post by ipsocannibal »

MaKey wrote: post #18
jdieiueejjene wrote: post #13

The best part about Vue is it isn’t sponsored by giant evil corporation like Facebook who have enabled violence and racism for the past 4 years. We as developers need to do better and support people like Evan out there. Eventually, we should also hold individual engineers who work at Facebook/similar accountable to a higher standard and reject their software even if it’s open source or wonderful (React).

There is no need to bring politics into software development wherever possible. I don't care who has written the code, code itself is apolitical.

"I don't care who has written the code, code itself is apolitical"

When backdoors are added to your service framework, when dragnet data collection services copy every artifact of your digital existence in the name of "national security" or when algorithms have been trained to distinguish faces specificly of your race you will damn sure want to know who wrote that code and why. Its just naive to think tools exist outside of their intended function and political ends often determine those functions.

Re: Vuejs rejects close to 75% of outside contributions

#27

Post by Fellshard »

bitwize wrote: post #23
MaKey wrote: post #18

Earlier quoted context omitted.

There is no need to bring politics into software development wherever possible. I don't care who has written the code, code itself is apolitical.

Everything is political. Everything is affected by, and affects, the political decisions we, the people, make. The last few years have been instructive in what happens if we ignore fascism and allow ourselves to relax when it comes to anti-fascist vigilance.

I'm going to be somewhat blunt in response, but I hope it's not seen as an attack. The phrase 'everything is political' is not a statement of truth, but rather a statement of demand: 'make everything political'. That is a tool to turn up the temperature of a given topic dramatically, not to encourage thoughtful change.

Re: Vuejs rejects close to 75% of outside contributions

#28

Post by that_guy_iain »

bird_monster wrote: post #10
mlthoughts2018 wrote: post #4

I think this is a good thing generally, Vue has consistently been one of the best engineered and most effectively designed pieces of software in the Javascript world, largely due to uncompromising enforcement of the design opinions and aesthetics it asserts. As long as the maintainers are responsive to bug fixes and key feature requirements (since they aren’t accepting of outside contributors adding them), then this…

> I think this is a good thing generally, Vue has consistently been one of the best engineered and most effectively designed pieces of software in the Javascript world, largely due to uncompromising enforcement of the design opinions and aesthetics it asserts. Which is much easier to attain if you're comfortable with only a single person being allowed to write code. Personally, I wouldn't use Vue in any business-orie…

The org has 49 people on it. And every project that has one people who leads it can surive without that person, it's called they fork the project.

Re: Vuejs rejects close to 75% of outside contributions

#29

Post by rkho »

Spone wrote: post #20
MaKey wrote: post #18

Earlier quoted context omitted.

There is no need to bring politics into software development wherever possible. I don't care who has written the code, code itself is apolitical.

> code itself is apolitical I suggest you read Larry Lessig's Code 2.0 book.

I do not believe "read a 426-page book" should be considered a reasonable response here. At best this response is short-sighted.

Re: Vuejs rejects close to 75% of outside contributions

#30

Post by panabee »

felipellrocha wrote: post #12
mlthoughts2018 wrote: post #4

I think this is a good thing generally, Vue has consistently been one of the best engineered and most effectively designed pieces of software in the Javascript world, largely due to uncompromising enforcement of the design opinions and aesthetics it asserts. As long as the maintainers are responsive to bug fixes and key feature requirements (since they aren’t accepting of outside contributors adding them), then this…

> Vue has consistently been one of the best engineered and most effectively designed pieces of software in the Javascript world I wonder how you justify that, because I'm currently maintaining a vue project in production and couldn't disagree more (honest question)

do you mind sharing the problems? if you could start over, would you have chosen react instead?
Post reply on HN