181–190 of 246 posts
Please next time link to the source and not to another discussion forum: https://www.youtube.com/watch?v=H8Gd9t7FQqI
I tried to write a little bit every day, cause it is something that gives me joy, but I never have a project taking off like those guys, so I don't know how much free time they have to start new projects or to program just for fun.
To think that [them] having made so much progress in the kernel by carrying a "Lean and Mean" profile for all of those decades is astounding! My guess is Linus is still L&M (if people didn't enjoy his lean, they wouldn't appreciate his mean), but perhaps he's not in his element right now (and just taking a breather). Either way, I'm a fan (not a professional) of a lean (looking) codebase with perhaps a new "overlay"…
Earlier quoted context omitted.
That’s interesting, because every office I’ve been in is like this while working only with and building proprietary software Tool flame wars, constant bike shedding, “that’s too abstract” premature optimization wars (apparently a list comprehension is too abstract for some eng, if-else all the way down!). Every Medium post by a tech somebody becomes a religious soapbox. I quit it all but kept my job. People complain…
> Edit: Oh almost forgot my “favorite”: environments where open source is leveraged heavily. Millions of lines of imported code, at best 5% was written internally. But somehow the business environment is that they’re engineering thought leaders for building a “tech biz” around a traditional business model. Smh This is definitely a serious issue. Imo, unless the project is tiny, your own codebase should be at least th…
Earlier quoted context omitted.
I write detailed commit messages for every single commit I make(even though commits would be squashed on merges), I write detailed PR descriptions that included before/after screenshots in multiple resolutions whenever relevant. Never once did I have any indication that someone took their time to read descriptions or commit messages. In my previous job, I received some feedback from my manager that some people compla…
Yep, no one ever reads them and the cost to benefit ratio is extremely low. Writing good comments is far more important. Don't explain what the code does - that's what the code is for, explain the why and the background information in the code. Additional, explain what the code does at the function level or at the module level - at a much higher abstraction level basically than the line of the code. No one ever looks…
You're projecting. YOU never read them. I used to be the same way. Now I see other people reading them and I've started to myself. I follow other people's efforts and progress. It's a great way to learn not only the code but to communicate better.
Earlier quoted context omitted.
Yep, no one ever reads them and the cost to benefit ratio is extremely low. Writing good comments is far more important. Don't explain what the code does - that's what the code is for, explain the why and the background information in the code. Additional, explain what the code does at the function level or at the module level - at a much higher abstraction level basically than the line of the code. No one ever looks…
I think the issue with comments is that they lose all temporal and situational context. You see a comment next to code, but you have no idea if it's actually still addressing that piece of code. How out of date is that comment? Nobody knows. But if you look at the git history of all the edits specific to a part of code, you'll have a full view of what happened and why and by whom. I think the big issue is that progra…
You are assuming here that all programmers even "do" git. A lot don't. A whole lot of them. I worked with some companies that would have some horrible horrible version control system only and I just wanted to cry. Sure, git has its warts, but once you get it, it's a tool that can be _incredibly_ productive. I hate having good tools taken away.
Earlier quoted context omitted.
Yup, way too many times I’ve encountered code that’s written in a peculiar way obviously for a reason, most likely to work around some issue, but it’s not clear what the issue is and whether it is otherwise resolved so that the peculiar code can be dropped. I bisect and it says “fix bug”, now I need to carry that crap forever or worry about reintroducing some unknown bug. (In case someone points out a comment is more…
Why is the reason to peculiarity not in the comments in the code itself?
Earlier quoted context omitted.
I can confirm: if you try to back out, you are presented with a blue bar at the top saying something like "before you leave..." https://imgur.com/a/93wjGED
And when I click on that link I immediately get a popover ad for the Imgur app. The mobile web is such a mess.
> So commit messages to me are almost as important as the code change itself. Why commit messages rather than code comments?
Earlier quoted context omitted.
Spending time on commit messages that will be essentially removed when the PR is squashed seems... not very productive
I squash before I open the PR. Then I have last say in the commit message. Also it gives me a chance to figure out what I actually worked on.