Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

TravisBuddy: Adds comments to failed pull requests, tells author what went wrong

github.com

Post reply on HN
Print view View original

21–29 of 29 posts

Re: TravisBuddy: Adds comments to failed pull requests, tells author what went wrong

#21

Post by kemayo »

7Z7 wrote: post #14
dotsh wrote: post #5

Idea is great but this logo looks like evil douchebag kind of guy with this tagline "Not the bot you deserve, but the one you need" doesn't look great. You definitely need to work on your brand. :)

Came here to comment exactly this. The expression on the face is expressing all the wrong messages about the service.

It also seems to be the avatar for the account that leaves the automated comments on the pull requests. I suspect it can cause a subliminal "this is a jerk" response in the author of the pull request who you'd probably prefer to feel receptive to this feedback.

Re: TravisBuddy: Adds comments to failed pull requests, tells author what went wrong

#22

Post by kemayo »

neuronexmachina wrote: post #6
dotsh wrote: post #5

Idea is great but this logo looks like evil douchebag kind of guy with this tagline "Not the bot you deserve, but the one you need" doesn't look great. You definitely need to work on your brand. :)

It's a Batman (The Dark Knight) reference: "He's the hero Gotham deserves, but not the one it needs right now"

I suspect the grandparent knew this, and was making the point that the reference isn't sending a good message.

Re: TravisBuddy: Adds comments to failed pull requests, tells author what went wrong

#24

Post by ddm379 »

bigblind wrote: post #2

I really like this idea. I think more tools should integrate into GitHub this way. The status API is nice, but you always have to click through to get the details. I think you could do something similar with code analysis tools, so they make review comments in the code where issues occur.

I know this is nit-picky, but I'm not a fan of how the "Details" link opens in the same tab.

Re: TravisBuddy: Adds comments to failed pull requests, tells author what went wrong

#25

Post by bluzi »

neebz wrote: post #12
bluzi wrote: post #11

Earlier quoted context omitted.

Thanks for the feedback, we're working on methods to prevent TravisBuddy from commenting if the PR is being rapidly updated or if its comments are not relevant for some reason. One idea is that if the PR has a special label TravisBuddy won't comment on it. Another one is to be able to communicate with TravisBuddy using comments, so when you're sick of it you could just comment: "@TravisBuddy stop", and it'll stop imm…

You can do what codecov does; They keep updating the same comment with the latest result.

That's an awesome idea, will be a feature for sure.

Re: TravisBuddy: Adds comments to failed pull requests, tells author what went wrong

#26

Post by bluzi »

ddm379 wrote: post #24
bigblind wrote: post #2

I really like this idea. I think more tools should integrate into GitHub this way. The status API is nice, but you always have to click through to get the details. I think you could do something similar with code analysis tools, so they make review comments in the code where issues occur.

I know this is nit-picky, but I'm not a fan of how the "Details" link opens in the same tab.

Not sure what do you mean

Re: TravisBuddy: Adds comments to failed pull requests, tells author what went wrong

#27

Post by bluzi »

kemayo wrote: post #19
koolba wrote: post #7

Earlier quoted context omitted.

Reminds me of vault boy[1] from Fallout but with a sneaky hat on. https://www.google.com/search?q=vault+boy&tbm=isch

Yeah, but Vault Boy looks cheerful, this guy looks angry.

lol, noted

Re: TravisBuddy: Adds comments to failed pull requests, tells author what went wrong

#28

Post by jwilk »

dotsh wrote: post #5

Idea is great but this logo looks like evil douchebag kind of guy with this tagline "Not the bot you deserve, but the one you need" doesn't look great. You definitely need to work on your brand. :)

He looks like he's mocking you because your tests failed.

Re: TravisBuddy: Adds comments to failed pull requests, tells author what went wrong

#29

Post by bluntfang »

TomK32 wrote: post #3

Cute little list on the example screenshot. looks at own code with some 3300 tests

I'm not a travis user, but with Jenkins there is an xunit plugin that opens up an api with test results for the specific build. since xunit formatting is standard/generic, we've implemented a parser that just gets the # of pass/failed tests and links to the build for further investigation.

We had a similar problem where posting all of the results was just more noise than useful, this is at least a good starting point for handling build result feedback.

Post reply on HN