Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

TravisBuddy: Adds comments to failed pull requests, tells author what went wrong

github.com

Post reply on HN
Print view View original

11–20 of 29 posts

Re: TravisBuddy: Adds comments to failed pull requests, tells author what went wrong

#11

Post by bluzi »

diggan wrote: post #4

This will get messy quickly if you have a PR that you are adding commits to and have a failure for each commit. This has the same problem as some code coverage solutions, they are spamming the PR with comments that are only important for a few moments, then they are just noise... Speaking about finding test failures quickly though, Jenkins and many others (except ALL the cloud/SaaS solutions?) actually parse test res…

Thanks for the feedback, we're working on methods to prevent TravisBuddy from commenting if the PR is being rapidly updated or if its comments are not relevant for some reason. One idea is that if the PR has a special label TravisBuddy won't comment on it. Another one is to be able to communicate with TravisBuddy using comments, so when you're sick of it you could just comment: "@TravisBuddy stop", and it'll stop immediately. (Maybe even "@TravisBuddy clear" to remove the previous comments)

Yeah, Jenkins' tests view was one of the inspirations for TravisBuddy :)

Re: TravisBuddy: Adds comments to failed pull requests, tells author what went wrong

#12

Post by neebz »

bluzi wrote: post #11
diggan wrote: post #4

This will get messy quickly if you have a PR that you are adding commits to and have a failure for each commit. This has the same problem as some code coverage solutions, they are spamming the PR with comments that are only important for a few moments, then they are just noise... Speaking about finding test failures quickly though, Jenkins and many others (except ALL the cloud/SaaS solutions?) actually parse test res…

Thanks for the feedback, we're working on methods to prevent TravisBuddy from commenting if the PR is being rapidly updated or if its comments are not relevant for some reason. One idea is that if the PR has a special label TravisBuddy won't comment on it. Another one is to be able to communicate with TravisBuddy using comments, so when you're sick of it you could just comment: "@TravisBuddy stop", and it'll stop imm…

You can do what codecov does; They keep updating the same comment with the latest result.

Re: TravisBuddy: Adds comments to failed pull requests, tells author what went wrong

#14

Post by 7Z7 »

dotsh wrote: post #5

Idea is great but this logo looks like evil douchebag kind of guy with this tagline "Not the bot you deserve, but the one you need" doesn't look great. You definitely need to work on your brand. :)

Came here to comment exactly this. The expression on the face is expressing all the wrong messages about the service.

Re: TravisBuddy: Adds comments to failed pull requests, tells author what went wrong

#15

Post by bostonaholic »

diggan wrote: post #4

This will get messy quickly if you have a PR that you are adding commits to and have a failure for each commit. This has the same problem as some code coverage solutions, they are spamming the PR with comments that are only important for a few moments, then they are just noise... Speaking about finding test failures quickly though, Jenkins and many others (except ALL the cloud/SaaS solutions?) actually parse test res…

CircleCI will parse and collect JUnit test metadata. https://circleci.com/docs/2.0/collect-test-data/

Re: TravisBuddy: Adds comments to failed pull requests, tells author what went wrong

#16

Post by felicianotech »

diggan wrote: post #4

This will get messy quickly if you have a PR that you are adding commits to and have a failure for each commit. This has the same problem as some code coverage solutions, they are spamming the PR with comments that are only important for a few moments, then they are just noise... Speaking about finding test failures quickly though, Jenkins and many others (except ALL the cloud/SaaS solutions?) actually parse test res…

disclaimer: Developer Evangelist at CircleCI

re: parsing test results

CircleCI has been doing this for years. Not only does CircleCI read and store JUnit formatted test metadata but provides a dashboard called "Insights" to show this data overtime.

A Doc on collecting this data can be found here: https://circleci.com/docs/2.0/collect-test-data/

re: Code coverage spam

Thank you! I've often felt this way but never seen anyone else mention this. For many code coverage tools, you can integrate them at the GitHub point, which then gives you that "code coverage spam" or you can integrate it with a CI provider. This can simply fail a build if coverage drops. You can always have a status badge that shows coverage % in the readme as well.

Re: TravisBuddy: Adds comments to failed pull requests, tells author what went wrong

#17

Post by masukomi »

bluzi wrote: post #9
dotsh wrote: post #5

Idea is great but this logo looks like evil douchebag kind of guy with this tagline "Not the bot you deserve, but the one you need" doesn't look great. You definitely need to work on your brand. :)

Thanks for the feedback, the website and any part of the brand is open-source, so if you feel like contributing, you may start a discussion on GitHub or make a PR :)

i'd suggest that he looks like he's just waiting for his chance to fuck up your stuff.

Re: TravisBuddy: Adds comments to failed pull requests, tells author what went wrong

#18

Post by jasonmp85 »

diggan wrote: post #4

This will get messy quickly if you have a PR that you are adding commits to and have a failure for each commit. This has the same problem as some code coverage solutions, they are spamming the PR with comments that are only important for a few moments, then they are just noise... Speaking about finding test failures quickly though, Jenkins and many others (except ALL the cloud/SaaS solutions?) actually parse test res…

> This will get messy quickly if you have a PR that you are adding commits to and have a failure for each commit. This has the same problem as some code coverage solutions, they are spamming the PR with comments that are only important for a few moments, then they are just noise...

IIRC at least Codecov (https://codecov.io) has logic to go in and update the existing comment rather than spamming with new ones. It's nice!

Re: TravisBuddy: Adds comments to failed pull requests, tells author what went wrong

#19

Post by kemayo »

koolba wrote: post #7
dotsh wrote: post #5

Idea is great but this logo looks like evil douchebag kind of guy with this tagline "Not the bot you deserve, but the one you need" doesn't look great. You definitely need to work on your brand. :)

Reminds me of vault boy[1] from Fallout but with a sneaky hat on. https://www.google.com/search?q=vault+boy&tbm=isch

Yeah, but Vault Boy looks cheerful, this guy looks angry.
Post reply on HN