Live data from Hacker News

Show HN: ORY Editor – A rich editor for the browser, built with React and Redux

github.com

51–60 of 107 posts

Re: Show HN: ORY Editor – A rich editor for the browser, built with React and Redux

#52
post #49

Looks pretty good and I didn't see performance issues. From a usability perspective it's simple to use. I would suggest a couple of usability improvements. 1. The right side buttons for edit, layout, etc. have tooltips (that's great) but they should be like on/off buttons e.g. clicking layout once puts the editor in layout mode, clicking it again should bring editor out of layout mode back into preview. 2. In Edit mo…

Hey, thanks for the feedback! I tracked this in the repo, see: https://github.com/ory/editor/issues/389 But I will briefly address these issues here: > 1. The right side buttons for edit, layout, etc. have tooltips (that's great) but they should be like on/off buttons e.g. clicking layout once puts the editor in layout mode, clicking it again should bring editor out of layout mode back into preview. This was actually…

I wanted to walk you through my thought process regarding the right side buttons if you'll indulge me:

1. I clicked the edit button on the right to get in to edit mode. Edit button was highlighted in pink.

2. Saw the buttons on the bottom appear when I clicked a Text section.

3. Bolded some selected text by clicking the B button. B button got highlighted.

4. Clicked the B button again and text went back to normal and the highlight on the B got turned off. (At this point I'm thinking cool buttons are on/off. On state is indicated by a highlight, Off state is indicated as normal style)

5. Performed some other edits then clicked the Edit button the right since it was highlighted and based on my experience with the bottom buttons I expected clicking it again would turn off edit mode.

You don't have to make the change. I just wanted to walk through the thought process of one user.

Thanks for indulging me :)

Re: Show HN: ORY Editor – A rich editor for the browser, built with React and Redux

#55

Built studiously.co website with this. Highly recommend the sites editor! Also using Hydra by the same author for OAuth2. Truly amazing work.

line-height of the title does not look good on my screen http://i.imgur.com/SpxLfUD.jpg (and the white text in front of the blackbord as not very readable either)

Re: Show HN: ORY Editor – A rich editor for the browser, built with React and Redux

#56
post #48
post #20

The high CPU and memory usage was due to a large gif which was included two times. This gif accidentally was 1280p with 20fps and was about 40mb large. For some reason, the resizer did not properly work. Anyways, the gif is now removed. I hope the performance gets much better now. The CPU fans on macbooks going up where probably due to a lack of a dedicated graphics card. This happened to me with my macbook and large…

> First, this is a layout editor first- and foremost. Behind the scenes, React, Redux and slate.js ( http://slatejs.org/ ) is being used. Would it make sense to have a separate repo for layout editor ?

Not sure what you mean? This is already the case, all cells that you can use in the demo are actually plugins. Check this directory: https://github.com/ory/editor/tree/master/packages/plugins/c...

Re: Show HN: ORY Editor – A rich editor for the browser, built with React and Redux

#57
post #33

Earlier quoted context omitted.

We are working on (1), and make it possible to include it in non-react environments. However, there are still some dependencies required (such as react). So yes, this is not perfect at the moment. We're actually not confident with AGPLv3. We might change it to a more permissive license if it prevents people from adopting the technology. Feel free to create an issue on GitHub and we'll discuss it!

Actually, I would be more confident working with a GPL- or AGPL-licensed product, because enhancements are more likely to go back upstream.

That is right. I just know, that many companies flee from GPL licenses (and more so AGPL). They omit any product involving GPL just to be sure not to get any juristic hassles (if rational or not).

Here is the culprit: When no other people invest in enhancements, there is also nothing that can go back upstream.

I like free software very much, but I also don't want to be forced to give things free, that I make. Problem is not the small enhancements I make to an OSS product, but when I link or use some OSS part in a bigger software that I made -- should I always be forced to give everything for free?

Particularly for companies, that is a difficult thing.

To be clear: Of course I would give away my contributions to an OSS product, but I also want to be free, to use OSS in commercial products without need to fear that I loose my own rights.

GPL here is just difficult and when lawyers have to decide about software, anything can happen (as in the patent-wars).

Re: Show HN: ORY Editor – A rich editor for the browser, built with React and Redux

#58
post #33

Looks and works great, but there are 2 limitations I think would prevent it from using it in our stack: 1) It cannot be easily embedded, ie. as a field in a form. Apparently it's meant (UI-wise at least) as a full-screen editor and has lots of dependencies of its own, including React. 2) AGPLv3 license is a killer. Means that any work that links to the library should be opensourced. Despite some people interpreting i…

We are working on (1), and make it possible to include it in non-react environments. However, there are still some dependencies required (such as react). So yes, this is not perfect at the moment. We're actually not confident with AGPLv3. We might change it to a more permissive license if it prevents people from adopting the technology. Feel free to create an issue on GitHub and we'll discuss it!

+1 for keeping the [A]GPL. As I understand it, the CRUD service that backs this would be separate software, which only communicates with this editor through an API, so it would not be affected by ORY's license.

If ORY was a full stack content editing service, rather than just a client with a demo server, then you could still run it unmodified, making it easy to share the source (just link to the official repo). Your other services could either operate on the data being saved by ORY-service, or communicate with it via an HTTP API (whose implementation would be an open component of the ORY-service). But once again, your own software would not fall under the AGPL, because they do not extend, or trivially wrap, ORY.

The only way an AGPL license would force a user of ORY to share their own code, would be if they forked ORY and extended its own codebase, or wrapped it in a trivial adaptor for some framework or platform, e.g. a Wordpress plugin.

IANAL, and the AGPL is a long read, but I do feel like I understood it, and could use this alongside closed-source services.

Re: Show HN: ORY Editor – A rich editor for the browser, built with React and Redux

#59
post #49

Earlier quoted context omitted.

Hey, thanks for the feedback! I tracked this in the repo, see: https://github.com/ory/editor/issues/389 But I will briefly address these issues here: > 1. The right side buttons for edit, layout, etc. have tooltips (that's great) but they should be like on/off buttons e.g. clicking layout once puts the editor in layout mode, clicking it again should bring editor out of layout mode back into preview. This was actually…

I wanted to walk you through my thought process regarding the right side buttons if you'll indulge me: 1. I clicked the edit button on the right to get in to edit mode. Edit button was highlighted in pink. 2. Saw the buttons on the bottom appear when I clicked a Text section. 3. Bolded some selected text by clicking the B button. B button got highlighted. 4. Clicked the B button again and text went back to normal and…

Thank you for your feedback, I added it to the issue as well :)

Re: Show HN: ORY Editor – A rich editor for the browser, built with React and Redux

#60

Earlier quoted context omitted.

Big parts of the toolset I use every day are several decades old; if done correctly, software can be iterated and refined until it's of a very high quality. In my experience, it tends to stand a much greater chance the smaller it is (the best examples I'm thinking of are small unix command-line tools like find, grep).

Yet I resent every time I have to use grep, instead of a tool integrated with my IDE. Certainly those baroque old tools have their detractors too. That they survive so long (like vi and emacs) due to cults, not objective evaluation?

De gustibus non disputandem.

I like grep... It does not do the same thing as Ctrl+F in my editor, but that's fine.

Post reply on HN