Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Show HN: ORY Editor – A rich editor for the browser, built with React and Redux

github.com

Post reply on HN
Print view View original

41–50 of 107 posts

Re: Show HN: ORY Editor – A rich editor for the browser, built with React and Redux

#41

Post by ralmidani »

arekkas wrote: post #33
ojosilva wrote: post #31

Looks and works great, but there are 2 limitations I think would prevent it from using it in our stack: 1) It cannot be easily embedded, ie. as a field in a form. Apparently it's meant (UI-wise at least) as a full-screen editor and has lots of dependencies of its own, including React. 2) AGPLv3 license is a killer. Means that any work that links to the library should be opensourced. Despite some people interpreting i…

We are working on (1), and make it possible to include it in non-react environments. However, there are still some dependencies required (such as react). So yes, this is not perfect at the moment. We're actually not confident with AGPLv3. We might change it to a more permissive license if it prevents people from adopting the technology. Feel free to create an issue on GitHub and we'll discuss it!

Actually, I would be more confident working with a GPL- or AGPL-licensed product, because enhancements are more likely to go back upstream.

Re: Show HN: ORY Editor – A rich editor for the browser, built with React and Redux

#42

Post by jwong_ »

arekkas wrote: post #22
Shank wrote: post #10

The Chrome worker for the demo site accumulated about 600mb of ram. Is the editor really that heavy or is the demo page abnormally heavy?

See this comment: https://news.ycombinator.com/item?id=14417601 - the memory heap should now be around 20 megabytes.

Didn't fix it for me, I just hit it at 11:55 EDT - still getting 500MB on initial load of the editor.

Re: Show HN: ORY Editor – A rich editor for the browser, built with React and Redux

#43

Post by arekkas »

jwong_ wrote: post #42
arekkas wrote: post #22

Earlier quoted context omitted.

See this comment: https://news.ycombinator.com/item?id=14417601 - the memory heap should now be around 20 megabytes.

Didn't fix it for me, I just hit it at 11:55 EDT - still getting 500MB on initial load of the editor.

Could you share the profile file and some additional screenshots in the github repo as an issue? That would help a lot identifying the issue.

Re: Show HN: ORY Editor – A rich editor for the browser, built with React and Redux

#44

Post by canada_dry »

qrohlf wrote: post #23

I'm curious, what does this offer over something like https://draftjs.org/ , https://github.com/ianstormtaylor/slate , or http://prosemirror.net/ which also use normalized JSON (or ImmutableJS) objects for editor state and are backed by much larger and more established companies/communities. We just launched https://ridewithgps.com/ride_reports which is built with draft, and I found it to be very flexible. I'd love t…

Just checked out ridewithgps.com - the implementation is very nice!

It's a clean and simple look where the underlying tech stays out of the way.

Re: Show HN: ORY Editor – A rich editor for the browser, built with React and Redux

#45

Post by palakchokshi »

Looks pretty good and I didn't see performance issues. From a usability perspective it's simple to use. I would suggest a couple of usability improvements.

1. The right side buttons for edit, layout, etc. have tooltips (that's great) but they should be like on/off buttons e.g. clicking layout once puts the editor in layout mode, clicking it again should bring editor out of layout mode back into preview.

2. In Edit mode the buttons on the bottom work like on/off buttons (that's great) those buttons should have tooltips.

3. Editing an image I can't put an alt value or title? How accessible is the content created by the editor?

Keep up the good work. I would use this for quick website/blog setup.

Re: Show HN: ORY Editor – A rich editor for the browser, built with React and Redux

#46

Post by [deleted] »

ojosilva wrote: post #31

Looks and works great, but there are 2 limitations I think would prevent it from using it in our stack: 1) It cannot be easily embedded, ie. as a field in a form. Apparently it's meant (UI-wise at least) as a full-screen editor and has lots of dependencies of its own, including React. 2) AGPLv3 license is a killer. Means that any work that links to the library should be opensourced. Despite some people interpreting i…

[deleted]

Re: Show HN: ORY Editor – A rich editor for the browser, built with React and Redux

#47

Post by hardly_a_mirage »

arekkas wrote: post #43
jwong_ wrote: post #42

Earlier quoted context omitted.

Didn't fix it for me, I just hit it at 11:55 EDT - still getting 500MB on initial load of the editor.

Could you share the profile file and some additional screenshots in the github repo as an issue? That would help a lot identifying the issue.

There is definitely a memory issue. Chrome's task manage shows me your tab at 900MB.

Some other issues:

- create_content.png takes 37 seconds to load - sea_bg.jpg takes 20 seconds to load

Re: Show HN: ORY Editor – A rich editor for the browser, built with React and Redux

#48

Post by rtcoms »

arekkas wrote: post #20

The high CPU and memory usage was due to a large gif which was included two times. This gif accidentally was 1280p with 20fps and was about 40mb large. For some reason, the resizer did not properly work. Anyways, the gif is now removed. I hope the performance gets much better now. The CPU fans on macbooks going up where probably due to a lack of a dedicated graphics card. This happened to me with my macbook and large…

> First, this is a layout editor first- and foremost. Behind the scenes, React, Redux and slate.js ( http://slatejs.org/ ) is being used.

Would it make sense to have a separate repo for layout editor ?

Re: Show HN: ORY Editor – A rich editor for the browser, built with React and Redux

#49

Post by arekkas »

palakchokshi wrote: post #45

Looks pretty good and I didn't see performance issues. From a usability perspective it's simple to use. I would suggest a couple of usability improvements. 1. The right side buttons for edit, layout, etc. have tooltips (that's great) but they should be like on/off buttons e.g. clicking layout once puts the editor in layout mode, clicking it again should bring editor out of layout mode back into preview. 2. In Edit mo…

Hey, thanks for the feedback! I tracked this in the repo, see: https://github.com/ory/editor/issues/389

But I will briefly address these issues here:

> 1. The right side buttons for edit, layout, etc. have tooltips (that's great) but they should be like on/off buttons e.g. clicking layout once puts the editor in layout mode, clicking it again should bring editor out of layout mode back into preview.

This was actually implemented at one point, but we removed it because some people found it confusing. We might add it though.

Also keep in mind that the UI is just a component, you could simply provide your own!

> those buttons should have tooltips.

Great idea!

> 3. Editing an image I can't put an alt value or title? How accessible is the content created by the editor?

Noted, we forgot about that. You can, by the way, write your own image plugin that has an alt tag. But of course we will add this capability to the image plugin. :)

Re: Show HN: ORY Editor – A rich editor for the browser, built with React and Redux

#50

Post by arekkas »

explorigin wrote: post #38
cocktailpeanuts wrote: post #21

Isn't a lot of the "Others don't do this" addressed by Prosemirror? http://prosemirror.net/

One of their requirements is "Based on reusable React Components, it gives developers, authors and designers new ways of working together and creating better and richer experiences more easily." So basically Prosemirror is not buzzword-compatible enough for them. And also, "It is built by a company, reducing the likelihood of abandonment." Because Marijn Haverbeke's reputation for abandoning projects is so prominant…

Nevermind your sarcasm, but if you'd actually checked out both editors in detail, you would have seen the apparent differences. Anyways, you can replace the standard text editor, which is slate, with prosemirror, as all content is just a plugin.
Post reply on HN