Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Add Reactions to Pull Requests, Issues, and Comments

github.com

Post reply on HN
Print view View original

131–140 of 238 posts

Re: Add Reactions to Pull Requests, Issues, and Comments

#131

Post by rlidwka »

jakobegger wrote: post #94
mrharrison wrote: post #51

-1 or the thumbs down reaction, I think is a mistake. They aren't usually that constructive, because most of the time they are used as retaliation against a specific user, instead of constructive criticism. If someone downvotes you, you tend to downvote them. At the least, it should be a privilege to down vote, like SO and HN do. http://stackoverflow.com/help/privileges/vote-down

I think that the -1 button definitely has a place on Github. I use Github a lot for discussing future feature development, and in that context it is really valuable to see how many people think a feature is useful or not. Github isn't primarily a social network. In a professional context it is essential that you can also express disagreement, or that you think something is a bad idea.

In a professional context it is essential that people can express disagreement provided they write exact reasons why they disagree.

You know, "+1" usually has only one meaning:

   - "I agree with whatever you're saying".
"-1" has however two separate meanings:

   - "I disagree with whatever you're saying because I believe that blah-blah-blah (reasons here)"

   - "I disagree with whatever you're saying because fuck you that's why"
And "-1" button doesn't distinguish between those two cases.

Re: Add Reactions to Pull Requests, Issues, and Comments

#132

Post by Pxtl »

mrharrison wrote: post #51

-1 or the thumbs down reaction, I think is a mistake. They aren't usually that constructive, because most of the time they are used as retaliation against a specific user, instead of constructive criticism. If someone downvotes you, you tend to downvote them. At the least, it should be a privilege to down vote, like SO and HN do. http://stackoverflow.com/help/privileges/vote-down

I do find that non-anonymous downvotes go better than anonymous ones, particularly w small communities.

Downvotes are particularly relevant for feature requests that may have substantial negative impact.

I'd actually implement downvotes/upvotes as zero-length comments so that they can be moderated and replied to.

Re: Add Reactions to Pull Requests, Issues, and Comments

#133

Post by cpuguy83 »

gkoberger wrote: post #88
mrharrison wrote: post #51

-1 or the thumbs down reaction, I think is a mistake. They aren't usually that constructive, because most of the time they are used as retaliation against a specific user, instead of constructive criticism. If someone downvotes you, you tend to downvote them. At the least, it should be a privilege to down vote, like SO and HN do. http://stackoverflow.com/help/privileges/vote-down

Agreed 100% for Facebook or even Hacker News, however on GitHub it would be really useful for voting. If you ask "Should we add this feature?", it's hard to understand what favorites mean if you don't have an anchor. Does 10 thumbs-up mean unanimous support, or is it just a small minority? It'd be nice to say "Oh, 10 upvotes... but there's 90 downvotes, so we won't do it." FB and Hacker News are a marketplace of rela…

But the reality is, on larger projects voting doesn't help, won't work, etc.

I guess for the 90% it's ok. It'd be nice to be able to turn off.

Re: Add Reactions to Pull Requests, Issues, and Comments

#134

Post by philliphaydon »

mrharrison wrote: post #51

-1 or the thumbs down reaction, I think is a mistake. They aren't usually that constructive, because most of the time they are used as retaliation against a specific user, instead of constructive criticism. If someone downvotes you, you tend to downvote them. At the least, it should be a privilege to down vote, like SO and HN do. http://stackoverflow.com/help/privileges/vote-down

I shall respectfully disagree. Not wanting down votes is just a way of saying "I'm offended please don't offend me I can't handle down it's it makes me sad"

It's 2016, can we stop worrying about if someone disagrees with you and just accept the fact they wanted to down vote on an issue rather than say nothing or leave a comment.

Re: Add Reactions to Pull Requests, Issues, and Comments

#135

Post by sytse »

mrmondo wrote: post #121

Ah yes, following in the steps of Gitlab which has had this for a while, the thumbs up / down and voting types are useful, everything is a distraction IMO

GitLab had emoji on issues/MR's but not emoji's on comments, we're working on that for 8.7 https://gitlab.com/gitlab-org/gitlab-ce/issues/3655

Re: Add Reactions to Pull Requests, Issues, and Comments

#136

Post by kmm »

toomim wrote: post #110
mrharrison wrote: post #51

-1 or the thumbs down reaction, I think is a mistake. They aren't usually that constructive, because most of the time they are used as retaliation against a specific user, instead of constructive criticism. If someone downvotes you, you tend to downvote them. At the least, it should be a privilege to down vote, like SO and HN do. http://stackoverflow.com/help/privileges/vote-down

You just contradicted yourself. You're giving a -1 on giving -1s.

No they don't, because they're giving an actual argument. They're probably not again disagreement, but against mass disagreement without requiring to substantiate that disagreement.

Re: Add Reactions to Pull Requests, Issues, and Comments

#137

Post by Lazare »

ritchiea wrote: post #93
Lazare wrote: post #60

Earlier quoted context omitted.

> Seriously, GitHub, this is rule one of designing constructive social platforms: you never ever ever implement a downvote button of any kind. It seems ironic you'd post this on a platform that has a downvote button.

It's not ironic. Votes here are used to push the best content to the top. On Github you're not looking for the best content you're collaboratively building software so the tools should be designed to foster collaboration.

> On Github you're not looking for the best content

That seems like an odd assertion. Are you looking for the worst content then, or...? I can see an argument that voting would not highlight the best content, at least in some cases; I don't understand an argument that we aren't looking for the best content.

Conversely, HNews is intended as a constructive platform. Should the tools we use here not be designed to foster collaboration and constructive debate?

Disclaimer: I'm skeptical of voting both here and on Github. But I feel like the argument that the differences between the platforms are major and fundamental needs a lot more fleshing out.

Re: Add Reactions to Pull Requests, Issues, and Comments

#138

Post by Wintamute »

mrharrison wrote: post #51

-1 or the thumbs down reaction, I think is a mistake. They aren't usually that constructive, because most of the time they are used as retaliation against a specific user, instead of constructive criticism. If someone downvotes you, you tend to downvote them. At the least, it should be a privilege to down vote, like SO and HN do. http://stackoverflow.com/help/privileges/vote-down

It depends on how the PR, project or comment thread interprets the -1s. If a vote has been specifically requested then the +1/-1s are super useful. Otherwise they could be safely ignored by maintainers as at most low value ambient info ... well worded constructive criticism will always carry more weight that a -1. Also, this is fundamentally different to SO/HN ... there is no ranking, the up-vote/down-vote ratio has zero effect aside from incrementing a counter - any meaning applied is subjective.

Re: Add Reactions to Pull Requests, Issues, and Comments

#140

Post by dec0dedab0de »

joeyespo wrote: post #113
adnzzzzZ wrote: post #69

Earlier quoted context omitted.

>you never ever ever implement a downvote button of any kind. People who don't agree with something should have a way of expressing their views. Why is it acceptable to have a +1 button but not a -1 button? Why can people agree without giving any reason for their agreement but they can't disagree without giving any reason for their agreement? It's crazy that society works in this way and that people have such an irra…

> People who don't agree with something should have a way of expressing their views What about a comment? Once someone elaborates why they disagree, others can trivially +1 it to show support of a specific disagreement. On the other hand, you can disagree with both the original comment and someone's disagreement, prompting an additional "disagreement" reply. Note that -1's don't carry as much information as you'd thi…

+1s could mean

-Someone agrees with you

-Someone likes you

-Someone is happy or having a good day

-Someone is repaying a favor or maintaining a friendship.

Post reply on HN