April 1st is not there yet. I get the idea, but seriously, emojis...
Add Reactions to Pull Requests, Issues, and Comments
101–110 of 238 posts
Re: Add Reactions to Pull Requests, Issues, and Comments
#102I wonder if this is too featureful? What is the difference between +1, heart, and hooray? Having just a +1 and -1 is unambiguous and probably covers the vast amount of use cases? Perhaps not, but I'd be very interested to know the reasoning between being choosing between "unambiguous" and expressive.
I think I will use them this way: * '+1' to mean I like this feature or this issue affects me. * 'heart' to mean I agree with a proposed solution, or pull request. * 'hooray' when a solution is marked as fixed or a fix version has been posted for the issue. There are no rules though, so we'll see.
Internally at GitHub over the past few weeks I have been using the heart reaction to express appreciation. For example, if someone is very helpful or empathetic I let them know I appreciate it with a heart.
Re: Add Reactions to Pull Requests, Issues, and Comments
#103-1 or the thumbs down reaction, I think is a mistake. They aren't usually that constructive, because most of the time they are used as retaliation against a specific user, instead of constructive criticism. If someone downvotes you, you tend to downvote them. At the least, it should be a privilege to down vote, like SO and HN do. http://stackoverflow.com/help/privileges/vote-down
Agreed 100% for Facebook or even Hacker News, however on GitHub it would be really useful for voting. If you ask "Should we add this feature?", it's hard to understand what favorites mean if you don't have an anchor. Does 10 thumbs-up mean unanimous support, or is it just a small minority? It'd be nice to say "Oh, 10 upvotes... but there's 90 downvotes, so we won't do it." FB and Hacker News are a marketplace of rela…
Commenting should be how people down vote. You should have to explain why it's not a good idea. Then if others agree with you, your comment will get up voted. Just as my comment is a downvote of github's downvote.
Re: Add Reactions to Pull Requests, Issues, and Comments
#104Earlier quoted context omitted.
>That is not the case for disagreement The reason why Github added these votes in the first place is so that people can give a signal of how welcome or not a certain change is to the project. If you only provide the signal for agreement but remove the signaling for disagreement and make it costly, then you'll get more people voting one way than the other. If it costs more to disagree then you're already rigging the g…
Sure, but that is already the case - posting a :+1: costs much less effort than writing a counter-argument (and is already widely socially accepted, spammy-ness aside). The addition of an upvote button doesn't change this. That's not to say that I wouldn't like that bias resolved, but it's a bias that exists precisely because of the difference between 'agreement' and 'disagreement' that I described, and I'm not sure…
How does enhancing the bias solve the issue? By not adding the downvote button this bias is enhanced. By adding the downvote button this bias is diminished. It's not a perfect solution but it's better than doing nothing.
Re: Add Reactions to Pull Requests, Issues, and Comments
#105Um. What does :+1: mean when applied to an issue? "I like this bug"?!
“I have the same problem” or “I’m able to reproduce” maybe?
Re: Add Reactions to Pull Requests, Issues, and Comments
#106April 1st is not there yet. I get the idea, but seriously, emojis...
Yeah I panicked and checked my calendar
Re: Add Reactions to Pull Requests, Issues, and Comments
#107-1 or the thumbs down reaction, I think is a mistake. They aren't usually that constructive, because most of the time they are used as retaliation against a specific user, instead of constructive criticism. If someone downvotes you, you tend to downvote them. At the least, it should be a privilege to down vote, like SO and HN do. http://stackoverflow.com/help/privileges/vote-down
Agreed 100% for Facebook or even Hacker News, however on GitHub it would be really useful for voting. If you ask "Should we add this feature?", it's hard to understand what favorites mean if you don't have an anchor. Does 10 thumbs-up mean unanimous support, or is it just a small minority? It'd be nice to say "Oh, 10 upvotes... but there's 90 downvotes, so we won't do it." FB and Hacker News are a marketplace of rela…
Sounds like a pre-optimization. You can get the same level of information with two comments and vote exclusively with +1's, but without the general negative aspects of what's mentioned above.
Re: Add Reactions to Pull Requests, Issues, and Comments
#108I like the idea of adding more expressiveness, pictorially capturing sometimes fleeting moments of emotion or accurately representing an emotional state that can occur. These are the following reactions: 1. +1 2. -1 3. smile 4. thinking_face 5. heart 6. tada Do they capture the necessary expressiveness for the context? Facebook's reactions cover more emotions, but FB is trying to support reaction to anything that can…
Considering that it's Github, how about things relevant to software engineering, like: agree, disagree, support, insightful, obsolete, misleading. I can't imagine it being helpful to know that someone felt "heart" about an issue comment.
[deleted]
Re: Add Reactions to Pull Requests, Issues, and Comments
#109Can you downvote replies in threads that are locked? Can collaborators delete these reactions like we would with comments?
> Have feedback on this post? Let know on Twitter.
Not everyone uses Twitter. It would be awesome to give feedback using the one account I'm guaranteed to have: a GitHub account. Otherwise I have to ask my question on HN...
Re: Add Reactions to Pull Requests, Issues, and Comments
#110-1 or the thumbs down reaction, I think is a mistake. They aren't usually that constructive, because most of the time they are used as retaliation against a specific user, instead of constructive criticism. If someone downvotes you, you tend to downvote them. At the least, it should be a privilege to down vote, like SO and HN do. http://stackoverflow.com/help/privileges/vote-down
You just contradicted yourself. You're giving a -1 on giving -1s.