Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Show HN: GitPlex – A new Git repo management server with code review

pmease.com

Post reply on HN
Print view View original

91–98 of 98 posts

Re: Show HN: GitPlex – A new Git repo management server with code review

#91

Post by notheguyouthink »

houzi wrote: post #88
notheguyouthink wrote: post #77

Earlier quoted context omitted.

I'm still seeking a good way to do reviews/merges with Vim though. I use a Macpro Ret 13" and it nicely fits two ~80char windows. However, three windows as vim normally does for merge conflicts/etc is too much for the 13" screen, it ends up cluttered and cramped. Anyone have any recommendations for how to efficiently handle conflicts/reviews via vim with a small screen?

I am surprised that your highres screen doesn't handle three buffers side by side. My 13" 720p laptop also has trouble with three buffers, but I was hoping that would be mitigated the day I got a highres 13" laptop. Anyways, you can try a narrow width font: I love M+ 1mn, though the narrow width causes problems when it doesn't have a certain unicode point defined and falls back to a full width font..

Yea, it's likely a font issue. This[1] is what my font looks like, which is quite readable to me but i can't get much smaller (for me personally). Each pane fits ~85 chars (not including the vim sidebars/etc), so it's quite perfect for two panels.

Note that OSX by default has some type of feature that reduces the realestate you have available.. don't ask me to explain it, i haven't really used it much.

Basically, with the Retina monitors, the resolution is actually too high for a lot of scenarios. You end up with tiny fonts, tiny icons, etc. So they somehow sample/zoom the sizes so that you get both really crisp renders but with very few real pixels on screen.

This may be what is causing you to be surprised that i am still having issues with a high resolution Retina screen. But, turning it off would be effectively the same thing as just turning my iTerm2 fontsize to ~8-10 or something tiny, allowing me to fit three panes.

[1]: http://imgur.com/MBvoEJd

Re: Show HN: GitPlex – A new Git repo management server with code review

#92

Post by LeanderK »

robinshen wrote: post #85
LeanderK wrote: post #84

how do you parse the java-code? In front- or backend? If frontend what libraries do you use or did you create everything from scratch?

We do that in backend with a hand written, simple parser just to pick up information we needed. And it is fast (can index all JDK8 source symbols in seconds).

i am currently working on a side project [1] to search for java-method usages and also parse java-code on the backend, but it's not as fast as i would like it to be. I did some very obvious performance improvement, but i suspect that for the most time i am waiting to download the sources/to complete the search request. There might also be some serious performance issues (it started as a hackathon project, so...). I hope to find time this weekend to do some benchmarking. I would guess you download the whole git repo at once and then do the parsing and not lazily per file? I also experience high memory usage, it might be the library that i am using.

[1] https://exemplator.xyz

Re: Show HN: GitPlex – A new Git repo management server with code review

#93

Post by ibizaman »

notheguyouthink wrote: post #77
skrebbel wrote: post #53

Folks, this is why you want to do code reviews inside your editors / IDEs. I like this project, but really what they did is build a read-only version of an IDE from the ground up. You already have one and you know it inside out. I've found, as the OP did, that the GitHub/Lab/Bucket code review UIs strongly encourage nitpicking over code style and strongly discourage true insightful reviews on a design and architectur…

I'm still seeking a good way to do reviews/merges with Vim though. I use a Macpro Ret 13" and it nicely fits two ~80char windows. However, three windows as vim normally does for merge conflicts/etc is too much for the 13" screen, it ends up cluttered and cramped. Anyone have any recommendations for how to efficiently handle conflicts/reviews via vim with a small screen?

Well I simply don't use the three way view. I find it easier to read when only having one window with the file having the >> lines. As an aside, I also use the fugitive plugin and the promiscuous one which makes the whole process easier.

Re: Show HN: GitPlex – A new Git repo management server with code review

#94

Post by 91bananas »

andruby wrote: post #86
91bananas wrote: post #73

Earlier quoted context omitted.

A really good editor will allow you to do this without leaving. Pycharm/jetbrains handle this the best I have ever seen. Atom is almost there with a couple of the packages I have found

Which Atom packages did you find to help you with this?

git-control@0.8.2 git-log@0.4.1 git-plus@5.22.0 git-time-machine@1.5.3

are the main ones, git-time-machine is probably my favorite package period in the Atom ecosystem. As it shows what is possible with completely user created UI.

Shameless plug for a package I wrote too https://atom.io/packages/atom-git-revert which also helps on the daily!

Re: Show HN: GitPlex – A new Git repo management server with code review

#95

Post by guomanmin »

Participate in Atlassian Research

My name is Angela and I do research for Bitbucket. I’m kicking off a round of discussions with people who use Git tools. Ideally, I’d like to talk to people that sit on a team of 3 or more. If this is you, I would love to talk to you about your experience with Git tools, or just some of the pain points that are keeping you up at night when doing your jobs.



We’ll just need 30 mins of your time, and as a token of my thanks to those that participate, I’d like to offer a US$50 Amazon gift voucher. 



If you’re interested, just shoot me an email with your availability over the next few weeks and we can set up a time to chat for 30 minutes. Please also include your timezone so we can schedule a suitable time (as I’m located in San Francisco). Hope to talk to you soon! 



Cheers, 
Angela Guo aguo@atlassian.com

Re: Show HN: GitPlex – A new Git repo management server with code review

#97

Post by guomanmin »

Participate in Atlassian Research

My name is Angela and I do research for Bitbucket. I’m kicking off a round of discussions with people who use Git tools. Ideally, I’d like to talk to people that sit on a team of 3 or more. If this is you, I would love to talk to you about your experience with Git tools, or just some of the pain points that are keeping you up at night when doing your jobs.



We’ll just need 30 mins of your time, and as a token of my thanks to those that participate, I’d like to offer a US$50 Amazon gift voucher. 



If you’re interested, just shoot me an email with your availability over the next few weeks and we can set up a time to chat for 30 minutes. Please also include your timezone so we can schedule a suitable time (as I’m located in San Francisco). Hope to talk to you soon!

Cheers, 
 Angela Guo aguo@atlassian.com

Re: Show HN: GitPlex – A new Git repo management server with code review

#98

Post by dang »

guomanmin wrote: post #97

Participate in Atlassian Research My name is Angela and I do research for Bitbucket. I’m kicking off a round of discussions with people who use Git tools. Ideally, I’d like to talk to people that sit on a team of 3 or more. If this is you, I would love to talk to you about your experience with Git tools, or just some of the pain points that are keeping you up at night when doing your jobs. We’ll just need 30 mins of…

You posted 10 of these comments and provoked users into emailing us to complain about spam. Those users are right, because HN isn't the place for this kind of thing, and certainly not repeatedly in multiple threads. We haven't banned your account because I'm sure you were acting in good faith, but please stop.
Post reply on HN