Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Show HN: GitPlex – A new Git repo management server with code review

pmease.com

Post reply on HN
Print view View original

81–90 of 98 posts

Re: Show HN: GitPlex – A new Git repo management server with code review

#81

Post by leonya2 »

theptip wrote: post #80
sarnowski wrote: post #3

Earlier quoted context omitted.

Sounds like you described https://www.jetbrains.com/upsource/ (I am not affiliated with Jetbrains in any way)

I've seen a couple brief comments about Upsource in this thread. Can anyone give a deeper dive on their experiences? I tried it very briefly but didn't have time to configure integration with my IDE, just played in the web browser. I suspect that means I didn't try the best feature. Pros/cons of this tool?

Upsource team member here. Since Upsource indexes your code just like any JetBrains IDE does, it gives you code navigation, inspections, etc. in the browser, which means its "best features" don't require using it as an IDE plugin.

Pros: I'm obviously biased so I won't go into those.

Cons: it's not a lightweight tool that's happy with 1 gig of memory. Configuring and waiting for code indexes takes a bit of time, especially if you're trying it out on large legacy codebases. It also won't manage a Git repository for you.

Re: Show HN: GitPlex – A new Git repo management server with code review

#82

Post by jeblair »

deng wrote: post #76
mugsie wrote: post #71

Earlier quoted context omitted.

What do you see as the major problems with gerrit?

It's simply horrible to work with. It's a mystery to me how people actually review code through that cumbersome interface. Tracking a larger patch series is just painful, and I usually had to use other tools for doing the actual work. To me, Gerrit is not a tool for doing reviews, but more like a bureaucratic behemoth from project management where you have to click the right buttons and fill out the necessary forms,…

Gerrit's current web UI is awkward, but the backend service really has the fundamentals down, and it has a first-class REST API. I used that to create Gertty which is a console UI for Gerrit that makes reading and reviewing code (in a terminal!) easy and fast.

Re: Show HN: GitPlex – A new Git repo management server with code review

#83

Post by regularjack »

irfansharif wrote: post #79

i've personally found using Reviewable[0] to be a delight, automatically plugs in your github workflow in that it modifies the comments in your original PR with comments left on reviewable itself. one killer feature is their batch comment mode, the ability to draft up a whole set of comments and publish in one go all the while tracking the resolution/conversation of each point brought up. an example of this is here[1…

You can batch comments in GitHub.com too. This feature has been available for a few months now https://help.github.com/articles/about-pull-request-reviews/

Re: Show HN: GitPlex – A new Git repo management server with code review

#85

Post by robinshen »

LeanderK wrote: post #84

how do you parse the java-code? In front- or backend? If frontend what libraries do you use or did you create everything from scratch?

We do that in backend with a hand written, simple parser just to pick up information we needed. And it is fast (can index all JDK8 source symbols in seconds).

Re: Show HN: GitPlex – A new Git repo management server with code review

#86

Post by andruby »

91bananas wrote: post #73
robinshen wrote: post #62

Earlier quoted context omitted.

Thanks for the ideas. While I agree with you that desktop IDE is a good place for design and architecture level reviews, having a lightweight web "IDE" will be beneficial as it does not require you to switch your local workspace to particular revisions for review. Also I often find myself need to copy code from some old revisions, in that case, I just visit our web "IDE", find desired revisions with revision search h…

A really good editor will allow you to do this without leaving. Pycharm/jetbrains handle this the best I have ever seen. Atom is almost there with a couple of the packages I have found

Which Atom packages did you find to help you with this?

Re: Show HN: GitPlex – A new Git repo management server with code review

#87

Post by lima »

deng wrote: post #68
lima wrote: post #67

Earlier quoted context omitted.

Phabricator handles it well thanks to its Arcanist CLI tool.

As I understand it, Phabricator largely avoids the problem because it is primarily patch-based and not branch-based? How would arcanist handle a force-pushed branch without simply starting a new review process?

Exactly, it sidesteps the problem by decoupling branches and code review. A review request is just like a diff in a mailbox. It'd just update the diff.

It's really close to the Linux kernel development model and it scales very well.

Re: Show HN: GitPlex – A new Git repo management server with code review

#88

Post by houzi »

notheguyouthink wrote: post #77
skrebbel wrote: post #53

Folks, this is why you want to do code reviews inside your editors / IDEs. I like this project, but really what they did is build a read-only version of an IDE from the ground up. You already have one and you know it inside out. I've found, as the OP did, that the GitHub/Lab/Bucket code review UIs strongly encourage nitpicking over code style and strongly discourage true insightful reviews on a design and architectur…

I'm still seeking a good way to do reviews/merges with Vim though. I use a Macpro Ret 13" and it nicely fits two ~80char windows. However, three windows as vim normally does for merge conflicts/etc is too much for the 13" screen, it ends up cluttered and cramped. Anyone have any recommendations for how to efficiently handle conflicts/reviews via vim with a small screen?

I am surprised that your highres screen doesn't handle three buffers side by side. My 13" 720p laptop also has trouble with three buffers, but I was hoping that would be mitigated the day I got a highres 13" laptop.

Anyways, you can try a narrow width font: I love M+ 1mn, though the narrow width causes problems when it doesn't have a certain unicode point defined and falls back to a full width font..

Re: Show HN: GitPlex – A new Git repo management server with code review

#89

Post by seanpackham »

TeMPOraL wrote: post #2

I don't care much about code review , but it's a close enough attractor to the space of code reading that it seems to be draining attention. So let me hijack this topic and post a request for product (I'd write it myself, but priorities... adult life sucks hard). -- I dream of a tool that facilitates code reading and exploration . It has some similar features with code review tools, namely: - integration with version…

That is a great list of features! I will create feature requests for them in GitLab (I work at GitLab).

I'm curious what you think of the single file history in current systems, are they OK but just missing annotations?

Re: Show HN: GitPlex – A new Git repo management server with code review

#90

Post by seanpackham »

deng wrote: post #7

This looks impressive, especially how they seem to handle rebases/squashes with force push, which is a problem that pretty much all other repo managers simply ignore (except for Gerrit, but that one has other problems...).

At GitLab we also think it is a great feature to bring formally into the software development workflow https://gitlab.com/gitlab-org/gitlab-ee/issues/896
Post reply on HN