Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Microsoft team submits Redis patch to enable Windows support

github.com

Post reply on HN
Print view View original

51–60 of 103 posts

Re: Microsoft team submits Redis patch to enable Windows support

#51

Post by antirez »

yread wrote: post #28

Wow, I'm kind of surprised by the amount of snark ("eww it's 140k lines", "mini git tutorial", "patch file instead of pull request"). It seems it's so big because it contains the libuv. The instructions to compile on Windows don't seem trivial at all and if I cared enough to try this I would appreciate that they wrote it step-by-step. The guys at MS just sat down and made it work while antirez was throwing out sugges…

The patch provided does not handle persistence correctly (saving blocks), does not make tests passing. The "libuv" part was the trivial part, already solved by the community, see the unofficial win32/win64 port that fixed it natively, with less code.

So nice to see Microsoft contributing code to Redis, but this is not a production ready port and is practically equivalent to what we already had made by the community.

Also, what is the point on having a production quality Redis server on Windows? That it will slow down the Redis POSIX development if we merge the two projects, the WIN32 API is different, there is a lot of care needed to maintain a port, but what is the real gain? Even services based on Windows like Stack Overflow had no issues running their Linux boxes to use Redis.

I've the bad habit of doing the interest of the Redis community, so once I saw there was a reasonable port of Redis for win32 (that is, enough to code under Windows and test stuff, no production ready) I avoided additional efforts in this regard to provide more value in the "real" Redis, the one running where 99.99% of people need it to run well, under POSIX environments.

EDIT: I was not clear in this post about what I'll do. I'll not merge the patch, but I'll see with interest the creation of a "redis-win32" project that has a different repository, different issues page, and so forth, and is not officially supported by me. But I'll be happy to provide a page in the redis.io site about it, to link at the project, to collaborate with the developers, and so forth.

Re: Microsoft team submits Redis patch to enable Windows support

#52

Post by [deleted] »

rbanffy wrote: post #49
chimeracoder wrote: post #48

Earlier quoted context omitted.

They might be doing other things you don't like, but at least give credit where credit is due. Submitting code upstream to Redis is completely independent of their patent decisions regarding Android. I'm not a fan of their overall stance with respect to FOSS/Linux/Android, and they may be earning the snark there, but not in this case. These discussions become a lot more valuable when we stop characterizing any organi…

> give credit where credit is due Sure. Just don't forget they profit from Windows sales and, thus, will do anything to justify the deployment of a Windows server instead of a Linux one. Including contributing to a Unix-native product. If, in the end, Redis' codebase becomes cluttered and performance and maintenance suffer, we all lose. I mean, all of us except Microsoft, who wins both by us losing and from gaining s…

[deleted]

Re: Microsoft team submits Redis patch to enable Windows support

#53

Post by Splines »

wisty wrote: post #22
diminish wrote: post #8

Earlier quoted context omitted.

can someone please submit a patch to MS to add git pull support to team foundation server or visual sourcesafe (or what are MS guys using these days as version control?)

I think they use Perforce (or at least, a heavily patched version they can "Source Depot"). That might have changed since Team Foundation was brought out. I don't think they ever used visual sourcesafe.

I'm in Office and we currently use Source Depot, which is a modified version of Perforce. We have so many tools that interoperate with it (and everyone knows how it works) that I don't see us moving away from SD anytime soon.

We use Team Foundation for a few other things related to project management (personally, I'm not a fan), but not for source control.

Re: Microsoft team submits Redis patch to enable Windows support

#54

Post by Joakal »

Ecio78 wrote: post #50
beagle3 wrote: post #46

Earlier quoted context omitted.

> Microsoft has made a good gesture When on the other hand they are poisoning the Android/Linux ecosystem with FUD, patent extortion and the like. While I would prefer the discussion to stay civil and technical, Microsoft is consistently earning every snark they are receiving, and then some.

I dont want to defend Microsoft, but i think that if we dig deep enough we found bad "habits" in every big society: what about Google[1] or Apple suing everybody from Samsung [2] to Luxembourgish restourants[3]? [1] http://www.theverge.com/2011/05/12/google-android-skyhook-la... [2] http://www.businessweek.com/news/2011-08-02/apple-lawsuit-pu... [3] http://news.ycombinator.com/item?id=3190944

Microsoft has a history of screwing over with their 'help': https://en.wikipedia.org/wiki/Embrace,_extend_and_extinguish

I believe he's referring to this with scaring people: https://en.wikipedia.org/wiki/Fear,_uncertainty_and_doubt#Mi...

More: https://en.wikipedia.org/wiki/Criticism_of_Microsoft

Re: Microsoft team submits Redis patch to enable Windows support

#55

Post by gresrun »

kogir wrote: post #23
adrianpike wrote: post #11

Can somebody more familiar with the Windows environment explain why prn.h is an "invalid file name"? edit:// thanks all! :)

It's reserved for compatibility: "Do not use the following reserved device names for the name of a file: CON, PRN, AUX, NUL, COM1, COM2, COM3, COM4, COM5, COM6, COM7, COM8, COM9, LPT1, LPT2, LPT3, LPT4, LPT5, LPT6, LPT7, LPT8, and LPT9. Also avoid these names followed immediately by an extension; for example, NUL.txt is not recommended."[1] [1] http://msdn.microsoft.com/en-us/library/windows/desktop/aa36...

We're encountered this issue when dealing with ETF tickers. We use Linux but a 3rd-party redistributor was on Windows; the reports we created had file names in the form .pdf and, what would you know, PRN.pdf caused all sorts of trouble for them...

Re: Microsoft team submits Redis patch to enable Windows support

#56

Post by nknight »

Ecio78 wrote: post #50
beagle3 wrote: post #46

Earlier quoted context omitted.

> Microsoft has made a good gesture When on the other hand they are poisoning the Android/Linux ecosystem with FUD, patent extortion and the like. While I would prefer the discussion to stay civil and technical, Microsoft is consistently earning every snark they are receiving, and then some.

I dont want to defend Microsoft, but i think that if we dig deep enough we found bad "habits" in every big society: what about Google[1] or Apple suing everybody from Samsung [2] to Luxembourgish restourants[3]? [1] http://www.theverge.com/2011/05/12/google-android-skyhook-la... [2] http://www.businessweek.com/news/2011-08-02/apple-lawsuit-pu... [3] http://news.ycombinator.com/item?id=3190944

[1] is a link to a story about Google being sued by Skyhook, not Google suing anybody.

Re: Microsoft team submits Redis patch to enable Windows support

#57

Post by beagle3 »

chimeracoder wrote: post #48
beagle3 wrote: post #46

Earlier quoted context omitted.

> Microsoft has made a good gesture When on the other hand they are poisoning the Android/Linux ecosystem with FUD, patent extortion and the like. While I would prefer the discussion to stay civil and technical, Microsoft is consistently earning every snark they are receiving, and then some.

They might be doing other things you don't like, but at least give credit where credit is due. Submitting code upstream to Redis is completely independent of their patent decisions regarding Android. I'm not a fan of their overall stance with respect to FOSS/Linux/Android, and they may be earning the snark there, but not in this case. These discussions become a lot more valuable when we stop characterizing any organi…

> These discussions become a lot more valuable when we stop characterizing any organization, especially one as complex as a large corporation, as universally 'good' or 'bad'.

That is true. But it is also foolish to ignore over 20 years of Microsoft's strategy, the mostly successful "embrace, extend and extinguish".

This patch is purely out of self interest: people might install a unix server if they want Redis and can't have it on Windows. There is no "good will" (and no "bad will").

If it harms performance on linux? Well, they are likely not to care at this point, or at least one second after the patch is accepted.

Microsoft has a history of co-operating with the rest of the world only when they are at a disadvantage, and ignoring standards and conventions when they have the advantage.

Excuse me if I'm not enthusiastic about a patch they send to a project I like.

Re: Microsoft team submits Redis patch to enable Windows support

#58

Post by mythz »

rbanffy wrote: post #49
chimeracoder wrote: post #48

Earlier quoted context omitted.

They might be doing other things you don't like, but at least give credit where credit is due. Submitting code upstream to Redis is completely independent of their patent decisions regarding Android. I'm not a fan of their overall stance with respect to FOSS/Linux/Android, and they may be earning the snark there, but not in this case. These discussions become a lot more valuable when we stop characterizing any organi…

> give credit where credit is due Sure. Just don't forget they profit from Windows sales and, thus, will do anything to justify the deployment of a Windows server instead of a Linux one. Including contributing to a Unix-native product. If, in the end, Redis' codebase becomes cluttered and performance and maintenance suffer, we all lose. I mean, all of us except Microsoft, who wins both by us losing and from gaining s…

Of course they're selfishly motivated - everyone is. The point is this time Redis/NoSQL stands to benefit as well.

Re: Microsoft team submits Redis patch to enable Windows support

#59

Post by stock_toaster »

briancurtin wrote: post #26
splitbrain wrote: post #4

A patch file in a gist instead of a pull request? sigh

It's really no wonder why people don't contribute to open source when this is the first response.

Yeah, I suppose they could have printed it out and mailed it in.

Re: Microsoft team submits Redis patch to enable Windows support

#60

Post by kenjackson »

nknight wrote: post #56
Ecio78 wrote: post #50

Earlier quoted context omitted.

I dont want to defend Microsoft, but i think that if we dig deep enough we found bad "habits" in every big society: what about Google[1] or Apple suing everybody from Samsung [2] to Luxembourgish restourants[3]? [1] http://www.theverge.com/2011/05/12/google-android-skyhook-la... [2] http://www.businessweek.com/news/2011-08-02/apple-lawsuit-pu... [3] http://news.ycombinator.com/item?id=3190944

[1] is a link to a story about Google being sued by Skyhook, not Google suing anybody.

Yes, but look at why Skyhook is suing them. We live in a weird bubble where if a company gets sued then they are the victim. No one even fathoms, when it comes to Google at least, that maybe they did something to deserve being sued.
Post reply on HN