Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Microsoft team submits Redis patch to enable Windows support

github.com

Post reply on HN
Print view View original

41–50 of 103 posts

Re: Microsoft team submits Redis patch to enable Windows support

#41

Post by spicyj »

js2 wrote: post #21

[Edited for tone which I guess is the reason for the down votes. I appreciate the quick response below.] Most of this patch is adding libuv, which is included in its entirety due to "the version included in the patch is different than the one available on github, some changes have been added to the code". There is also a lot of cleanup. Also a small nit, in the patch instructions: git checkout 3fac86ff1d git checkout…

Did most of what you suggested: https://github.com/antirez/redis/issues/238#issuecomment-307....

Re: Microsoft team submits Redis patch to enable Windows support

#43

Post by Argorak »

briancurtin wrote: post #26
splitbrain wrote: post #4

A patch file in a gist instead of a pull request? sigh

It's really no wonder why people don't contribute to open source when this is the first response.

Sorry, its not just people - they are the employees of the biggest and in some respects best software company in the world. This is a standard that they should live up to.

Re: Microsoft team submits Redis patch to enable Windows support

#44

Post by tptacek »

darklajid wrote: post #38
tptacek wrote: post #30

Earlier quoted context omitted.

I'd be surprised if he accepted a patch that added a dep; Salvatore seems allergic to deps (something I like about Redis).

(on a mobile and fat-fingered a downvote, sorry) I wouldn't expect anyone to accept the patch in this state, but I hope that the "who cares about Windows" attitude dies and a dialog to get proper support into redis is started. It's a shame that we're using an unofficial version on that platform right now.

You don't have to have a "who cares about Windows?" attitude to write programs that don't work on Windows; all you have to have is a "want to make the best use of Unix" attitude.

Re: Microsoft team submits Redis patch to enable Windows support

#45

Post by manojlds »

yread wrote: post #28

Wow, I'm kind of surprised by the amount of snark ("eww it's 140k lines", "mini git tutorial", "patch file instead of pull request"). It seems it's so big because it contains the libuv. The instructions to compile on Windows don't seem trivial at all and if I cared enough to try this I would appreciate that they wrote it step-by-step. The guys at MS just sat down and made it work while antirez was throwing out sugges…

I mentioned the mini git tutorial

I am a MS fan and I use msysgit on Windows.

My point being, git now has good enough implementation on Windows and the team should have taken the time to learn it, as in this context, it doesn't look good that they are ignorant of git.

Re: Microsoft team submits Redis patch to enable Windows support

#46

Post by beagle3 »

mythz wrote: post #40

The snark on this thread is concerning, Microsoft has made a good gesture in trying improve the Redis story on Windows and IMO it's something we all should be encouraging as it can only serve to improve the Redis ecosystem. Historically Microsoft hasn't been too fond of NoSQL but positive steps like this validates Redis in the eyes of Windows devs which has the potential to attract new devs to the world of Redis and…

> Microsoft has made a good gesture

When on the other hand they are poisoning the Android/Linux ecosystem with FUD, patent extortion and the like. While I would prefer the discussion to stay civil and technical, Microsoft is consistently earning every snark they are receiving, and then some.

Re: Microsoft team submits Redis patch to enable Windows support

#47

Post by js2 »

spicyj wrote: post #41
js2 wrote: post #21

[Edited for tone which I guess is the reason for the down votes. I appreciate the quick response below.] Most of this patch is adding libuv, which is included in its entirety due to "the version included in the patch is different than the one available on github, some changes have been added to the code". There is also a lot of cleanup. Also a small nit, in the patch instructions: git checkout 3fac86ff1d git checkout…

Did most of what you suggested: https://github.com/antirez/redis/issues/238#issuecomment-307... .

Excellent. Thank you, and I apologize for the harshness of my original comment. Was honestly just trying to be helpful.

Re: Microsoft team submits Redis patch to enable Windows support

#48

Post by chimeracoder »

beagle3 wrote: post #46
mythz wrote: post #40

The snark on this thread is concerning, Microsoft has made a good gesture in trying improve the Redis story on Windows and IMO it's something we all should be encouraging as it can only serve to improve the Redis ecosystem. Historically Microsoft hasn't been too fond of NoSQL but positive steps like this validates Redis in the eyes of Windows devs which has the potential to attract new devs to the world of Redis and…

> Microsoft has made a good gesture When on the other hand they are poisoning the Android/Linux ecosystem with FUD, patent extortion and the like. While I would prefer the discussion to stay civil and technical, Microsoft is consistently earning every snark they are receiving, and then some.

They might be doing other things you don't like, but at least give credit where credit is due.

Submitting code upstream to Redis is completely independent of their patent decisions regarding Android. I'm not a fan of their overall stance with respect to FOSS/Linux/Android, and they may be earning the snark there, but not in this case.

These discussions become a lot more valuable when we stop characterizing any organization, especially one as complex as a large corporation, as universally 'good' or 'bad'.

Re: Microsoft team submits Redis patch to enable Windows support

#49

Post by rbanffy »

chimeracoder wrote: post #48
beagle3 wrote: post #46

Earlier quoted context omitted.

> Microsoft has made a good gesture When on the other hand they are poisoning the Android/Linux ecosystem with FUD, patent extortion and the like. While I would prefer the discussion to stay civil and technical, Microsoft is consistently earning every snark they are receiving, and then some.

They might be doing other things you don't like, but at least give credit where credit is due. Submitting code upstream to Redis is completely independent of their patent decisions regarding Android. I'm not a fan of their overall stance with respect to FOSS/Linux/Android, and they may be earning the snark there, but not in this case. These discussions become a lot more valuable when we stop characterizing any organi…

> give credit where credit is due

Sure. Just don't forget they profit from Windows sales and, thus, will do anything to justify the deployment of a Windows server instead of a Linux one. Including contributing to a Unix-native product. If, in the end, Redis' codebase becomes cluttered and performance and maintenance suffer, we all lose. I mean, all of us except Microsoft, who wins both by us losing and from gaining space for their own future offerings in this segment.

There is no good or bad. It's self interest. When their self-interest coincides with the society's, I'm for them. OTOH, it's been a long time since it last did. It certainly never happened after the mid 90's.

Re: Microsoft team submits Redis patch to enable Windows support

#50

Post by Ecio78 »

beagle3 wrote: post #46
mythz wrote: post #40

The snark on this thread is concerning, Microsoft has made a good gesture in trying improve the Redis story on Windows and IMO it's something we all should be encouraging as it can only serve to improve the Redis ecosystem. Historically Microsoft hasn't been too fond of NoSQL but positive steps like this validates Redis in the eyes of Windows devs which has the potential to attract new devs to the world of Redis and…

> Microsoft has made a good gesture When on the other hand they are poisoning the Android/Linux ecosystem with FUD, patent extortion and the like. While I would prefer the discussion to stay civil and technical, Microsoft is consistently earning every snark they are receiving, and then some.

I dont want to defend Microsoft, but i think that if we dig deep enough we found bad "habits" in every big society: what about Google[1] or Apple suing everybody from Samsung [2] to Luxembourgish restourants[3]?

[1] http://www.theverge.com/2011/05/12/google-android-skyhook-la... [2] http://www.businessweek.com/news/2011-08-02/apple-lawsuit-pu... [3] http://news.ycombinator.com/item?id=3190944

Post reply on HN