Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Add Reactions to Pull Requests, Issues, and Comments

github.com

Post reply on HN
Print view View original

231–238 of 238 posts

Re: Add Reactions to Pull Requests, Issues, and Comments

#231

Post by [deleted] »

bendykstra wrote: post #222
acjohnson55 wrote: post #171

Earlier quoted context omitted.

I don't think HN is monocultural, at least to a pathological extent. There's quite a bit of debate here. The overwhelming majority of grayed out comments are baseless, off-topic, or unnecessarily inflammatory, from my perspective. I think that's because there's a norm to agree with an upvote, disagree with a non-vote, and reserve downvotes for unproductive commentary. People seem to upvote unfairly gray comments rega…

I don't think it is either, but if we began downvoting for mere disagreement as the person that I responded to advocated, then I think it would.

[deleted]

Re: Add Reactions to Pull Requests, Issues, and Comments

#232

Post by CM30 »

bradgessler wrote: post #144
mrharrison wrote: post #51

-1 or the thumbs down reaction, I think is a mistake. They aren't usually that constructive, because most of the time they are used as retaliation against a specific user, instead of constructive criticism. If someone downvotes you, you tend to downvote them. At the least, it should be a privilege to down vote, like SO and HN do. http://stackoverflow.com/help/privileges/vote-down

Combining +1 and -1 is a mistake. It would be useful to see thumbs-up separate from thumbs-down to get a gut feel for contention.

Yeah, that's definitely the best way of handling a rating system. The one I use on my sites (the XenForo mod one) counts likes, dislikes, agrees, disagrees and all the other ratings individually and displays that count under every post.

GitHub should have done the same here.

Re: Add Reactions to Pull Requests, Issues, and Comments

#233

Post by nv-vn »

mrharrison wrote: post #51

-1 or the thumbs down reaction, I think is a mistake. They aren't usually that constructive, because most of the time they are used as retaliation against a specific user, instead of constructive criticism. If someone downvotes you, you tend to downvote them. At the least, it should be a privilege to down vote, like SO and HN do. http://stackoverflow.com/help/privileges/vote-down

Still not a fan of how it's done on SO. To me the best solution is not to include it at all. If you have something negative to say about a PR or Issue, it makes more sense to explain why you feel that way instead of outright saying no. The +1 makes it very clear that you're saying "this covers my use-case." What does -1 mean here, other than "I don't want this"? Because not wanting something is not a reason not to include it when everybody is using a project for a different use-case.

Re: Add Reactions to Pull Requests, Issues, and Comments

#234

Post by nv-vn »

gkoberger wrote: post #88
mrharrison wrote: post #51

-1 or the thumbs down reaction, I think is a mistake. They aren't usually that constructive, because most of the time they are used as retaliation against a specific user, instead of constructive criticism. If someone downvotes you, you tend to downvote them. At the least, it should be a privilege to down vote, like SO and HN do. http://stackoverflow.com/help/privileges/vote-down

Agreed 100% for Facebook or even Hacker News, however on GitHub it would be really useful for voting. If you ask "Should we add this feature?", it's hard to understand what favorites mean if you don't have an anchor. Does 10 thumbs-up mean unanimous support, or is it just a small minority? It'd be nice to say "Oh, 10 upvotes... but there's 90 downvotes, so we won't do it." FB and Hacker News are a marketplace of rela…

Maybe it would be better to make real user polls then? Or how about just making the downvote optional when creating the issue/PR? I think in general, down voting serves more bad than good on nearly any medium.

Re: Add Reactions to Pull Requests, Issues, and Comments

#235

Post by nv-vn »

philliphaydon wrote: post #134
mrharrison wrote: post #51

-1 or the thumbs down reaction, I think is a mistake. They aren't usually that constructive, because most of the time they are used as retaliation against a specific user, instead of constructive criticism. If someone downvotes you, you tend to downvote them. At the least, it should be a privilege to down vote, like SO and HN do. http://stackoverflow.com/help/privileges/vote-down

I shall respectfully disagree. Not wanting down votes is just a way of saying "I'm offended please don't offend me I can't handle down it's it makes me sad" It's 2016, can we stop worrying about if someone disagrees with you and just accept the fact they wanted to down vote on an issue rather than say nothing or leave a comment.

No, it's because downvotes actively censor unpopular opinions based on the fact that they're unpopular rather than their merit. Check out reddit some time and you'll see this happen a lot.

Re: Add Reactions to Pull Requests, Issues, and Comments

#236

Post by new_hackers »

scatters wrote: post #214
rtpg wrote: post #97

Earlier quoted context omitted.

Internally when voting (informally) on things we do +1, +0, -0, and -1. Super helpful to be able to ask for everyone's opinion while they can also express the strength of their opinion. Feel like that would be very useful

C++ standardization votes on a 5-point scale: Strong For, For, Neutral, Against, Strong Against. I think it's important to be able to express the lack of an opinion, although I guess you could do that on a 4-point scale by abstaining.

I've often wondered why the "two thumbs up" isn't really used anywhere that I've seen. It is a logical progression that gives more precision to the reaction.

Re: Add Reactions to Pull Requests, Issues, and Comments

#237

Post by PeterStuer »

esailija wrote: post #192
PeterStuer wrote: post #189

Interesting cultural bias. Why are people not questioning unsubstantiated up-votes, but feel down-voters shouldn't be let of the hook without a full argumentation?

Upvote is already backed by the arguments the upvoted post contains. Downvote is not backed by those arguments. They are not symmetrical at all and there is no bias.

That is only true if the upvoted post contained an argumentation and not just a statement or an observation.

Re: Add Reactions to Pull Requests, Issues, and Comments

#238

Post by moe »

esailija wrote: post #191
moe wrote: post #161

Earlier quoted context omitted.

> I'm not sure why you keep repeating this point. Because your distinction is wrong. A drive-by -1 is in no way different from a drive-by +1. Both are equally useful. Both indicate how many people agree or disagree. Neither explains why someone agrees or disagrees.

They are very different. The explanation for +1 is in the post you are upvoting. Thats why nobody ever has to ask "why the upvotes?'.

Sorry but you make no sense.

If the explanation for +1 is in the post you are upvoting, then the explanation for -1 is just as well in the post you are downvoting.

Post reply on HN