> USB-C
I've had two MBPs with only USB-C ports, and this is a complete non-issue to me. I have a "microdock" that gives me the ports I want when I want them and otherwise stays put away. Even on my Samsung TabPro, which only has a single USB-C port, it's not really an issue.
> lack of hardware updates
This is a huge issue for me. Apple has kept the pricing high on their notebooks while not improving performance. The only thing they have going for them from my POV these days is build quality and macOS. Others are catching up in build quality, and even Windows 10 supports native Linux well enough that macOS has lost much of its luster.
> keyboards
Meh. I don't really have an opinion on this one. I'm typing on a "new" MBP keyboard right now and it works fine. It's a bit sensitive to sand and other particles, but so far I've not had one actually fail to the point that the issue wasn't resolved with a few hard keypresses and a shot of compressed air.
> try to start using primarily OSS software
This is probably the key to why I'm both dissatisfied with Apple and not as upset as others seem to be about it. I moved to macOS in ~2011 because I wanted a durable laptop, and planned to install ArchLinux on it. I gave macOS a shot and it was "close enough" to Linux that it didn't make sense to deal with all the headaches of dealing with a non-native OS.
> Apple is making a lot of money in the iOS ecosystem
... and as best I can tell, that's where they're innovating too. I sold my personal MBP this spring, bought a 6th-gen iPad, and haven't looked back. It's more than suitable for mobile media consumption, programming (via MOSH to a remote server), and photo processing.
Unless something big changes, my next machine will probably be an iPad Pro in a couple of years. I have no plans at this time to ever buy a laptop for myself again.