Any time I see arguments to effect of "lawyer X lawyered for Y, and Y is bad, so lawyer X is bad," I remember an episode from Star Trek: TNG called "The Measure of a Man," in which Picard is chosen to defend Data's right to self-determination as a sentient being, and Riker is chosen to make the opposite case for the character that wants to treat Data as a machine, a weapon that can be reallocated freely like a Jeep o…
Anecdotally, my father was a criminal defense attorney. There clients he didn't want to represent for personal reasons but did due to financial obligations, part of the profession. Lucky for him later in his career he was able to pick and choose more freely.
But I agree, the "lawyer X lawyered for Y" argument is a farce in most cases.