Hub Git Wrapper

#1

Post by Immortalin » Thu, May 28, 2015, 5:38 AM UTC

Re: Hub Git Wrapper

#2

Post by suprjami » Thu, May 28, 2015, 10:38 AM UTC

I once tried to PR from hub.

It sent the PR from my branch on my fork to master on my fork. Obviously I wished to PR against the original thing I forked from.

I just stick to the web interface now.

Re: Hub Git Wrapper

#3

Post by ultrafez » Thu, May 28, 2015, 10:50 AM UTC

suprjami wrote: post #2

I once tried to PR from hub. It sent the PR from my branch on my fork to master on my fork. Obviously I wished to PR against the original thing I forked from. I just stick to the web interface now.

You could submit a pull request to hub to fix it!

Perhaps not using hub to do so, though.

Re: Hub Git Wrapper

#4

Post by zimbatm » Thu, May 28, 2015, 10:55 AM UTC

Thanks to hub the friction to contributing is much lower for me. That's how I contribute back to projects on github:

    hub clone user/repo
    cd repo
    git checkout -b my-contrib
    # ... fix fix fix ...
    hub fork
    git push -u zimbatm my-contrib
    hub browse # Opens browser on my fork
    # Create PR with comment in browser

Re: Hub Git Wrapper

#5

Post by emacsfodder » Thu, May 28, 2015, 10:59 AM UTC

suprjami wrote: post #2

I once tried to PR from hub. It sent the PR from my branch on my fork to master on my fork. Obviously I wished to PR against the original thing I forked from. I just stick to the web interface now.

What you needed was to use the options -h (head, ie. the feature branch) and -b (base, ie the upstream master) eg.

    git pull-request \
      -m "I added an awesome feature"\
      -b baserepo:master\
      -h myfork:feature-branch

Re: Hub Git Wrapper

#6

Post by emacsfodder » Thu, May 28, 2015, 11:00 AM UTC

ultrafez wrote: post #3

suprjami wrote: post #2

I once tried to PR from hub. It sent the PR from my branch on my fork to master on my fork. Obviously I wished to PR against the original thing I forked from. I just stick to the web interface now.

You could submit a pull request to hub to fix it! Perhaps not using hub to do so, though.

hub works just fine to create a PR, some lack of RTFM is at play.

Re: Hub Git Wrapper

#7

Post by jballanc » Thu, May 28, 2015, 11:06 AM UTC

zimbatm wrote: post #4

Thanks to hub the friction to contributing is much lower for me. That's how I contribute back to projects on github: hub clone user/repo cd repo git checkout -b my-contrib # ... fix fix fix ... hub fork git push -u zimbatm my-contrib hub browse # Opens browser on my fork # Create PR with comment in browser

Just a note, you can simplify your workflow even further by using `hub pull-request` . If your PR consists of a single commit, it'll even pre-populate the PR description for you (if not, it helpfully lists the commits included in the PR in the comments of the PR/commit message).

Re: Hub Git Wrapper

#8

Post by justinsb » Thu, May 28, 2015, 11:35 AM UTC

emacsfodder wrote: post #5

suprjami wrote: post #2

I once tried to PR from hub. It sent the PR from my branch on my fork to master on my fork. Obviously I wished to PR against the original thing I forked from. I just stick to the web interface now.

What you needed was to use the options -h (head, ie. the feature branch) and -b (base, ie the upstream master) eg. git pull-request \ -m "I added an awesome feature"\ -b baserepo:master\ -h myfork:feature-branch

The GitHub web interface defaults to the PR-to-upstream behavior though, so this is at least an inconsistency; I would argue it is a bug.

Re: Hub Git Wrapper

#9

Post by skj » Thu, May 28, 2015, 11:36 AM UTC

emacsfodder wrote: post #6

ultrafez wrote: post #3

Earlier quoted context omitted.

You could submit a pull request to hub to fix it! Perhaps not using hub to do so, though.

hub works just fine to create a PR, some lack of RTFM is at play.

So, I never trust users to give me advice on features to add.

But I always believe them when they say something is difficult or confusing. Research should not be required to make a good CLI do what you want, provided you understand what you want.

Re: Hub Git Wrapper

#10

Post by michaelmior » Thu, May 28, 2015, 11:55 AM UTC

suprjami wrote: post #2

I once tried to PR from hub. It sent the PR from my branch on my fork to master on my fork. Obviously I wished to PR against the original thing I forked from. I just stick to the web interface now.

I believe will always default to sending the PR to the remote named origin. If you have the original repo listed as origin and your repo as a remote with your username, you get the expected behaviour. I think the issue here is that hub has no explicit knowledge of the ancestry of the repo so unless it fetches this from the GH API, I think it's doing the only logical thing.