Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Bug 1202858 – Restarting squid results in deleting all files in hard-drive

bugzilla.redhat.com

Post reply on HN
Print view View original

131–140 of 179 posts

Re: Bug 1202858 – Restarting squid results in deleting all files in hard-drive

#131

Post by jasonlotito »

cssmoo wrote: post #110
rwmj wrote: post #85

Earlier quoted context omitted.

This is simply not true. Could you provide evidence rather than making stuff up.

Ok. Fresh steaming proof as requested: https://bugzilla.redhat.com/buglist.cgi?bug_severity=urgent&... All high severity bugs against 7.1 which was relased 16 days ago. Check the dates on half of them. They're before the release date and half of them haven't even been assigned or triaged. When 7.0 came out, datetimectl and systemd didn't even work properly. Enabling ntp threw dbus errors galore. On some kit it didn't…

First "high severity bug against 7.1" on the list:

"Customers would like to be able to use their IdM users to log on to Window clients that a part of the trusted domain."

"Doc Type: Enhancement"

Couple that with what rwmj said, you've effectively debunked yourself.

Re: Bug 1202858 – Restarting squid results in deleting all files in hard-drive

#132

Post by bandrami »

Xylakant wrote: post #100
4ad wrote: post #99

Earlier quoted context omitted.

Oh, I see.

Specifically, this bug would not have happened with systemd since systemd does not leave the handling of pid-files and pid-dirs to shell-scripts.

No, but if an analogous bug happened (systemd forgot to set an internal squidroot variable before clearing the squidroot, for instance), it would be much, much harder to figure out what was going on. Which is really what everybody's complaints boil down to.

Re: Bug 1202858 – Restarting squid results in deleting all files in hard-drive

#133

Post by jedisct1 »

anh79 wrote: post #84
ioquatix wrote: post #56

Earlier quoted context omitted.

Or just use zsh.

zsh is an interactive shell. It is not to replace #bash as system shell as I know.

Zsh doesn't have to be used interactively.

It's also excellent for scripting, and has far more features than bash.

Re: Bug 1202858 – Restarting squid results in deleting all files in hard-drive

#134

Post by twic »

blueskin_ wrote: post #106
guardian5x wrote: post #74

Earlier quoted context omitted.

I wonder why set -eu is not the default setting.

1. open bash 2. set -e 3. type an invalid command or run one that returns non-zero 4. "crap, where did my shell go?"

It could be the default for non-interactive shells without causing this problem. Or we could have a more nuanced rule, where -e means "stop executing the current sequence of commands as soon as there is an error", where a "sequence of commands" is a single line in an interactive shell (so "false; whoami" would print nothing), or the entire file in a script.

The real answer is that this has not been the default in the time between shells being invented and this comment being posted, and so the squillions of lines of shell script out there in the wild keeping the world turning have not been written with this in mind. Making it the default now would break a lot of things.

With the benefit of hindsight, though, i would say that yes, this should have been the default in scripts. Oh well.

Re: Bug 1202858 – Restarting squid results in deleting all files in hard-drive

#135

Post by coldpie »

gmac wrote: post #62
ulrikrasmussen wrote: post #54

Earlier quoted context omitted.

The * is expanded by the shell to a space-delimited list of filenames, but the shell does not adequately escape filenames that can be misinterpreted as arguments to 'rm'.

That's kind of scary — in that case I guess I should avoid creating a file named -rf.

Yes. There was an article linked from HN ages ago (at least a year) that went into mitigation techniques for these issues. As you expect, it basically became fractal, and even then still had bugs. I wish I still had the URL.

Re: Bug 1202858 – Restarting squid results in deleting all files in hard-drive

#136

Post by Navarr »

VieElm wrote: post #41
elchief wrote: post #4

We had one of these kinda bugs. If you uninstalled our software it deleted a major chunk of your Windows registry, crippling your computer. It was a one character error in our script. The first ticket read "Uninstalling [Product] destroys your computer". I was responsible for customer support. Good times! Was a rough week. We managed to not get sued.

Pretty terrible that such a thing is even allowed by Windows. This is why as a user I like Apple's OS X sandbox.

Windows 8 introduced a sandbox and users hated it. (Probably because it also forced digital signatures but hey, specifics)

Re: Bug 1202858 – Restarting squid results in deleting all files in hard-drive

#137

Post by jdub »

blueskin_ wrote: post #104
viraptor wrote: post #7

Earlier quoted context omitted.

I would bet on the issue being in the init script itself rather than squid. (I'm assuming squid doesn't run as root by default in rhel) If that's true then it's another point for more sane process managers (upstart/supervisord/systemd/...)

"systemd" and "sane" only ever go in the same sentence as "sane people don't use systemd". It looks like a bug in the init script; runnign it as squid's user wouldn't have triggered destroying the whole filesystem; likely just squid's config and anything under its /var.

"systemd" and "sane" only ever go in the same sentence as "sane people don't use systemd".

It looks like a bug in the init script...

Ha ha ha ha ha ha ha.

Re: Bug 1202858 – Restarting squid results in deleting all files in hard-drive

#138

Post by res0nat0r »

vacri wrote: post #113
stbenjam wrote: post #101

Earlier quoted context omitted.

It's exceptionally clear for anyone even remotely familiar with RHEL or Bugzilla. It's not mean for any joe's consumption anyway, this is a work tool used by developers and QE...

'exceptionally clear'? How do you detect that bug status from across the room? If that bug page was up on a big screen, how do you detect it's status? How do you tell at a glance from a meter away what the status is? All of those things should be doable for an 'exceptionally clear' status. Developers don't have mysteriously different visual capabilities from 'joes'. this is a work tool used by developers and QE Becau…

> How do you detect that bug status from across the room?

Know and understand the tools you are working with, and simply click the Modified (History) link at the top to determine the bug timeline: https://bugzilla.redhat.com/show_activity.cgi?id=1202858

Re: Bug 1202858 – Restarting squid results in deleting all files in hard-drive

#139

Post by Someone1234 »

woah wrote: post #81
jiffytick wrote: post #35

Earlier quoted context omitted.

or check the variable before using it, like any other programming language: [[ "$VAR" ]] && rm -rf "$VAR/*" I think most of these issues stem from the fact that most developers that write shell scripts don't actually understand what they're doing, treating the script as a necessary annoyance rather than a component of the software.

Elephant in the room- shell is a bizarre language

Yeah, everyone always loves to shit on BAT (which is fair, it is terrible) and VBS (which is slightly less fair) but inspite of how many problems Bash has (least of all the massive security issue last year), it gets off almost scot free.

These bugs are indicative of Bash's design problems. Why is it used for init scripts? And don't even get me started on how Bash interprets filenames as part of the arguments list when using * (e.g. file named "-rf").

Say what you will about Powershell, but having a typed language that can throw a null exception is useful for bugs like these. The filename isn't relevant, and a null name on a delete won't try to clear out of the OS (just throw).

Re: Bug 1202858 – Restarting squid results in deleting all files in hard-drive

#140

Post by rjcz »

emmelaich wrote: post #123
jiffytick wrote: post #35

Earlier quoted context omitted.

or check the variable before using it, like any other programming language: [[ "$VAR" ]] && rm -rf "$VAR/*" I think most of these issues stem from the fact that most developers that write shell scripts don't actually understand what they're doing, treating the script as a necessary annoyance rather than a component of the software.

I think a better alternative is something like rm -r "${VAR:-var_is_not_set_so_please_fix_this_script}" which substitutes the var_is_... if VAR is not set. BTW, I hate hate hate -f. It has two meanings: 1. 'force' the removal 2. ignore any error I've seen an instance of this sort of bug in my sysadmin career that I remember. It was a Solaris patch which wiped a chunk of the system.

No, this will remove 'var_is_not_set_so_please_fix_this_script' file if one exists.

If you're suggesting using parameter expansion, at least suggest the correct one (i.e. one that will give a meaningful error message):

    ${parameter:?word}
http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3...
Post reply on HN