Begginer in C. Critique my code and give ideas?

#1

Post by zeved » Fri, Jan 30, 2015, 12:11 PM UTC

Begginer in C. Critique my code and give ideas?
github.com

Re: Begginer in C. Critique my code and give ideas?

#2

Post by zeved » Fri, Jan 30, 2015, 12:11 PM UTC

Hello HN. I'm trying to learn / relearn C (for real this time). Wrote this little tool for linux and I would like some feedback. Also, if you could give me some ideas for future small projects that would give me more experience in C... thanks!

Re: Begginer in C. Critique my code and give ideas?

#3

Post by plikan13 » Fri, Jan 30, 2015, 1:22 PM UTC

zeved wrote: post #2

Hello HN. I'm trying to learn / relearn C (for real this time). Wrote this little tool for linux and I would like some feedback. Also, if you could give me some ideas for future small projects that would give me more experience in C... thanks!

  int get_number(char buffer[])
  {
    long int i = 0;
    char *p;
    if(fgets(buffer, sizeof(buffer), stdin) != NULL)
  {

sizeof(buffer) will always be 4 (or 8 if you compile 64 bit) because sizeof(pointer to char) is 4 (or 8). It will NOT be the size of the buffer that you pass as an argument. To fix this problem you need to change the function to

  int get_number(char buffer[], int buffer_size)

Also the buffers that you pass to this function seem to be too small.

Re: Begginer in C. Critique my code and give ideas?

#4

Post by zeved » Fri, Jan 30, 2015, 3:09 PM UTC

plikan13 wrote: post #3

zeved wrote: post #2

Hello HN. I'm trying to learn / relearn C (for real this time). Wrote this little tool for linux and I would like some feedback. Also, if you could give me some ideas for future small projects that would give me more experience in C... thanks!

int get_number(char buffer[]) { long int i = 0; char *p; if(fgets(buffer, sizeof(buffer), stdin) != NULL) { sizeof(buffer) will always be 4 (or 8 if you compile 64 bit) because sizeof(pointer to char) is 4 (or 8). It will NOT be the size of the buffer that you pass as an argument. To fix this problem you need to change the function to int get_number(char buffer[], int buffer_size) Also the buffers that you pass to th…

thank you very much. i appreciate it!