Live data from Hacker News

I made a patch for Mozilla, and you can do it too

marti.us

21–30 of 38 posts

Re: I made a patch for Mozilla, and you can do it too

#21
post #15

I did it! https://bugzilla.mozilla.org/show_bug.cgi?id=548763 Unfortunately it took quite a long time, the Mozilla process is quite confusing to a newcomer, even one with a lot of open source project experience. I definitely second the recommendation of finding a mentor.

I don't think I would have been able to get my two patches into Mozilla if it wasn't for the mentored bugs program. It's incredibly useful and I wish more projects would implement it. ahemopenstackcough.

Re: I made a patch for Mozilla, and you can do it too

#23
post #10

I wonder how much of his positive experience is due the fact that he decided to contribute to Servo instead of one of the "main" Mozilla projects (Gecko, SpiderMonkey, Firefox etc). Less hairy codebase, smaller community, github-based, and probably lot more suitable low-hanging fruits.

I got a couple patches through to Firefox proper. One was a fairly easy bugfix[1], but the other[2] took me lots and lots of iterations to get correct. The mentor was extremely patient, taking what I think was more time to explain to me how to do it right than it would have taken him/her to just do it themselves.

The worst part for me wasn't understanding the code (though following through some of the XPCOM stuff is tough), but working with Mercurial. I was tempted several times to abandon it and use a git mirror. Anyone that says patch queues are equivalent to git rebase is crazy.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1006656 [2] https://bugzilla.mozilla.org/show_bug.cgi?id=907310

Re: I made a patch for Mozilla, and you can do it too

#24
post #20

In your post you mentionned that a goo way to start working with open-source project it to look for smaller scale projects to contribute on github. If been working hard to make it easier for people to find interesting/smaller projects on github by creating the /r/coolgithubprojects and the http://coolgithubprojects.com/ website lately. It's not perfect but anyone who's looking to contribute and find interesting will…

Thanks for that, I'll have a look and mention it if I make a follow-up post.

I think that good small projects can be plug-ins to bigger projects, or a library that someone use in a project.

Re: I made a patch for Mozilla, and you can do it too

#25
post #20

In your post you mentionned that a goo way to start working with open-source project it to look for smaller scale projects to contribute on github. If been working hard to make it easier for people to find interesting/smaller projects on github by creating the /r/coolgithubprojects and the http://coolgithubprojects.com/ website lately. It's not perfect but anyone who's looking to contribute and find interesting will…

I have also created a site designed to help people find smaller scale Github projects. You can find it here : http://gilles-leblanc.github.io/dispatcher/

Re: I made a patch for Mozilla, and you can do it too

#26
post #10

I wonder how much of his positive experience is due the fact that he decided to contribute to Servo instead of one of the "main" Mozilla projects (Gecko, SpiderMonkey, Firefox etc). Less hairy codebase, smaller community, github-based, and probably lot more suitable low-hanging fruits.

I got a couple patches through to Firefox proper. One was a fairly easy bugfix[1], but the other[2] took me lots and lots of iterations to get correct. The mentor was extremely patient, taking what I think was more time to explain to me how to do it right than it would have taken him/her to just do it themselves. The worst part for me wasn't understanding the code (though following through some of the XPCOM stuff is…

If you dont need to actually push the code to the reposity (which you wont for the first bunch of patches) it is totally fine to use git, the github mirror is at

https://github.com/mozilla/gecko-dev

and you can just upload patches for review

Re: I made a patch for Mozilla, and you can do it too

#27
post #18

...but can I patch the look and feel of the user interface, or are we not permitted to patch superficial things that affect "branding" and user experience? I liked Firefox 28, not Firefox 29 and up.

Given that people have written add-ons to do just that, there's no need to even make patches for it.

The "Classic Theme Restorer" add-on works pretty well and has a lot of preference to tweak the UI to your liking:

https://addons.mozilla.org/en-US/firefox/addon/classicthemer...

Re: I made a patch for Mozilla, and you can do it too

#28

Earlier quoted context omitted.

I got a couple patches through to Firefox proper. One was a fairly easy bugfix[1], but the other[2] took me lots and lots of iterations to get correct. The mentor was extremely patient, taking what I think was more time to explain to me how to do it right than it would have taken him/her to just do it themselves. The worst part for me wasn't understanding the code (though following through some of the XPCOM stuff is…

If you dont need to actually push the code to the reposity (which you wont for the first bunch of patches) it is totally fine to use git, the github mirror is at https://github.com/mozilla/gecko-dev and you can just upload patches for review

Mozilla also hosts its own git server: http://git.mozilla.org/

Re: I made a patch for Mozilla, and you can do it too

#29
post #7

What's kind of skills for programming with Mozilla?

Basically, anything. Have a look at http://www.whatcanidoformozilla.org to have a glimpse on what you can do for the project.

Thank you for sharing that. I had NO IDEA that the Mozilla team had such diverse needs, and had always assumed that it was all over my head.

Re: I made a patch for Mozilla, and you can do it too

#30
post #19
post #6

Earlier quoted context omitted.

C++, Javascript, Python... or Rust ! :)

Or even C, which some parts are written in, although it doesn't look like they're particularly friendly to lots of people changing them (IIRC some of the parsing and lexing code is in C, correct me if I'm wrong).

Most of the C code is in the venerable (Netscape) NSPR and NSS libraries and third-party libraries for media codecs and graphics.
Post reply on HN