Live data from Hacker News

Nginx SPDY heap buffer overflow (affects 1.3.15 – 1.5.11)

nginx.org

11–20 of 32 posts

Re: Nginx SPDY heap buffer overflow (affects 1.3.15 – 1.5.11)

#11
post #5

Earlier quoted context omitted.

Usual reason for mistakes like this is: someone was debugging something then (partially) forgot to clean up before committing. Once that is done it's incredibly easy for these kind of bugs to go un-noticed for a long time.

Assuming you don't have a test for it, sure. And don't fuzz everything on a regular basis.

[deleted]

Re: Nginx SPDY heap buffer overflow (affects 1.3.15 – 1.5.11)

#12
post #9

It said it affected 1.3.15 to 1.5.11 but the fix is available in nginx 1.5.12, 1.4.7 . So for those who are using legacy version are they going to rely on distro vendor to push the patch? Just curious, even though I guess the number of users who have activated this experimental SPDY is low and people who actually have it enabled probably know how to fix it themselves.

1.5.12 is the latest devel branch and 1.4.7 is the latest release branch (released in response to this CVE and excepted from the vuln range). The patch works for any of the intervening versions.

As far as I'm aware, all the major distros backport nginx stable release

Re: Nginx SPDY heap buffer overflow (affects 1.3.15 – 1.5.11)

#13
Before you panic: "The problem affects nginx 1.3.15 - 1.5.11, compiled with the ngx_http_spdy_module module (which is not compiled by default) and without --with-debug configure option, if the "spdy" option of the "listen" directive is used in a configuration file."

Re: Nginx SPDY heap buffer overflow (affects 1.3.15 – 1.5.11)

#14

Patch is pretty interesting. Why was buffer overflow protection behind a debug flag? http://nginx.org/download/patch.2014.spdy2.txt

And why leave in a #if when patching too?

Keeps the changes to a minimum, reducing the risk of effecting anything else. (quicker + safer)

Re: Nginx SPDY heap buffer overflow (affects 1.3.15 – 1.5.11)

#15

Patch is pretty interesting. Why was buffer overflow protection behind a debug flag? http://nginx.org/download/patch.2014.spdy2.txt

And why leave in a #if when patching too?

I assume the reason was to keep diff as minimal as possible. Note that it should apply to all mentioned versions without problems.

Re: Nginx SPDY heap buffer overflow (affects 1.3.15 – 1.5.11)

#16
post #5

Earlier quoted context omitted.

Usual reason for mistakes like this is: someone was debugging something then (partially) forgot to clean up before committing. Once that is done it's incredibly easy for these kind of bugs to go un-noticed for a long time.

Assuming you don't have a test for it, sure. And don't fuzz everything on a regular basis.

[deleted]
Post reply on HN