Shit programmers write

This feels horribly familiar. I'm not sure to recognize the specific language used, but there must be cases where one would like to target empty of filled with non processable characters strings only, and let null and falsy values pass through. This kind of use would typically need a line of comment, but hey...

Re: Shit programmers write

#7

Post by wreegab » Thu, Dec 19, 2013, 1:29 PM UTC

MattBearman wrote: post #5

Love this one: return foo == null ? null : foo;

This reminds me of this one, which is quite common:

   return foo == null ? true : false;

Re: Shit programmers write

#8

Post by goldenkey » Thu, Dec 19, 2013, 1:30 PM UTC

hrktb wrote: post #6

> if (Session["startDate"] + "" == "") This feels horribly familiar. I'm not sure to recognize the specific language used, but there must be cases where one would like to target empty of filled with non processable characters strings only, and let null and falsy values pass through. This kind of use would typically need a line of comment, but hey...

I'm guessing you don't realize that the plus operator has less precedence than the == operator.

That if is equivalent to if (startDate + true)

EDIT: I was wrong. I haven't slept.

Re: Shit programmers write

#9

Post by Leszek » Thu, Dec 19, 2013, 1:32 PM UTC

wreegab wrote: post #7

MattBearman wrote: post #5

Love this one: return foo == null ? null : foo;

This reminds me of this one, which is quite common: return foo == null ? true : false;

It's better than

    return foo ? true : false;

or even

    return foo == true ? true : false;

Re: Shit programmers write

#10

Post by kirab » Thu, Dec 19, 2013, 1:35 PM UTC

goldenkey wrote: post #8

hrktb wrote: post #6

> if (Session["startDate"] + "" == "") This feels horribly familiar. I'm not sure to recognize the specific language used, but there must be cases where one would like to target empty of filled with non processable characters strings only, and let null and falsy values pass through. This kind of use would typically need a line of comment, but hey...

I'm guessing you don't realize that the plus operator has less precedence than the == operator. That if is equivalent to if (startDate + true) EDIT: I was wrong. I haven't slept.

Sadly you are wrong. See an operator precedence list: http://bmanolov.free.fr/javaoperators.php