Earlier quoted context omitted.
Education software is literally the worst. Moodle was pretty ick to begin with, but you should've seen the state of one install I had to work on by the time I got to it. I still have nightmares.
Needs disrupting
How not to check the validity of an email address
111–120 of 243 posts
Re: How not to check the validity of an email address
#112Earlier quoted context omitted.
As a history major, I would agree with you. One of the real issues has to do with the mentality of coding. There are people regardless of background who approach coding as a job, and those who approach it as a craft. You want the latter, not the former. Here's my rule: If you don't look back at code you wrote a decade ago with some degree of horror, you are either an extraordinarily good coder, or you aren't a good c…
A decade is a long time at a single job... Try six months for a good start :)
Then again I started learning ios programming then so I might have a bias/reason for it. >.<
Re: How not to check the validity of an email address
#113Re: How not to check the validity of an email address
#114Earlier quoted context omitted.
If I recall correctly the code looked something like this: if (!admin()) echo " window.location = '/signin'; "; delete_bid($_GET['bid_id']); ?>
a simple 'else' would have at least stopped the deleting part :/
Re: How not to check the validity of an email address
#115Actually, I'm not quite sure why or whether it's good to be reminded of this. Maybe it's better to try and forget it.
Re: How not to check the validity of an email address
#116I'm sad to see so many smart people wasting their time discussing what some stupid person did. :( I'm also disappointed I lost a couple of minutes of my life reading about this stupidity as well... just because it got 233 points. So, I'm looking at YOU 233 who upvoted this. WHY DID YOU DO IT?
Just click the downvote button on my comment. Don't bother to explain anything.
Oh, I know, you disapprove I called you smart. Sorry about that.
Re: How not to check the validity of an email address
#117Earlier quoted context omitted.
Yes, I decided to ignore that constraint because it doesn't make sense :). The article suggests performing "server-side membership testing, which is O(1)", but I think this is a bit too much — you can do even easier server-side validation without the list of all valid e-mail addresses, just the information that "@[anything but these two domains] is not an OK target".
> Yes, I decided to ignore that constraint because it doesn't make sense :). Then the customer won't pay you because you ignored their requirements. They might even sue you because you breached contract. If the customer asks you for a mound of poo you write them a mountain of poo; you try your damned hardest to make sure that the room smells like poo when they are using the app. If they go home and tell their wife an…
Re: How not to check the validity of an email address
#118Man. Reading posts like these has several effects on me. One is utter shock that anyone could be so stupid. Another is to remind me of how little I know (because I'm sure in the eyes of someone who actually knows anything about security, I'd probably provoke the same reaction). I'm also amazed that some of the people responsible for these things can still find work. Here's my own personal story. The other day, I had…
Not necessarily. They may be using a reversible hash. Not much more secure, but it beats plaintext.
I used that site to show my boss his plaintext password to explain why MD5 alone is barely more than security though obscurity when trying to convince him that we needed to salt them as well - he agreed with me on the spot.
Re: How not to check the validity of an email address
#119In college I was hired to build an auction site. I was billing my client $20 / hour and subcontracting out the work to some of my fellow classmates at $10 / hour. I was swamped with other work and didn't have much time to review the code. I just made sure it satisfied the specifications and shipped it. We launched the site and did a few hundred thousands dollars worth of transactions in the first 24 hours. Then somet…
Sooooo I declined but someone took the job ... for under 8$ an hour.
How much quality can you expect for that price???
Re: How not to check the validity of an email address
#120Somewhat unrelated, but out of curiosity, does anyone know of a site that lists — for all popular languages — various libraries/code snippets/routines which one can use to correctly (according to the RFCs) check the validity of e-mail addresses? If not I may be compelled to create one.
I check it with this RegEx to make sure it's in the right format of [string]@[string].[string] to make sure that user at least tries to enter an email address, but beyond that sending and email and getting a response is the only way.