Bootstrap Magic featuring Boostrap 3 • Hacker News Board

Re: Bootstrap Magic featuring Boostrap 3

#11

Post by tux1968 » Tue, Sep 03, 2013, 7:16 PM UTC

daenney wrote: post #3

Digging the idea and I like the Apply feature. However, I have no idea what your JS is doing but it spiked my browser CPU usage to 100% on a core and made the whole thing fairly unresponsive until I closed that tab.

Same here with Firefox unfortunately, making it essentially unusable.

Re: Bootstrap Magic featuring Boostrap 3

#12

Post by roryokane » Tue, Sep 03, 2013, 11:31 PM UTC

Pretty nice. But I think it needs better generality in values – more references to other variables, and color functions. If I make my primary brand color the light yellow #faf332 and the link color a very dark yellow, there are a lot of places on the page that still have unreadable white text on a yellow background, such as @btn-primary-color (which I set to #111) and @pagination-active-color (which I set to @link-color). Those values should use some function of @link-color or another variable as their default value. And colors should use appropriate functions to choose a light or dark color that maximizes contrast against their background.

Re: Bootstrap Magic featuring Boostrap 3

#13

Post by tsifei » Wed, Sep 04, 2013, 7:44 AM UTC

tlarkworthy wrote: post #2

Really cool, but slow. AngularJS Batarang might help profile the hot spots.

Yeh definetely, we just update a new version. It is faster now.

Re: Bootstrap Magic featuring Boostrap 3

#14

Post by Foxandxss » Mon, Sep 09, 2013, 9:18 PM UTC

It is indeed faster but I am sorry to say that this is a good example of "How to not develop an angular app".

DOM manipulation in a controller is something you can't do and who says controllers, says services too.

On the other hand, the double ng-repeat could be a hot spot for the bad performance.

Don't get me wrong, the app is awesome, awesome idea but the implementation doesn't respect the angular way so it is really slow.