How do I close an open pull request from this view? I don't see it.
GitHub's on your phone
61–70 of 86 posts
Re: GitHub's on your phone
#62"Our phones, on the other hand, aren’t great for creating things but they’re perfect for browsing and reading content." Tell that to Instagram, Vine, Twitter, or Smule. Mobile phones are amazing creation tools.
All of the tools you mentioned can be replaced by their desktop counterparts.
I would argue against using your mobile device to create relevant content. I know people want an all-in-one toolkit that does everything great but let's go with history on this, it won't work.
A jack of all trades is good but a specialized tool will always be better.
Instagram I've never heard of Smule.
Again, this is simply my opinion but I feel like some folks are too fast to do everything on their 'mobile device' (let's not call it a smartPHONE).
Re: GitHub's on your phone
#63I'm not sure what took GitHub so long to _finally_ implement a mobile view for the site, but thank you. I have been waiting for this to happen for years, quite literally. Edit: It's worth noting I've heard plenty of counter arguments to using GitHub from my phone. But I will say, sometimes I want to check out a project and possibly browse source and lo and behold I'm not at my desktop. For this reason alone, a mobile…
Maybe it's a coincidence but this was a sticking point during a discussion between a couple folks at GitHub and Scott Hanselman on the HanselMinutes podcast episode aired on June 14th. Link: http://hanselminutes.com/375/on-culture-and-remoteness-at-gi...
Likely a coincidence, but I'm a little bummed they didn't mention it if they knew it was coming. ;)
Re: GitHub's on your phone
#64I'm sad to see this didn't come with a responsive design for the main site. You get horizontal scrollbars everywhere if your window is thinner than ~1000 pixels, making it impossible to have code + GitHub side by side on a laptop without some serious annoyance. The repo redesign made it worse, as now all the in-project links (issues, pulls, wiki...) are offscreen. I'd happily work around this by using the mobile view…
Ya, I just resized expecting to see the mobile site "pop" in but it's a whole 'nother app!
Re: GitHub's on your phone
#65"Our phones, on the other hand, aren’t great for creating things but they’re perfect for browsing and reading content." Tell that to Instagram, Vine, Twitter, or Smule. Mobile phones are amazing creation tools.
Instagram, Vine, Twitter, and the like were not written on phones. You're just deliberately misconstruing their point.
Re: GitHub's on your phone
#66Earlier quoted context omitted.
could you elaborate?
It was recently the feature of a blog post: https://github.com/blog/1557-github-flow-in-the-browser
Even with the ability to CRUD files from the browser I don't think github would fit non dev audience with well. Most normal people use word processor or a spreadsheet program, those files aren't well suited for git and you can't edit them on github
Re: GitHub's on your phone
#67Re: GitHub's on your phone
#68So you're trying to tell me my phone isn't even the right device to make line comments in pull requests?
Re: GitHub's on your phone
#69Earlier quoted context omitted.
For us, it made sense. Our desktop site is pretty large. Check the graph in the blog post- the mobile pages are about 1/10th the size of the desktop CSS and JavaScript. By avoiding a responsive design, we can make things load disproportionately faster for our use case. On top of that, it's isolated so we're less likely to break views by adding features later. Pretty fun.
Congrats to you and the team on launching this. I'd love to know the technical approach on this. That is, is the different HTML/CSS/JS view called by the Rails controller, based on the request's user agent? Though responsive designs are often a good call, I completely agree with your decision to do custom views here. I'd love to know where in the process the filtering happens, though, such that you retain the URLs (n…
37Signals did something similar, which you might find helpful:
http://37signals.com/svn/posts/3257-backstage-basecamp-for-m...
https://public.basecamp.com/1679267/projects/764604-bcx-phon...
Re: GitHub's on your phone
#70Earlier quoted context omitted.
Zach, what was the reasoning behind using such large text for the code view? Will there be a zoom in/out option? Or a text size preference?
To make it easy to read code. :) It feels pretty comfortable- squinting isn't fun. We tend to avoid user preferences. If it ends up being a problem, we'll lower the text size at some point.
I'm old and I like big fonts. But on my Galaxy Note II, this is too big for me.
I like word wrap too, but I'd like to be able to switch it off. In my desktop code editors, I generally use proportional fonts and enable word wrap, but sometimes I also like to be able to see the structure of the code without the word wrap.
I think font size and word wrap should be things that are easy to toggle right there while you're looking at the code. Not in an option setting somewhere. Or enable pinch-zoom for the font size and just have an option to toggle word wrap.