SQL injection search

#1

Post by mike_esspe » Sat, Jun 01, 2013, 5:44 PM UTC

Re: SQL injection search

#2

Post by thiderman » Sat, Jun 01, 2013, 6:18 PM UTC

Heh, cute. This means Github could probably do some automated means of informing these people that their code is insecure and would be a danger to themselves and their users. I'm not sure if they should, but it's interesting that they could.

Re: SQL injection search

#3

Post by jonny_eh » Sat, Jun 01, 2013, 6:22 PM UTC

thiderman wrote: post #2

Heh, cute. This means Github could probably do some automated means of informing these people that their code is insecure and would be a danger to themselves and their users. I'm not sure if they should, but it's interesting that they could.

There's definitely an opportunity for a service to help developers spot obvious security holes.

https://codeclimate.com/ is one I've used but it's Ruby only AFAIK.

Re: SQL injection search

#4

Post by blazespin » Sat, Jun 01, 2013, 6:22 PM UTC

GitHub (and friends) sound like a great repository to train and prove the value of an automated code review product.

Re: SQL injection search

#5

Post by kbenson » Sat, Jun 01, 2013, 6:24 PM UTC

I would like to say i'm surprised, but I'm not. PHP makes this easier by not even supporting parameter binding in the older, original mysql binding, so it's more prevalent.

That said, I'm sure a slight tweak to the search would find a lot in other languages as well.

Re: SQL injection search

#6

Post by marizcombinator » Sat, Jun 01, 2013, 6:28 PM UTC

mysql_query is deprecated... use MySQLi or PDO

Re: SQL injection search

#7

Post by Navarr » Sat, Jun 01, 2013, 6:28 PM UTC

thiderman wrote: post #2

Heh, cute. This means Github could probably do some automated means of informing these people that their code is insecure and would be a danger to themselves and their users. I'm not sure if they should, but it's interesting that they could.

I'm pretty sure anyone can write a github bot. I remember there used to be several (some of which would submit pull requests!)

Re: SQL injection search

#8

Post by Killswitch » Sat, Jun 01, 2013, 6:39 PM UTC

Using unsanitized $_GET is the least of their problems considering mysql_* is deprecated.

Re: SQL injection search

#9

Post by josephscott » Sat, Jun 01, 2013, 6:42 PM UTC

In addition to $_GET searching for $_POST and $_REQUEST are bad too. Could even through in $_COOKIE and $_SERVER for that matter.

Re: SQL injection search

#10

Post by tofflos » Sat, Jun 01, 2013, 6:45 PM UTC

I don't know much about PHP but I happened to rewrite some old forms a couple of years ago. The original author had relied on a technique called "magic quotes" (http://php.net/manual/en/security.magicquotes.php) which automatically sanitized user input. When we upgraded our version of PHP "magic quotes" had been deprecated and dropped.

It would be interesting to know if some of these developers are relying on "magic quotes" or something similar... and also to know how large share of the total number of projects these projects represent.