Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Wait, What?

github.com

Post reply on HN
Print view View original

11–17 of 17 posts

Re: Wait, What?

#11

Post by coldtea »

300bps wrote: post #6

I can't figure out why some developers love writing lines of code like that. It's like they think there is a cost for every line of code so they attempt to use the fewest lines possible while making their intent difficult to discern without comments. I had a young developer work for me that did this all the time. He was actually quite brilliant - but he would put sometimes 20 statements into one line of code that wou…

>It's like they think there is a cost for every line of code

Well, there is. More LOC is the most stable predictor of more bugs.

Of course, complexity per LOC also matters.

Re: Wait, What?

#12

Post by masklinn »

aquarion wrote: post #9
m12k wrote: post #8

Earlier quoted context omitted.

Also, if we ignore for a moment how hacky it is to implement throttling like this - why would someone write if(!((_ok) ? true : (Math.random() > 0.1))) when you could use if(!(_ok || Math.random() > 0.1)) or just if(!_ok && Math.random()

Because Math.random's expensive and you don't want to execute it unless you're sure.

The && operator short-circuits, if `!_ok` Math.random won't be called at all.

Re: Wait, What?

#13

Post by jackcviers3 »

This reads like they were in a hurry. How many of us have written crazy debugging lines? There seems to be a morbid desire to crawl gh source code for obscure wtfs and expose the coder as a Bad Programmer. This line is in an oss project, enter an issue, fork it, and submit a pull-request. Way more productive way of wtf mining than submitting ssomething to community ridicule.

Re: Wait, What?

#15

Post by redblacktree »

300bps wrote: post #6

I can't figure out why some developers love writing lines of code like that. It's like they think there is a cost for every line of code so they attempt to use the fewest lines possible while making their intent difficult to discern without comments. I had a young developer work for me that did this all the time. He was actually quite brilliant - but he would put sometimes 20 statements into one line of code that wou…

Code golfer.

Re: Wait, What?

#16

Post by notdonspaulding »

300bps wrote: post #6

I can't figure out why some developers love writing lines of code like that. It's like they think there is a cost for every line of code so they attempt to use the fewest lines possible while making their intent difficult to discern without comments. I had a young developer work for me that did this all the time. He was actually quite brilliant - but he would put sometimes 20 statements into one line of code that wou…

`but he would put sometimes 20 statements into one line of code`

This is why Python's PEP8 recommends an 80 char limit on line length. Not because at column 81 the code magically becomes more complicated, but because if you're struggling to make it all fit on one line, it's probably a good sign that you need to factor out some complexity.

Although you could certainly still write extremely terse (read: unreadable) code with less than 80 chars per line.

Re: Wait, What?

#17

Post by russelluresti »

My imagination of how this happend:

One Evening, Close to 5:

Boss: "I see we're getting quite a few exception reports in the code."

Developer: "Yeah, working on that. I just need a bit of time."

Boss: "Well, I want to see at least 10% fewer exceptions by tomorrow morning."

Developer: "..."

Next Morning:

Boss: "So I took a look at the reports this morning. Glad to see the number of exceptions are down."

Developer: "..."

Probably got a raise.

Post reply on HN