Live data from Hacker News

Comcast injecting JS

gist.github.com

191–200 of 288 posts

Re: Comcast injecting JS

#191

This is the js my ISP (VodafoneFJ) injects into all web pages: https://gist.github.com/mark-up/5297830 It basically optimizes images and replaces all image alt text with text saying to hit CTRL+R to load full-versions of images. I know that VodafoneUK and VodafoneAU do the same. On the bright side, at least they respect the no-transform cache-control header directive.

I believe T-Mobile does this in the US as well.

Re: Comcast injecting JS

#192

Earlier quoted context omitted.

every 5000ms

Of course the alternative is for comcast users to get together and sue the company for running malicious code on their machines.

Considering the way the handle their customers (myself being one of them), they honestly wouldn't care.

Re: Comcast injecting JS

#193
post #157

Earlier quoted context omitted.

"People just starting out." Ha, you give them too much credit. This code is from a 10-year veteran "consultant," probably charging over $200/hour, brought on by the Global Services company hired by the Consulting Agency that Comcast brought in to assist in completing the critical time-sensitive project as quickly as possible. It was also deemed a great success, and presentations were made about how effective it was,…

They understand that "good code" is code that delivers a lot of value to the person who needs it. Why hate on them for that? You just sound jealous that they make more than you do.

Maybe he has had the pleasure of being someone that gets to maintain that "good" code. I know I have.. and at Comcast no less.

Re: Comcast injecting JS

#194
post #65

This is just one more reason for using HTTPS everywhere . Doing so prevents ISPs from intercepting and rewriting HTTP traffic. Shame on you, Comcast.

Comcast can just as easily MITM your SSL connections, for your safety of course.

But that ridiculous, right? Since everyone verifies SSL cert signatures...

Re: Comcast injecting JS

#195
post #98
post #76

Earlier quoted context omitted.

They're all over the place. People just starting out. It could've been an intern fresh out of college. It could've been someone who just never graduated beyond copy-and-paste-from-StackOverflow. It could've been written by a person who never did web development before and was just told to make it work. The little HN/Twitter/Reddit "awesome programmer" bubble is just that... a bubble. It's easy for us to forget that l…

>They're all over the place. People just starting out. It could've been an intern fresh out of college. It could've been someone who just never graduated beyond copy-and-paste-from-StackOverflow. It could've been written by a person who never did web development before and was just told to make it work. I'm an intern, just moving past S.O. copy-pasta jobs and generally get scared at what the hacker news crowd might s…

One thing I have learned over the years: It is easy to write "this is crap code" over a lot of production code I have seen. But making it better, writing consistently great code in the usual environment is much harder.

Don't let the macho attitude of HN infect you too much - a lot of people here (and elsewhere) are great in criticizing others.

Re: Comcast injecting JS

#196
post #76
post #73

Earlier quoted context omitted.

Ethical stuff aside, I can't imagine hiring someone to actually produce code THIS bad. Where the hell did they find the coder to make this?

They're all over the place. People just starting out. It could've been an intern fresh out of college. It could've been someone who just never graduated beyond copy-and-paste-from-StackOverflow. It could've been written by a person who never did web development before and was just told to make it work. The little HN/Twitter/Reddit "awesome programmer" bubble is just that... a bubble. It's easy for us to forget that l…

You know, there is nothing wrong in picking up code from stack overflow. If you are very efficient in picking up good, well written snippets that fit the style of the project and work without debugging and any time waste - more power to you.

Personally, I consider google search (and stack overflow) as an extension of my development environment and I'd recommend using it and melding your dev env with google search as much as possible. It really helps and speeds things up.

Re: Comcast injecting JS

#197
post #54

Earlier quoted context omitted.

> Whoever wrote this script should be fired. Not to mention the potential GPL violation for cut-n-pasting brainjar code. http://www.brainjar.com/terms.asp

Oh, the irony of Comcast being guilty of copyright infringement....

Can we get them on 6 strikes?

Re: Comcast injecting JS

#198
post #179
post #73

Earlier quoted context omitted.

Ethical stuff aside, I can't imagine hiring someone to actually produce code THIS bad. Where the hell did they find the coder to make this?

Honest question: Why is everyone so cynical and brash here? Is it because we don't like Comcast?

> Honest question: Why is everyone so cynical and brash here?

It's a rockstar developer thing. You wouldn't understand.

Re: Comcast injecting JS

#199
post #157

Earlier quoted context omitted.

They understand that "good code" is code that delivers a lot of value to the person who needs it. Why hate on them for that? You just sound jealous that they make more than you do.

Maybe he has had the pleasure of being someone that gets to maintain that "good" code. I know I have.. and at Comcast no less.

[deleted]

Re: Comcast injecting JS

#200
post #157

Earlier quoted context omitted.

They understand that "good code" is code that delivers a lot of value to the person who needs it. Why hate on them for that? You just sound jealous that they make more than you do.

Maybe he has had the pleasure of being someone that gets to maintain that "good" code. I know I have.. and at Comcast no less.

That's the whole point. Code is not meant to serve the people who maintain it. Maintainability is only a concern once lack of such starts impacting your actual customers. If writing ugly code and fixing it up later is necessary in order to get shit out the door, why is that bad?
Post reply on HN