Comcast injecting JS • Hacker News Board

Re: Comcast injecting JS

#121

Post by RKearney » Wed, Apr 03, 2013, 12:57 AM UTC

awj wrote: post #81

Has this been confirmed to still be happening? The guys blog post[1] states that this was on Nov 20th 2012. Anyone currently using a comcast account want to put down their pitchfork for a second and help verify this? [1] http://blog.ryankearney.com/2013/01/comcast-caught-intercept...

Hi awj, I'm the author of the blog post. As dangrossman said, Comcast only enforces the limit in 2 cities. I live in the Nashville area, so I'm affected. They just doubled my 50Mbps connection to 100Mbps so I will go over my limit this month as I have 2 more grace periods left. If it happens again I'll update my blog post.

Re: Comcast injecting JS

#122

Post by spoiler » Wed, Apr 03, 2013, 1:02 AM UTC

jarek-foksa wrote: post #44

mschuster91 wrote: post #9

OMG LOL. Have they never heard about jQuery? Christ, they could have made the code so much more elegant.

Their jQuery code would probably look like http://enterprise-js.com/23 , with aggressive caching methods used on all jQuery selectors: http://enterprise-js.com/27

Wait, what? Why didn't I know about this website before? I am writing all these down!!!11oneoneone EOSarcasm

Re: Comcast injecting JS

#123

Post by spoiler » Wed, Apr 03, 2013, 1:04 AM UTC

mschuster91 wrote: post #27

hayksaakian wrote: post #22

Earlier quoted context omitted.

right tool for the right job. a 1 page script written for comcast does not demand jQuery. That's not to say it would have improved it.

It at least would remove this damn ugly browser switching code. Hey, it's 2013, no need to reinvent the wheel...

jQuery would make this worse. It would be like adding a truck to be towed by a car that's running out of gas anyway.

Re: Comcast injecting JS

#124

Post by callahad » Wed, Apr 03, 2013, 1:11 AM UTC

RKearney wrote: post #119

desigooner wrote: post #94

Earlier quoted context omitted.

So did Comcast IIRC

I believe Comcast hijacked NXDOMAIN DNS replies and replaced them with their own IP address, causing every non-existant domain name to go to their search page you had to opt-out of.

T-Mobile is currently doing this and does not allow for opt-out.

Re: Comcast injecting JS

#125

Post by DigitalSea » Wed, Apr 03, 2013, 1:13 AM UTC

Some of the worse Javascript I have ever laid my eyes upon. Polluting the global namespace, checks for Netscape Navigator 6... It burns my eyes reading this. Did they actually hire a programmer who wrote this?

Re: Comcast injecting JS

#126

Post by [deleted] » Wed, Apr 03, 2013, 1:13 AM UTC

[deleted]

Re: Comcast injecting JS

#127

Post by _conehead » Wed, Apr 03, 2013, 1:17 AM UTC

My ISP does something similar, but it's meant to inject ads: one ad that scrolls in from the bottom every two-three minutes (for ten seconds or so, and that can't be dismissed), as well as another ad that covers up ads that other websites serve up.[0]

I've now resorted to using a remote VPN for all of my traffic.

[0]: A reddit post in which I discuss it: http://www.reddit.com/r/self/comments/19zhl6/my_isp_is_injec...

Re: Comcast injecting JS

#128

Post by chimeracoder » Wed, Apr 03, 2013, 1:18 AM UTC

dribnet wrote: post #54

STRML wrote: post #35

This code is beyond awful - it fails to display, makes endless AJAX requests, and more; here are a few fun tidbits: 1. The code is not encapsulated in an IIFE, so it clobbers any global variables (like 'image_url') in the page, breaking any scripts relying on those variables. 2. The code spends an inordinate time checking if you're running Netscape Navigator 6. 3. Strangely, they include a whole bunch of code allowin…

> Whoever wrote this script should be fired. Not to mention the potential GPL violation for cut-n-pasting brainjar code. http://www.brainjar.com/terms.asp

Oh, the irony of Comcast being guilty of copyright infringement....

Re: Comcast injecting JS

#129

Post by pjscott » Wed, Apr 03, 2013, 1:20 AM UTC

callahad wrote: post #124

RKearney wrote: post #119

Earlier quoted context omitted.

I believe Comcast hijacked NXDOMAIN DNS replies and replaced them with their own IP address, causing every non-existant domain name to go to their search page you had to opt-out of.

T-Mobile is currently doing this and does not allow for opt-out.

I'm pretty sure you can forcefully opt out by using a DNS server that isn't run by scumbags, like 8.8.8.8 and 8.8.4.4 for Google Public DNS. I hear OpenDNS is similarly good.

Re: Comcast injecting JS

#130

Post by notatoad » Wed, Apr 03, 2013, 1:21 AM UTC

mikeryan wrote: post #5

I'm torn. This seems bad, but the warning (exceeding your bandwidth quota) seems valuable. I can't think of another, better way to message this.

I can't think of a worse way to message it. You don't inject your data into my private communications. No matter what.

The right way would be to ask the customer when they sign up for service what method they would like to receive service notices through. Phone, email, SMS, lettermail, twitter, Facebook, there's a million better ways than to modify my data.