Addition of 1 and 1 in PHP • Hacker News Board

Re: Addition of 1 and 1 in PHP

#11

Post by nikic » Sat, Mar 09, 2013, 2:26 PM UTC

nicholaides wrote: post #10

I'm not familiar with the PHP ecosystem. Is the author making fun something other than obvious over-engineering? Does he or she feel like that's a problem in the PHP ecosystem? I'm criticizing, because it's funny. I'm just trying to figure out if theres some wisdom being conveyed that I'm missing.

I think he is mocking the general pattern of over-engineering and PHP just happens to be the language he wrote this in.

At least PHP is not a language known for massive over-engineering. Usually people associate the exact contrary with PHP.

But there is indeed a recent trend towards better object oriented designs in PHP and with it comes also more over-engineered code. But I have yet to see any Java-style absurdity. Maybe we'll still get to that ;)

Re: Addition of 1 and 1 in PHP

#12

Post by Noxchi » Sat, Mar 09, 2013, 2:26 PM UTC

nicholaides wrote: post #10

I'm not familiar with the PHP ecosystem. Is the author making fun something other than obvious over-engineering? Does he or she feel like that's a problem in the PHP ecosystem? I'm criticizing, because it's funny. I'm just trying to figure out if theres some wisdom being conveyed that I'm missing.

No, you could do this in any OO language. The author is just being silly.

Re: Addition of 1 and 1 in PHP

#13

Post by Mahn » Sat, Mar 09, 2013, 2:29 PM UTC

Reminds me of something I wrote a few months ago on how to detect negative numbers: http://stackoverflow.com/a/11910993/1329367 but obviously the one above has much more value add and follows better design patterns.

Re: Addition of 1 and 1 in PHP

#14

Post by zerovox » Sat, Mar 09, 2013, 2:32 PM UTC

The addition operator takes a collection of numbers, and add the first two? Given the lack of documentation, I find this extremely misleading and I couldn't recommend this library.

Re: Addition of 1 and 1 in PHP

#15

Post by juskrey » Sat, Mar 09, 2013, 2:32 PM UTC

An example is pretty good, but I am not sure about scalability and load balancers.

Re: Addition of 1 and 1 in PHP

#16

Post by sneak » Sat, Mar 09, 2013, 2:34 PM UTC

Oh, did someone port Twisted to PHP?

Re: Addition of 1 and 1 in PHP

#17

Post by Mahn » Sat, Mar 09, 2013, 2:34 PM UTC

nicholaides wrote: post #10

I'm not familiar with the PHP ecosystem. Is the author making fun something other than obvious over-engineering? Does he or she feel like that's a problem in the PHP ecosystem? I'm criticizing, because it's funny. I'm just trying to figure out if theres some wisdom being conveyed that I'm missing.

> Does he or she feel like that's a problem in the PHP ecosystem?

Well, I can't talk for the author, but there is some over-egineering going on in the ecosystem, that's undeniable. I think that since the reputation of the language is low, there's this need to make sure the code doesn't look amateur, which ultimately drives overusing classes and OOP design patterns for the sake of using them.

Re: Addition of 1 and 1 in PHP

#18

Post by Mahn » Sat, Mar 09, 2013, 2:39 PM UTC

juskrey wrote: post #15

An example is pretty good, but I am not sure about scalability and load balancers.

I think this has potential to scale, but you'd probably need to throw in more servers if you plan to handle more than few hundreds of additions per second.

Re: Addition of 1 and 1 in PHP

#19

Post by jablan » Sat, Mar 09, 2013, 2:40 PM UTC

nikic wrote: post #11

nicholaides wrote: post #10

I'm not familiar with the PHP ecosystem. Is the author making fun something other than obvious over-engineering? Does he or she feel like that's a problem in the PHP ecosystem? I'm criticizing, because it's funny. I'm just trying to figure out if theres some wisdom being conveyed that I'm missing.

I think he is mocking the general pattern of over-engineering and PHP just happens to be the language he wrote this in. At least PHP is not a language known for massive over-engineering. Usually people associate the exact contrary with PHP. But there is indeed a recent trend towards better object oriented designs in PHP and with it comes also more over-engineered code. But I have yet to see any Java-style absurdity.…

Don't you think that, when it comes to OOP features, PHP recklessly introduced lots of Javaisms which lose lot of sense when applied to a dynamically typed language? I believe the author had exactly that in mind.

Re: Addition of 1 and 1 in PHP

#20

Post by merinid » Sat, Mar 09, 2013, 2:42 PM UTC

This is so funny. The author's description is great on github, really fooling you at times. Even if this isn't intended as a joke, the dedication to doing something fun to prove a point got me thinking about over engineering design patterns too.