If You Call Out Bad Code, Make Sure It's Bad First
naildrivin5.com
If You Call Out Bad Code, Make Sure It's Bad First
1–10 of 134 posts
Re: If You Call Out Bad Code, Make Sure It's Bad First
#2I found this article helpful.
I was very surprised by the quality of the code in the replace.js repo given the vitriol that surrounded it. I'm not a big contributor to open source, but I've recently made some modifications (improvements?) to a Haskell library I use and was planning to make a pull request soon. This event gave me pause. As someone who couldn't tell what was so eye-bleedingly bad about the replace.js code, I was nervous that I would endure a similar fate.
Re: If You Call Out Bad Code, Make Sure It's Bad First
#3should it exist at all?
Quite an arrogant evaluation criterion IMHO.
Re: If You Call Out Bad Code, Make Sure It's Bad First
#4> Now, I’m all for bad projects and bad code being called out.
Bullshit, sorry.
Questions to ask yourself before "calling out bad code".
1. Does this code belong to someone on your team?
2. Does your code rely on this code?
3. Does the code represent a risk to you or your business in some way?
4. Do you have the direct contact info for the developer so you can appropriately, discretely and professionally inform them about their code?
Github == "Developer Playground/Experimentation Lab".
Why in the hell should I have to feel that every piece of code I put up there 'must' adhere to 'your' standards or anyone else's?
How can we as a development community rationally expect to grow the open source ecosystem and encourage people with this type of snobbery?
Re: If You Call Out Bad Code, Make Sure It's Bad First
#5should it exist at all? Quite an arrogant evaluation criterion IMHO.
You are just angry you didn't get picked to be on the secret GitHub Code Evaluation Committee.
Re: If You Call Out Bad Code, Make Sure It's Bad First
#6I found this article helpful. I was very surprised by the quality of the code in the replace.js repo given the vitriol that surrounded it. I'm not a big contributor to open source, but I've recently made some modifications (improvements?) to a Haskell library I use and was planning to make a pull request soon. This event gave me pause. As someone who couldn't tell what was so eye-bleedingly bad about the replace.js c…
Likewise, I've been meaning to convert my local projects at some point and post them to one of the newfangled online git repos. I was going to use GitHub or Bitbucket to avoid saddling my crap on the git hosting I have available from the open source project I develop for, but now I'm not so sure GitHub is the best place for that.
I don't mind the code being publically-accessible as the price for free hosting but I have no interest in being hounded about my personal scratch code either.
Re: If You Call Out Bad Code, Make Sure It's Bad First
#7> Now, I’m all for bad projects and bad code being called out. Bullshit, sorry. Questions to ask yourself before "calling out bad code". 1. Does this code belong to someone on your team? 2. Does your code rely on this code? 3. Does the code represent a risk to you or your business in some way? 4. Do you have the direct contact info for the developer so you can appropriately, discretely and professionally inform them…
[deleted]
Re: If You Call Out Bad Code, Make Sure It's Bad First
#8> Now, I’m all for bad projects and bad code being called out. Bullshit, sorry. Questions to ask yourself before "calling out bad code". 1. Does this code belong to someone on your team? 2. Does your code rely on this code? 3. Does the code represent a risk to you or your business in some way? 4. Do you have the direct contact info for the developer so you can appropriately, discretely and professionally inform them…
[deleted]
Re: If You Call Out Bad Code, Make Sure It's Bad First
#9> Now, I’m all for bad projects and bad code being called out. Bullshit, sorry. Questions to ask yourself before "calling out bad code". 1. Does this code belong to someone on your team? 2. Does your code rely on this code? 3. Does the code represent a risk to you or your business in some way? 4. Do you have the direct contact info for the developer so you can appropriately, discretely and professionally inform them…
How can we as a development community rationally expect to grow the open source ecosystem and encourage people with this type of snobbery?
There's one lesson that I'm personally taking from this, after unsolicited ridicule, one sincere apology, one bullshit non-apology, and one arrogant I have nothing to apologize for! If I build a small thing to scratch my own itch (which I often do) I'm going to think twice about sharing it with the world at large. Or, more succinctly, I've become yet more of a misanthrope.
Thanks guys!
Re: If You Call Out Bad Code, Make Sure It's Bad First
#10> Now, I’m all for bad projects and bad code being called out. Bullshit, sorry. Questions to ask yourself before "calling out bad code". 1. Does this code belong to someone on your team? 2. Does your code rely on this code? 3. Does the code represent a risk to you or your business in some way? 4. Do you have the direct contact info for the developer so you can appropriately, discretely and professionally inform them…
It's akin to someone judging the quality of "curb alert" listings in Craigslist's Free Stuff category -- I don't think discussing criteria is helpful.