Live data from Hacker News

If you’re trying to hack/deface a website, don’t submit a pull request

github.com

91–100 of 114 posts

Re: If you’re trying to hack/deface a website, don’t submit a pull request

#91
post #46

For anybody too lazy to read through them all, here are some gems: + Are you sure, like, really really sure, you want JavaScript 1.2? +var speed=1 please run jslint on your code before submitting a pull request There are so many errors that JSLint gives up on this code at 39%. +temp=document.body.scrollTop You really shouldn't declare a variable without using var - can lead to all sorts of scoping problems. Oh, good…

[deleted]

Re: If you’re trying to hack/deface a website, don’t submit a pull request

#94

This attempt is blatant and obvious, but what about a more serious attempt where you first establish some credibility with a couple of "good" PR that fix major problems and then add a tiny little backdoor that loads code from somewhere else. Distribute the relevant code over a couple of commits and you might just slip it in. With Githubs ease of merging and automatted testing by Travis, it's easy to forget that chang…

I think that largely depends on who's maintaining the official repo.

See what happened when oh-my-zsh got careless in testing pull requests: https://github.com/robbyrussell/oh-my-zsh/pull/1395/files#L1... everyone who got the update (tons of people, as it's self-updating) had their $HOME screwed up, basically breaking the entire shell.

Point being that trust only goes so far here: proper code reviews are what stop these problems.

Re: If you’re trying to hack/deface a website, don’t submit a pull request

#96
post #55

Earlier quoted context omitted.

There is actually a message: "If there is no check on the freedom of your words, then let your hearts be open to the freedom of our actions" "The war continues until the last Zionist remains on the beloved land of Palestine" cough Shouldn't that be until there are no more Zionists in Palestine? Are they proposing to kill all Zionists until there is just one of them left, and then say "you're the last one here, you ca…

It never fails to cease to amaze me when people people mix up these type of statements.

That was irony, right?

Re: If you’re trying to hack/deface a website, don’t submit a pull request

#97
post #54

Earlier quoted context omitted.

Being sarcastic is puerile?

Also, "protip" has been in use for what, two decades now? When does something stop being a meme and just become an idiom?

An idiom is a meme too

Re: If you’re trying to hack/deface a website, don’t submit a pull request

#98
post #97
post #54

Earlier quoted context omitted.

Also, "protip" has been in use for what, two decades now? When does something stop being a meme and just become an idiom?

An idiom is a meme too

In the sense that it is a cultural artifact that is passed along from one individual to another, yes. In the sense that it is something annoying kids on the internet use that must be complained about, no, not necessarily.

Re: If you’re trying to hack/deface a website, don’t submit a pull request

#99

Earlier quoted context omitted.

Allow? They just released a feature that lets you drag and drop images into comments — it automatically uploads to s3 and inserts the URL in your comment. For some reason, they encourage it.

I assumed that was because of changes in Skitch. Everyone I know used to take screenshots with Skitch, upload them and Skitch would copy the URL into your clipboard and you could post into Github. But since Evernote bought them they closed things down and they're basically useless now, so I figured that was why Github was motivated to add this feature.

You can still download the old version (the real skitch) right there from evernote: http://evernote.com/skitch/ (small link at the bottom, "previous version").

Skitch supports FTP-upload, so if they turn off sharing in the future you can just switch to your own webspace.

No need to mess with lesser tools (or the evernote-garbage) while Skitch still works!

Re: If you’re trying to hack/deface a website, don’t submit a pull request

#100
post #98
post #97

Earlier quoted context omitted.

An idiom is a meme too

In the sense that it is a cultural artifact that is passed along from one individual to another, yes. In the sense that it is something annoying kids on the internet use that must be complained about, no, not necessarily.

I hate the abuse of the word "meme"...
Post reply on HN