God, I'm so tired of animated GIFs in GitHub comment threads. The code critique is far more amusing to me.
I'm more shocked that they even allow images to be embedded in comments.
If you’re trying to hack/deface a website, don’t submit a pull request
11–20 of 114 posts
Re: If you’re trying to hack/deface a website, don’t submit a pull request
#12God, I'm so tired of animated GIFs in GitHub comment threads. The code critique is far more amusing to me.
I'm more shocked that they even allow images to be embedded in comments.
Allow? They just released a feature that lets you drag and drop images into comments — it automatically uploads to s3 and inserts the URL in your comment. For some reason, they encourage it.
Re: If you’re trying to hack/deface a website, don’t submit a pull request
#13God, I'm so tired of animated GIFs in GitHub comment threads. The code critique is far more amusing to me.
I'm more shocked that they even allow images to be embedded in comments.
It's useful when there's something wrong with the UI, you can attach a screenshot. Emoticons on the other hand are pretty annoying.
Re: If you’re trying to hack/deface a website, don’t submit a pull request
#14Pull request might not be a terrible attack vector. I'm sure there are plenty of people out there who don't look carefully and just merge them in.
Re: If you’re trying to hack/deface a website, don’t submit a pull request
#15What is happening here? I am not very accustomed to open source yet.
Edit: un-checking "show inline notes" helps.
Edit 2: So if I understand correctly, OP tried to hack into a website... by submitting code to github. I was confused at first because that would have been (very) wrong way to "hack", but as it turns out, that is indeed true. And rest is about the code he/she used. It seems to be auto generated in some wysiwyg html editor that uses old html.
Re: If you’re trying to hack/deface a website, don’t submit a pull request
#16Earlier quoted context omitted.
I'm more shocked that they even allow images to be embedded in comments.
Allow? They just released a feature that lets you drag and drop images into comments — it automatically uploads to s3 and inserts the URL in your comment. For some reason, they encourage it.
I assumed that was because of changes in Skitch. Everyone I know used to take screenshots with Skitch, upload them and Skitch would copy the URL into your clipboard and you could post into Github. But since Evernote bought them they closed things down and they're basically useless now, so I figured that was why Github was motivated to add this feature.
Re: If you’re trying to hack/deface a website, don’t submit a pull request
#17Re: If you’re trying to hack/deface a website, don’t submit a pull request
#18Pull request might not be a terrible attack vector. I'm sure there are plenty of people out there who don't look carefully and just merge them in.
In fact, I might go so far as to say that this was never intended to be merged. I'll assume whoever did this wants their message heard, and while it will never show up on CoderDojo, the hodgepodge of coding styles ensures that the "pull request" will go viral, thus possibly reaching a far greater number of people than it would have otherwise.
/tinfoil
Re: If you’re trying to hack/deface a website, don’t submit a pull request
#19"Social hacking": the next big thing.
Re: If you’re trying to hack/deface a website, don’t submit a pull request
#20Please GitHub, implement the evil bit [1] on pull requests so we can filter out defacing attempts when merging.