Live data from Hacker News

Is this a good commit message?

core.trac.wordpress.org

11–20 of 49 posts

Re: Is this a good commit message?

#11
post #3
post #2

What is this the anti-fun brigade?

Sounds like a reasonable question, actually: is it a good commit message? I'm really not sure, but am inclined towards yes.

It's not, as it doesn't do anything to describe the problem or the solution.

However, the change is so trivial that it's immediately apparent, so who cares :)

Re: Is this a good commit message?

#13
post #3
post #2

What is this the anti-fun brigade?

Sounds like a reasonable question, actually: is it a good commit message? I'm really not sure, but am inclined towards yes.

I enjoyed it despite its failure to describe the changeset. More good than harm. I was glad he did it.

The author subtly called out each WordPress core team member in the text with personal attributes and inside jokes. Even without that context, a person could enjoy it.

Re: Is this a good commit message?

#15
post #8

It is a joke, but one of the best commit message I've seen lately is from PostgreSQL - for example from Tom Lane - where each bug, or new feature is explained well. I wish I can write such. My commit messages are terrible to my home projects, at least at work I'm following some established rules and it's easier there...

I write good commit messages that are serious, too. Only a few hours earlier: http://core.trac.wordpress.org/changeset/23083

Re: Is this a good commit message?

#16
post #15
post #8

It is a joke, but one of the best commit message I've seen lately is from PostgreSQL - for example from Tom Lane - where each bug, or new feature is explained well. I wish I can write such. My commit messages are terrible to my home projects, at least at work I'm following some established rules and it's easier there...

I write good commit messages that are serious, too. Only a few hours earlier: http://core.trac.wordpress.org/changeset/23083

I love you for giving yourself props.

Re: Is this a good commit message?

#17

I don't know. The writing is okay, there weren't any spelling mistakes that I noticed, but the use of three words written in only capital letters was somewhat disconcerting. I'd say if the author wants to get it accepted for publication somewhere reasonably mainstream he's going to need someone else working at arm's length who is willing to take the time to go through it and highlight areas for revision and expansion…

Subsides -> subsists. Not strictly spelling, but definitely a mistake...

Otherwise a pretty awesome commit message. Better than my personal most used (before work moved to git and let me rewrite local history): "oops, forgot to add the new file" and "oops, fix up the bloody test"...

Re: Is this a good commit message?

#18
post #3
post #2

What is this the anti-fun brigade?

Sounds like a reasonable question, actually: is it a good commit message? I'm really not sure, but am inclined towards yes.

If they'd managed to work in the actual reason for the change, it'd be just that much better.

Other than that, that's one bored dev.

Or, that's the kind of stuff I write when I'm bored and punchy at the end of a long night.

Re: Is this a good commit message?

#20
post #14

The English word "apron", as I understand it, used to be "napron". "A napron" eventually shifted to "an apron". See http://www.thefreedictionary.com/Napron .

That's funny, the reverse process created the word "nuncle" from "mine uncle". http://en.wiktionary.org/wiki/nuncle
Post reply on HN