The primary purpose of code review is to find code that will be hard to maintain
1–10 of 193 posts
Re: The primary purpose of code review is to find code that will be hard to maintain
#2I think you're missing the point of code review.
By the time when the PR is ready to merge, discussions around the architecture and how the code should be structured should already be part of the tech design of a given feature. So the discussion around whether a A feature is built and planned in a maintainable way, should be way before a PR is filed.
A PR review is making sure that you verify against the already agreed-upon structure, making sure everything matches the plan, and also find bugs and stuff that was missed, according to the plan.
Re: The primary purpose of code review is to find code that will be hard to maintain
#3Found plenty of bugs by reading/doing code review.
Re: The primary purpose of code review is to find code that will be hard to maintain
#4The primary purpose of code review is to maintain existing hierarchy by preventing junior SWEs from getting promoted by committing code that is smarter than what the senior architect can understand.
Re: The primary purpose of code review is to find code that will be hard to maintain
#5True - the biggest thing I want to catch in an MR is "will this change lead us onto a path that is uglier, buggier, less maintenanable".
People will generally copy and follow existing patterns, so for example if you let somebody add a new internal date time format, then soon your codebase will bifurcate and there'll be multiple inconsistent versions roaming around.
The other stuff (minor bugs, overly verbose code) can easily be fixed. Paradigm rot cannot.
Re: The primary purpose of code review is to find code that will be hard to maintain
#6My attitude has always been that code review is best thought of as the gate where code goes from being owned by the author to being owned by the team or project. The code I'm reviewing is not your code, it is code that is about to become our code.
Maintainability is a major factor in that, of course.
Re: The primary purpose of code review is to find code that will be hard to maintain
#7The primary purpose of code review is to maintain existing hierarchy by preventing junior SWEs from getting promoted by committing code that is smarter than what the senior architect can understand.
If the code is so smart that it's not easily understandable, it's not easily fixable. My transition from junior to senior was accompanied by the realization that simpler is nearly always better.
Re: The primary purpose of code review is to find code that will be hard to maintain
#8Uh.. why not both?
Re: The primary purpose of code review is to find code that will be hard to maintain
#9I think you're missing the point of code review. By the time when the PR is ready to merge, discussions around the architecture and how the code should be structured should already be part of the tech design of a given feature. So the discussion around whether a A feature is built and planned in a maintainable way, should be way before a PR is filed. A PR review is making sure that you verify against the already agre…
Not every codebase project etc use such workflow
Also such approach doesnt work with bug fixes / regressions
Re: The primary purpose of code review is to find code that will be hard to maintain
#10Sure, ensuring maintainability is one of the benefits of code reviews, but I think it is a bold claim to say that's the solo purpose. For example, code reviews is also a tool that allows teams to get inform of the changes in the code and share responsibility of the whole code base.