24 Pull Requests - Giving little gifts of code for Christmas
11–20 of 39 posts
Re: 24 Pull Requests - Giving little gifts of code for Christmas
#12I love this idea and have been thinking about contributing to a project. It's just the incentive I needed to go do it. When selecting a project, should I evaluate the # of pull requests or issues to determine which projects could use the most help? For the OSS pros out there, does it matter?
Re: 24 Pull Requests - Giving little gifts of code for Christmas
#13Re: 24 Pull Requests - Giving little gifts of code for Christmas
#14Fantastic idea. Now someone gift suhosin code for php 5.4 https://github.com/stefanesser/suhosin/ I am starting to fear one-person projects no matter how great.
> I am starting to fear one-person projects no matter how great. Never rely on a one-person project unless you can support the code yourself if you find significant bugs. If that one person is busy or just plain unavailable and you can't investigate and possibly fix the problem yourself, you are out of luck. Obviously there are a few exceptions to that, for instance if the project is very widely used then you will ge…
Now, clearly, supporting the code yourself will not always be an option or a good choice; it's just much more likely to be viable with a one-person project.
Re: 24 Pull Requests - Giving little gifts of code for Christmas
#15I love this idea and have been thinking about contributing to a project. It's just the incentive I needed to go do it. When selecting a project, should I evaluate the # of pull requests or issues to determine which projects could use the most help? For the OSS pros out there, does it matter?
First find a project you find interesting, or otherwise worthy. Then, I wouldn't worry about the # of pull requests, just that they have recently accepted pull requests. Once you know they are open to receiving requests, then look at issues to see what low hanging fruit there may be.
Re: 24 Pull Requests - Giving little gifts of code for Christmas
#16Pull requests are welcome :)
Re: 24 Pull Requests - Giving little gifts of code for Christmas
#171 per day for projects I am unfamiliar with seems aggressive. I wonder if I would even be able to add any value with such a shallow understanding of the projects. I think 1/week is probably more reasonable if you are trying to get people who don't contribute to get involved.
It taught me to love Github even more - with the file editing in the browser I could clone, make my change and submit my pull request all without ever cloning the repo locally.
Re: 24 Pull Requests - Giving little gifts of code for Christmas
#181 per day for projects I am unfamiliar with seems aggressive. I wonder if I would even be able to add any value with such a shallow understanding of the projects. I think 1/week is probably more reasonable if you are trying to get people who don't contribute to get involved.
Re: 24 Pull Requests - Giving little gifts of code for Christmas
#19Re: 24 Pull Requests - Giving little gifts of code for Christmas
#201 per day for projects I am unfamiliar with seems aggressive. I wonder if I would even be able to add any value with such a shallow understanding of the projects. I think 1/week is probably more reasonable if you are trying to get people who don't contribute to get involved.
* Documentation fixes - clarifications of parts you find confusing, inconsistencies with current behavior, etc.
* Convention fixes - are most binary checks names IsFoo() but one is named Foo_exists() ? do a quick refactor patch for it. Is one Exception named oddly, or have an unclear message? Patch is quick.
* Examples - does an example highlighting something you're confused about exist? Once you figure it out, whip up an example and contribute. Others are also confused about it - I promise.
* Code commenting - Do the comments contradict the code? Is there something in the code that confuses you? Once you figure it out, fix it and submit.
These are all things that are actually EASIER for newcomers to a project to do - once the quirk has been internalized by a dev, they frequently don't notice it anymore. Particularly with documentation and commenting stuff.
It is harder to do this with giant/super popular projects, but medium and smaller projects can always use this sort of support. For example - I decided to checkout Marionette a couple weeks ago. I was reading the docs and browsing the code to see how something was implemented, and noticed the docs and the code were not in sync. I created and submitted a patch within hours of first learning of the project. This was also a work day, so most of those hours were not spent on anything at all related. The patch was accepted - not a big deal thing, but it was nice to contribute, and it may save someone else half an hour of figuring out what was happening. The dev who merged it actually commented that he didn't realize the docs were out of date - because he knows the code.
Point being, little contributions like this abound. As a project owner, I don't care when contributions are major deals or little tweaks or documentation helpers. I'm just happy when someone contributes, it makes me feel that my project is worth the effort. Which I think may be the point of the idea anyway.