On Rendering Diffs
pierre.computer
On Rendering Diffs
1–10 of 73 posts
Re: On Rendering Diffs
#2A bit of a technical deep dive into how we built CodeView, a review surface that can handle rendering diffs of immense size, all in a browser.
Re: On Rendering Diffs
#3For anyone else who's suffering, paste this in the console in devtools:
document.getElementsByTagName('main')[0].style.margin = '0 auto';Re: On Rendering Diffs
#4Very impressive! I doubt Github or Gitlab would ever do something as good as this but maybe there's a chance we could get it in Forgejo?
Re: On Rendering Diffs
#5A bit of a technical deep dive into how we built CodeView, a review surface that can handle rendering diffs of immense size, all in a browser.
big fan :)
Re: On Rendering Diffs
#6For anyone else who's suffering, paste this in the console in devtools: document.getElementsByTagName('main')[0].style.margin = '0 auto';
lmao - thank you!
Re: On Rendering Diffs
#7I was hoping that this would talk more about the logic behind generating a diff, rather than the optimisations involved in rendering the text.
IMO (as someone who doesn't have to deal with the actual rendering) it would go a bit deeper into talking about deciding how to show what has changed. There's a lot of improvements that could be made there. e.g. "whitespace has changed here" so there's no real code changes involved.
Or "this big list of imports has changed, and code formatting has line-wrapped the list into different lines" - gitlab for example copes poorly with this. I'd love to just see a clean diff that highlights the additional import, and not just ten lines of changes caused by adding one line to a big list of imported symbols/functions.
Re: On Rendering Diffs
#8Maybe an intended effect, but the header ascii art is suspiciously misaligned... :^)
Re: On Rendering Diffs
#9Semi-related: have you considered making DiffsHub a browser extension, so you can serve private diffs as well?
(I say this, having done a vibe-port of the code to a browser extension, so the underlying concept works.)
Re: On Rendering Diffs
#10For anyone else who's suffering, paste this in the console in devtools: document.getElementsByTagName('main')[0].style.margin = '0 auto';
thank you, how do they live like this.