A Better Twitter Bootstrap Modal • Hacker News Board

moe wrote: post #50

pebb wrote: post #49

Earlier quoted context omitted.

Not without heavy js code

Well, I actually submitted a pull-request almost a year ago but it was rejected for "complexity"... I didn't understand that decision back then and I don't understand it today. The patch weighs in at about 100 lines which doesn't seem heavy to me. Especially when you consider that without the patch the bootstrap-"modal" is not a modal ... Anyway, here's the fixed bootstrap-modal.js for the version that was current ba…

You might want to change the language/syntax highlighting of that gist. That apostrophe on line 120...

Re: A Better Twitter Bootstrap Modal

#54

Post by johnx123-up » Thu, Nov 22, 2012, 5:03 AM UTC

My wishlist

  1. Ajax loader inside the modal (load modal first)
  2. Pinterest like modal (aka modal with HTML5 history API / 
     hashchange / browser back button support)

Re: A Better Twitter Bootstrap Modal

#55

Post by hayksaakian » Thu, Nov 22, 2012, 6:40 AM UTC

Laggy scrolling on galaxy nexus cm10

But I don't blame you, its probably just chrome 18 being ancient.

Re: A Better Twitter Bootstrap Modal

#56

Post by krichman » Thu, Nov 22, 2012, 7:13 AM UTC

This is a nice modal, but I'd much rather never have a modal ever. The only time a modal should appear is if a critical error occurred that the user must know about immediately. For most cases where modals tend to get used, like on iOS "please rate us", or "we want your contact information now", I don't think it is appropriate at all.

Re: A Better Twitter Bootstrap Modal

#57

Post by yusw » Thu, Nov 22, 2012, 7:52 AM UTC

This is great! Thanks for sharing!

Re: A Better Twitter Bootstrap Modal

#58

Post by trevorcreech » Thu, Nov 22, 2012, 8:20 AM UTC

krichman wrote: post #56

This is a nice modal, but I'd much rather never have a modal ever. The only time a modal should appear is if a critical error occurred that the user must know about immediately. For most cases where modals tend to get used, like on iOS "please rate us", or "we want your contact information now", I don't think it is appropriate at all.

Obviously auto-popup modals are bad, but modals are great for signup and login forms.

Re: A Better Twitter Bootstrap Modal

#59

Post by zoobert » Thu, Nov 22, 2012, 8:57 AM UTC

Great. Thanks for making it available freely. It will be very useful to build desktop application with bootstrap and node-webkit or appjs for example.

Re: A Better Twitter Bootstrap Modal

#60

Post by conradfr » Thu, Nov 22, 2012, 9:18 AM UTC

krichman wrote: post #56

This is a nice modal, but I'd much rather never have a modal ever. The only time a modal should appear is if a critical error occurred that the user must know about immediately. For most cases where modals tend to get used, like on iOS "please rate us", or "we want your contact information now", I don't think it is appropriate at all.

Modal may not be great on public websites but they are essential on web apps.

And not everything is mobile web.